From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by dpdk.org (Postfix) with ESMTP id 015295A7A for ; Wed, 4 Mar 2015 21:55:39 +0100 (CET) Received: by wevm14 with SMTP id m14so48879416wev.13 for ; Wed, 04 Mar 2015 12:55:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+uXLbnNAfgE7V7hCTxv/CQLc3KEMpUnFIpU6bhO4g34=; b=iar2DDSja1rQz19FM/db8si/y8qmUPmkloky5gF1DT2hbBXTPZqD98OwPKgHnLniSN bIjKJC1FjfgSHJnl9Ulz2qaFVVogCMq6gFNRIr71nL3d1unHNjeNs4z1nmdi7NCDi44E HN7G9KS2X7iS1TwpyL7fcsvmzkpsVDvbW59IrEe1yCCCmzHmHajF1VCP8KfiOv4tU2t6 Qd03wktgusNIhSy0+/r1WSQO76fOSOKv9CCA6QssFI7Ilspck2VMQPnsx+ho63H2isdG 4hWukwFWbIc/OTvD+L0L+Mz+DAnzvz5FRs/MMzKh2Em+sCoQOui2NRt8skY7P1KCANTF 0UIw== X-Gm-Message-State: ALoCoQlox1UUGbGBaeC846yem+Dz1TgwPGIDWUiu43VB9Kkjfb+9hscc889APEr28IpK6TrWtCxQ X-Received: by 10.194.237.34 with SMTP id uz2mr11313557wjc.157.1425502539637; Wed, 04 Mar 2015 12:55:39 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u16sm7549040wjr.5.2015.03.04.12.55.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2015 12:55:38 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Date: Wed, 04 Mar 2015 21:55:05 +0100 Message-ID: <1605137.dhuUauZInt@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150127113847.3d4d32a0@uryu.home.lan> References: <1421994224-2127-1-git-send-email-stephen@networkplumber.org> <7916082.1WV7FdSlI3@xps13> <20150127113847.3d4d32a0@uryu.home.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 20:55:40 -0000 Anyone to carefully review this patch? 2015-01-27 11:38, Stephen Hemminger: > On Tue, 27 Jan 2015 11:11:39 +0100 > Thomas Monjalon wrote: > > > Hi Stephen, > > > > 2015-01-22 22:23, stephen@networkplumber.org: > > > From: Stephen Hemminger > > > > > > The ixgbe driver was including CRC in the transmit packet byte > > > count, but not for packets received. This was notice when forwarding and > > > the number of bytes received was greater than the number of bytes transmitted > > > > Tx includes CRC and Rx count is greater, really? ping > > > for the same number of packets. Make the driver behave like other > > > virtual devices and not include CRC in byte count. Use the same queue > > > counters already computed and used for Rx. > > > > Please could you describe the difference between gptc/gotc and qptc/qbtc? > > > > Thank you > > > The byte counts for global registers include CRC in the byte count. > This has been observed by experimentation and validated by QA and documented > in Intel HW specs. > > The original code used queue counts for Rx because the global counters > include missed packets (which must not be included in the ipacket counts). > I suspect that is why the original developer used the queue counts, as > a good side effect the Rx byte count was correct (no CRC). I just extended > this for Tx.