DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix wrong function of hairpin unbind
@ 2020-11-13  7:05 Bing Zhao
  2020-11-13 19:09 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Bing Zhao @ 2020-11-13  7:05 UTC (permalink / raw)
  To: viacheslavo, matan; +Cc: dev, orika, rasland

In the implementation of mlx5_hairpin_unbind, a copy-paste error was
inside. If a single peer Rx port needed to be unbound, it would be
bound again by mistake.

All the hardware resources were released when stopping the device and
no mess of the configuration was introduced. But when trying to unbind
the ports again, the issue would appear.

The typo of the function call is fixed. If there is no hairpin queue
bound between two ports, the unbinding process should be considered
successful.

Fixes: 37cd4501e873 ("net/mlx5: support two ports hairpin mode")

Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx5/mlx5_trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index 46e4191..bd02915 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -934,7 +934,7 @@
 				return ret;
 		}
 	else
-		ret = mlx5_hairpin_bind_single_port(dev, rx_port);
+		ret = mlx5_hairpin_unbind_single_port(dev, rx_port);
 	return ret;
 }
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong function of hairpin unbind
  2020-11-13  7:05 [dpdk-dev] [PATCH] net/mlx5: fix wrong function of hairpin unbind Bing Zhao
@ 2020-11-13 19:09 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-11-13 19:09 UTC (permalink / raw)
  To: Bing Zhao; +Cc: viacheslavo, matan, dev, orika, rasland, asafp

13/11/2020 08:05, Bing Zhao:
> In the implementation of mlx5_hairpin_unbind, a copy-paste error was
> inside. If a single peer Rx port needed to be unbound, it would be
> bound again by mistake.
> 
> All the hardware resources were released when stopping the device and
> no mess of the configuration was introduced. But when trying to unbind
> the ports again, the issue would appear.
> 
> The typo of the function call is fixed. If there is no hairpin queue
> bound between two ports, the unbinding process should be considered
> successful.
> 
> Fixes: 37cd4501e873 ("net/mlx5: support two ports hairpin mode")
> 
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Applied in next-net-mlx, thanks.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-13 19:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13  7:05 [dpdk-dev] [PATCH] net/mlx5: fix wrong function of hairpin unbind Bing Zhao
2020-11-13 19:09 ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git