From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com,
david.marchand@redhat.com, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [RFC PATCH 0/2] standardize rawdev names
Date: Fri, 05 Jul 2019 11:39:51 +0200 [thread overview]
Message-ID: <1605498.ZGlQ3oZTaz@xps> (raw)
In-Reply-To: <2033098.zfnWnl858g@xps>
05/07/2019 11:38, Thomas Monjalon:
> 05/07/2019 11:35, Bruce Richardson:
> > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote:
> > > The names of the rawdev drivers and the resultant libraries they built
> > > were pretty inconsistent. In terms of directory names, some had "rawdev"
> > > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't.
> > > Also, for the built .so/.a libraries, the names were not always
> > > consistent between make and meson, as, while meson enforced a consistent
> > > naming scheme, make did not, leading to differences - especially for
> > > those drivers with "rawdev" in the directory name.
> > >
> > > This patchset attempts to make things more standardized by removing
> > > "rawdev" from all directory names - the drivers are in the "drivers/raw"
> > > directory after all - and then standardizing the library names to
> > > "librte_rawdev_<name>" for both make and meson.
> > >
> > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory
> > > names drivers/raw: standardize name format of rawdev drivers
> > >
> > Since the .so/.a files we produce are changing, would this patchset - if
> > accepted - need a deprecation notice in 19.08 for a future 19.11 merge?
>
> I would say we can merge it in 19.08 without prior notice.
> Any other opinion?
Cc Neil
next prev parent reply other threads:[~2019-07-05 9:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 9:33 Bruce Richardson
2019-07-05 9:34 ` [dpdk-dev] [RFC PATCH 1/2] drivers/raw: remove rawdev from driver directory names Bruce Richardson
2019-07-05 9:34 ` [dpdk-dev] [RFC PATCH 2/2] drivers/raw: standardize name format of rawdev drivers Bruce Richardson
2019-07-05 9:35 ` [dpdk-dev] [RFC PATCH 0/2] standardize rawdev names Bruce Richardson
2019-07-05 9:38 ` Thomas Monjalon
2019-07-05 9:39 ` Thomas Monjalon [this message]
2019-07-30 8:17 ` Thomas Monjalon
2019-07-30 9:42 ` Bruce Richardson
2019-07-30 12:20 ` Neil Horman
2019-07-30 13:28 ` Thomas Monjalon
2019-07-30 13:39 ` [dpdk-dev] [PATCH v2 " Thomas Monjalon
2019-07-30 13:39 ` [dpdk-dev] [PATCH v2 1/2] drivers/raw: remove rawdev from directory names Thomas Monjalon
2019-07-31 7:28 ` Xu, Rosen
2019-07-30 13:39 ` [dpdk-dev] [PATCH v2 2/2] drivers/raw: standardize naming Thomas Monjalon
2019-07-31 7:29 ` Xu, Rosen
2019-07-31 8:27 ` Thomas Monjalon
2019-07-30 17:44 ` [dpdk-dev] [PATCH v2 0/2] standardize rawdev names Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605498.ZGlQ3oZTaz@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=nhorman@tuxdriver.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).