From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
To: dev@dpdk.org
Cc: rasland@nvidia.com, matan@nvidia.com, orika@nvidia.com,
thomas@monjalon.net, iryzhov@nfware.com
Subject: [dpdk-dev] [PATCH] net/mlx5: make ethernet xstats names compliant
Date: Thu, 19 Nov 2020 19:18:05 +0000 [thread overview]
Message-ID: <1605813485-8075-1-git-send-email-viacheslavo@nvidia.com> (raw)
xstats names for simple stats are mostly standardized in ethdev drivers
and should be compliant with [1]
[1] http://doc.dpdk.org/guides/prog_guide/poll_mode_drv.html?highlight=xstats#extended-statistics-api
Reported-by: Igor Ryzhov <iryzhov@nfware.com>
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
drivers/net/mlx5/linux/mlx5_ethdev_os.c | 54 ++++++++++++++++-----------------
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index f7ef149..d1ca51a 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -1315,71 +1315,71 @@ int mlx5_get_module_eeprom(struct rte_eth_dev *dev,
static const struct mlx5_counter_ctrl mlx5_counters_init[] = {
{
- .dpdk_name = "rx_port_unicast_bytes",
+ .dpdk_name = "rx_unicast_bytes",
.ctr_name = "rx_vport_unicast_bytes",
},
{
- .dpdk_name = "rx_port_multicast_bytes",
+ .dpdk_name = "rx_multicast_bytes",
.ctr_name = "rx_vport_multicast_bytes",
},
{
- .dpdk_name = "rx_port_broadcast_bytes",
+ .dpdk_name = "rx_broadcast_bytes",
.ctr_name = "rx_vport_broadcast_bytes",
},
{
- .dpdk_name = "rx_port_unicast_packets",
+ .dpdk_name = "rx_unicast_packets",
.ctr_name = "rx_vport_unicast_packets",
},
{
- .dpdk_name = "rx_port_multicast_packets",
+ .dpdk_name = "rx_multicast_packets",
.ctr_name = "rx_vport_multicast_packets",
},
{
- .dpdk_name = "rx_port_broadcast_packets",
+ .dpdk_name = "rx_broadcast_packets",
.ctr_name = "rx_vport_broadcast_packets",
},
{
- .dpdk_name = "tx_port_unicast_bytes",
+ .dpdk_name = "tx_unicast_bytes",
.ctr_name = "tx_vport_unicast_bytes",
},
{
- .dpdk_name = "tx_port_multicast_bytes",
+ .dpdk_name = "tx_multicast_bytes",
.ctr_name = "tx_vport_multicast_bytes",
},
{
- .dpdk_name = "tx_port_broadcast_bytes",
+ .dpdk_name = "tx_broadcast_bytes",
.ctr_name = "tx_vport_broadcast_bytes",
},
{
- .dpdk_name = "tx_port_unicast_packets",
+ .dpdk_name = "tx_unicast_packets",
.ctr_name = "tx_vport_unicast_packets",
},
{
- .dpdk_name = "tx_port_multicast_packets",
+ .dpdk_name = "tx_multicast_packets",
.ctr_name = "tx_vport_multicast_packets",
},
{
- .dpdk_name = "tx_port_broadcast_packets",
+ .dpdk_name = "tx_broadcast_packets",
.ctr_name = "tx_vport_broadcast_packets",
},
{
- .dpdk_name = "rx_wqe_err",
+ .dpdk_name = "rx_wqe_errors",
.ctr_name = "rx_wqe_err",
},
{
- .dpdk_name = "rx_crc_errors_phy",
+ .dpdk_name = "rx_phy_crc_errors",
.ctr_name = "rx_crc_errors_phy",
},
{
- .dpdk_name = "rx_in_range_len_errors_phy",
+ .dpdk_name = "rx_phy_in_range_len_errors",
.ctr_name = "rx_in_range_len_errors_phy",
},
{
- .dpdk_name = "rx_symbol_err_phy",
+ .dpdk_name = "rx_phy_symbol_errors",
.ctr_name = "rx_symbol_err_phy",
},
{
- .dpdk_name = "tx_errors_phy",
+ .dpdk_name = "tx_phy_errors",
.ctr_name = "tx_errors_phy",
},
{
@@ -1388,44 +1388,44 @@ int mlx5_get_module_eeprom(struct rte_eth_dev *dev,
.dev = 1,
},
{
- .dpdk_name = "tx_packets_phy",
+ .dpdk_name = "tx_phy_packets",
.ctr_name = "tx_packets_phy",
},
{
- .dpdk_name = "rx_packets_phy",
+ .dpdk_name = "rx_phy_packets",
.ctr_name = "rx_packets_phy",
},
{
- .dpdk_name = "tx_discards_phy",
+ .dpdk_name = "tx_phy_discard_packets",
.ctr_name = "tx_discards_phy",
},
{
- .dpdk_name = "rx_discards_phy",
+ .dpdk_name = "rx_phy_discard_packets",
.ctr_name = "rx_discards_phy",
},
{
- .dpdk_name = "tx_bytes_phy",
+ .dpdk_name = "tx_phy_bytes",
.ctr_name = "tx_bytes_phy",
},
{
- .dpdk_name = "rx_bytes_phy",
+ .dpdk_name = "rx_phy_bytes",
.ctr_name = "rx_bytes_phy",
},
/* Representor only */
{
- .dpdk_name = "rx_packets",
+ .dpdk_name = "rx_vport_packets",
.ctr_name = "vport_rx_packets",
},
{
- .dpdk_name = "rx_bytes",
+ .dpdk_name = "rx_vport_bytes",
.ctr_name = "vport_rx_bytes",
},
{
- .dpdk_name = "tx_packets",
+ .dpdk_name = "tx_vport_packets",
.ctr_name = "vport_tx_packets",
},
{
- .dpdk_name = "tx_bytes",
+ .dpdk_name = "tx_vport_bytes",
.ctr_name = "vport_tx_bytes",
},
};
--
1.8.3.1
next reply other threads:[~2020-11-19 19:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 19:18 Viacheslav Ovsiienko [this message]
2020-11-22 12:58 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605813485-8075-1-git-send-email-viacheslavo@nvidia.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).