From: Lijun Ou <oulijun@huawei.com> To: <ferruh.yigit@intel.com> Cc: <dev@dpdk.org>, <linuxarm@huawei.com> Subject: [dpdk-dev] [PATCH 1/4] net/hns3: fix segment fault with the multi-TC Date: Fri, 20 Nov 2020 19:27:33 +0800 Message-ID: <1605871656-51819-2-git-send-email-oulijun@huawei.com> (raw) In-Reply-To: <1605871656-51819-1-git-send-email-oulijun@huawei.com> From: Huisong Li <lihuisong@huawei.com> The HW and SW DCB configurations need to be updated only after the DCB configuration information changed. But the change of tx/rx queue number is ignored. If user decreases the number of tx queue after configuring multi-TC, the queue mapping information in hns3_tc_queue_info can not be updated. And then accessing the released queue resource in "hns3_init_tx_ring_tc" will trigger a segment fault. Fixes: 62e3ccc2b94c ("net/hns3: support flow control") Cc: stable@dpdk.org Signed-off-by: Huisong Li <lihuisong@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- drivers/net/hns3/hns3_dcb.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/hns3/hns3_dcb.c b/drivers/net/hns3/hns3_dcb.c index ab02c87..fb50179 100644 --- a/drivers/net/hns3/hns3_dcb.c +++ b/drivers/net/hns3/hns3_dcb.c @@ -1351,6 +1351,8 @@ hns3_dcb_cfg_validate(struct hns3_adapter *hns, uint8_t *tc, bool *changed) { struct rte_eth_dcb_rx_conf *dcb_rx_conf; struct hns3_hw *hw = &hns->hw; + uint16_t nb_rx_q = hw->data->nb_rx_queues; + uint16_t nb_tx_q = hw->data->nb_tx_queues; uint8_t max_tc = 0; uint8_t pfc_en; int i; @@ -1376,6 +1378,10 @@ hns3_dcb_cfg_validate(struct hns3_adapter *hns, uint8_t *tc, bool *changed) pfc_en = RTE_LEN2MASK((uint8_t)dcb_rx_conf->nb_tcs, uint8_t); if (hw->dcb_info.pfc_en != pfc_en) *changed = true; + + /* tx/rx queue number is reconfigured. */ + if (nb_rx_q != hw->used_rx_queues || nb_tx_q != hw->used_tx_queues) + *changed = true; } static int -- 2.7.4
next prev parent reply other threads:[~2020-11-20 11:27 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-20 11:27 [dpdk-dev] [PATCH 0/4] hns3 fixes Lijun Ou 2020-11-20 11:27 ` Lijun Ou [this message] 2020-11-20 11:27 ` [dpdk-dev] [PATCH 2/4] net/hns3: fix unused queues with not disabled Lijun Ou 2020-11-20 11:27 ` [dpdk-dev] [PATCH 3/4] net/hns3: adjust printing MAC addresses in log Lijun Ou 2020-11-20 14:25 ` Ferruh Yigit 2020-12-07 14:52 ` oulijun 2020-12-10 11:54 ` oulijun 2020-11-20 11:27 ` [dpdk-dev] [PATCH 4/4] net/hns3: fix FEC state query Lijun Ou 2020-11-20 14:33 ` Ferruh Yigit 2020-11-20 14:35 ` Ferruh Yigit 2020-12-02 12:42 ` Min Hu (Connor) 2020-12-07 14:50 ` oulijun 2020-11-20 14:38 ` [dpdk-dev] [PATCH 0/4] hns3 fixes Ferruh Yigit 2020-11-20 14:58 ` oulijun 2020-11-20 15:38 ` Ferruh Yigit 2020-11-20 17:53 ` Ferruh Yigit 2020-12-07 14:54 ` oulijun 2020-12-07 16:17 ` Ferruh Yigit 2020-12-10 12:48 ` [dpdk-dev] [PATCH V2 0/2] " Lijun Ou 2020-12-10 12:48 ` [dpdk-dev] [PATCH V2 1/2] net/hns3: adjust printing MAC addresses in log Lijun Ou 2020-12-10 12:48 ` [dpdk-dev] [PATCH V2 2/2] net/hns3: fix FEC state query Lijun Ou 2020-12-10 16:30 ` [dpdk-dev] [PATCH V2 0/2] hns3 fixes Ferruh Yigit 2020-12-11 1:44 ` oulijun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1605871656-51819-2-git-send-email-oulijun@huawei.com \ --to=oulijun@huawei.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=linuxarm@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git