DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: <kirankn@juniper.net>
Cc: <chas3@att.com>, <david.marchand@redhat.com>, <dev@dpdk.org>,
	<thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] net/bonding: Support configuration for LACP fast timers
Date: Wed, 25 Nov 2020 20:10:24 +0800
Message-ID: <1606306224-27951-1-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <41992913-213C-4922-9893-35F3B516A872@juniper.net>

+/* LACP Rate */
+#define LACP_RATE_SLOW  (0)
+#define LACP_RATE_FAST  (1)

parentheses here can be deleted.


		/* Set balance mode transmit policy*/
		
blank space shoud be added before "*/".
+		if (rte_eth_bond_lacp_rate_set(port_id, lacp_rate)
+				!= 0) {
+			RTE_LOG(ERR, EAL,
+					"Failed to set lacp rate on bonded device %s\n", name);
+			return -1;
+		}


Add a rte APIs to set/get the timeout for LACP

signed-off-by: Kiran KN <kirankn@juniper.net>

By the way, I wish commit info can be more detailed for
These two APIs£¬then we can know the API functino more.
thanks.

      reply	other threads:[~2020-11-25 12:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21  7:53 Kiran KN
2020-11-25 12:10 ` Min Hu (Connor) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1606306224-27951-1-git-send-email-humin29@huawei.com \
    --to=humin29@huawei.com \
    --cc=chas3@att.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=kirankn@juniper.net \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git