From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A27E7A0545;
	Wed, 25 Nov 2020 13:10:21 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 6787FC93E;
	Wed, 25 Nov 2020 13:10:19 +0100 (CET)
Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])
 by dpdk.org (Postfix) with ESMTP id B099CC93A
 for <dev@dpdk.org>; Wed, 25 Nov 2020 13:10:16 +0100 (CET)
Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60])
 by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Ch07Z1lN7zLsJg;
 Wed, 25 Nov 2020 20:09:46 +0800 (CST)
Received: from localhost.localdomain (10.69.192.56) by
 DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id
 14.3.487.0; Wed, 25 Nov 2020 20:10:09 +0800
From: "Min Hu (Connor)" <humin29@huawei.com>
To: <kirankn@juniper.net>
CC: <chas3@att.com>, <david.marchand@redhat.com>, <dev@dpdk.org>,
 <thomas@monjalon.net>
Date: Wed, 25 Nov 2020 20:10:24 +0800
Message-ID: <1606306224-27951-1-git-send-email-humin29@huawei.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <41992913-213C-4922-9893-35F3B516A872@juniper.net>
References: <41992913-213C-4922-9893-35F3B516A872@juniper.net>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.69.192.56]
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH] net/bonding: Support configuration for LACP
	fast timers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

+/* LACP Rate */
+#define LACP_RATE_SLOW  (0)
+#define LACP_RATE_FAST  (1)

parentheses here can be deleted.


		/* Set balance mode transmit policy*/
		
blank space shoud be added before "*/".
+		if (rte_eth_bond_lacp_rate_set(port_id, lacp_rate)
+				!= 0) {
+			RTE_LOG(ERR, EAL,
+					"Failed to set lacp rate on bonded device %s\n", name);
+			return -1;
+		}


Add a rte APIs to set/get the timeout for LACP

signed-off-by: Kiran KN <kirankn@juniper.net>

By the way, I wish commit info can be more detailed for
These two APIs£¬then we can know the API functino more.
thanks.