From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f48.google.com (mail-lf0-f48.google.com [209.85.215.48]) by dpdk.org (Postfix) with ESMTP id 507BB108F for ; Tue, 17 Jan 2017 18:22:32 +0100 (CET) Received: by mail-lf0-f48.google.com with SMTP id v186so113908427lfa.1 for ; Tue, 17 Jan 2017 09:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=BxrPqqP7p0sQygBdm5Rvo8owoRH6Y1Qx80k1iLMmqyg=; b=VMMFj3WSKskeDqUf4vJauuCFYckWmhU/2Q3pFg077JCeLBystF78a67NKhcArp/2xS dhanxqFyMM/JbB7GUOTGWWiAQGCyuBdE5EOYfNB6rvCUUD73dhzIFogiZitz0xKd/8J2 2e0velqN2EszPeOmkLAjrAIJmgtn6adUP+XjfnR+JL3hN04v0PxeWE+3qfVyi0qwmPrt b/7BikxVvTzYOF2O61CcJ0Kmt/CK89l/jnLDjdv6j1q7z2oVQLQSVkCNuIngmdrFwHdu o4RAK7YHZcBkpL0NenuR02Dh0XUio/40JhaQ+uJvi2yC0eUIZ5cahfzl+YP8MuZ4EC6G 7cQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=BxrPqqP7p0sQygBdm5Rvo8owoRH6Y1Qx80k1iLMmqyg=; b=CRxkTP+pAgoj9Wl81PKxLhxzkkayfRz8yZzFDycOaLqrVclGbBreBqBztl0YZSEMWB g+YVUS5It9V2fkaR1eWW5zOOnDyzu0F4DHva+JZE8ZhwumPWt6SS5B4r1oE77qdmSCJo pUZFuGU7XzV5hRupU4u6hX+4ZA3zNi9H0JtcL0eEPblqwiCRMXWKqRV8B05HyALYWspA bxwbqEMZbj6ETPelKdlWPjyTbg2Ef/6a7E/O/1g10nK+wI053o3SPCiNEY9dHrLUjepO W3BfZrbWdppc6CE2buCXX3DCy8SnKhmexoUa5zt9z9yvhpuP++iJ6BjQVNg6DuFBrxYY PwzQ== X-Gm-Message-State: AIkVDXLtSUJjvFl+CmgrjVmXQOvazOyTEUQ+BrFSiq3ID3i3ZLiHxBEcapzV+YkRS2xPvEw5 X-Received: by 10.25.195.144 with SMTP id t138mr4672204lff.78.1484673751648; Tue, 17 Jan 2017 09:22:31 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 187sm9458636ljf.12.2017.01.17.09.22.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2017 09:22:30 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit , matvejchikov@gmail.com Cc: dev@dpdk.org Date: Tue, 17 Jan 2017 18:22:29 +0100 Message-ID: <1606457.4zG12SYGZt@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <18c98c3f-f104-f9a6-f043-5c0421542c51@intel.com> References: <18c98c3f-f104-f9a6-f043-5c0421542c51@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples: fix ip_pipeline makefile typo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 17:22:32 -0000 2016-11-23 15:43, Ferruh Yigit: > On 11/23/2016 12:56 PM, Ilya Matveychikov wrote: > > Signed-off-by: Ilya V. Matveychikov > > --- > > examples/ip_pipeline/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile > > index 5827117..6657237 100644 > > --- a/examples/ip_pipeline/Makefile > > +++ b/examples/ip_pipeline/Makefile > > @@ -36,7 +36,7 @@ endif > > # Default target, can be overridden by command line or environment > > RTE_TARGET ?= x86_64-native-linuxapp-gcc > > > > -DIRS-(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline > > +DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline > > No need to fix, this line can be removed completely. > > Because of: > VPATH += $(SRCDIR)/pipeline > > and files handled in this makefile: > SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_passthrough.c > > When you fix DIR-y, you also need to add a makefile to pipeline folder > and update this makefile. I guess all those are not required. Just > removing that line is easier J There was no progress on this trivial patch. So I made what Ferruh suggested and applied in the tree directly: http://dpdk.org/commit/45e1c8b Thanks for the report and the review.