From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71F4AA052A; Sat, 28 Nov 2020 15:50:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C841C93A; Sat, 28 Nov 2020 15:50:32 +0100 (CET) Received: from mail-m971.mail.163.com (mail-m971.mail.163.com [123.126.97.1]) by dpdk.org (Postfix) with ESMTP id 4ADF4C930 for ; Sat, 28 Nov 2020 15:50:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=Rm3RmVehs5wKqq3Jk1 2H7DZJOjwPaDymgCExaSYR7js=; b=MtlosaNulOjO3fIxla7t1Rhq8qr4yOfqtu HvKBeUpRy1beuN0O7W0z8/bOV0Gm1DWPeUHZcAMdH35z50Ul+QB6KqBIAAv1ADlG Gc0PWR8VraNrJszGg6rlOsJ+cZ1t6w3IjAeJlL9DiBfcg3Q9JEuNbDu0zFVZOFVZ 69Tyaiv8g= Received: from ecs-5dae.localdomain (unknown [119.8.186.164]) by smtp1 (Coremail) with SMTP id GdxpCgDnhUasY8Jf4BkoBA--.1901S2; Sat, 28 Nov 2020 22:50:22 +0800 (CST) From: Jiawei Zhu <17826875952@163.com> To: dev@dpdk.org Cc: liweifeng2@huawei.com, zhujiawei12@huawei.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com Date: Sat, 28 Nov 2020 22:50:20 +0800 Message-Id: <1606575020-2973-1-git-send-email-17826875952@163.com> X-Mailer: git-send-email 1.8.3.1 X-CM-TRANSID: GdxpCgDnhUasY8Jf4BkoBA--.1901S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtF17Zr1xKw4kGr4kJFyUAwb_yoWDWrb_Cr 1xCay3XF18WF1IkrWYkw1Fvr1SvayFqF18X3y5t34rW3y7Jr1xWrnFv3s7WF47Xw17uFZ8 Jrs3Jr909a4SkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8ldgJUUUUU== X-Originating-IP: [119.8.186.164] X-CM-SenderInfo: bprxmjywyxkmivs6il2tof0z/xtbBEQ-q9laEBtGXSAAAsY Subject: [dpdk-dev] [PATCH] net/virtio-user: fix error run close(0) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Jiawei Zhu When i < VIRTIO_MAX_VIRTQUEUES and j == i, dev->callfds[i] and dev->kickfds[i] are default 0. So it will close(0), close the standard input (stdin). Fixes: e6e7ad8b3024 ("net/virtio-user: move eventfd open/close into init/uninit") Cc: stable@dpdk.org Signed-off-by: Jiawei Zhu --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c index 053f026..1bfd223 100644 --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c @@ -284,7 +284,7 @@ int virtio_user_stop_device(struct virtio_user_dev *dev) } if (i < VIRTIO_MAX_VIRTQUEUES) { - for (j = 0; j <= i; ++j) { + for (j = 0; j < i; ++j) { close(dev->callfds[j]); close(dev->kickfds[j]); } -- 1.8.3.1