From: Thomas Monjalon <thomas@monjalon.net>
To: "zhiyong.yang@intel.com" <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, Matan Azrad <matan@mellanox.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix print unused parameter name
Date: Mon, 14 May 2018 12:51:19 +0200 [thread overview]
Message-ID: <16071614.gU1QWOxn58@xps> (raw)
In-Reply-To: <VI1PR0501MB260873C11D7649049B42C4A4D29C0@VI1PR0501MB2608.eurprd05.prod.outlook.com>
14/05/2018 12:38, Matan Azrad:
>
> Hi
>
> From: zhiyong.yang@intel.com
> > The second parameter "name" in the function rte_eth_dev_detach has been
> > already redefined as "char *name __rte_unused", "port_id" is printed instead
> > of "name" in testpmd.
> >
> > Fixes: b65ecf199324 ("devargs: rename legacy API")
> > Cc: stable@dpdk.org
>
> Really minor : Missing empty line here.
>
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
Title: app/testpmd: fix log after detach
Applied, thanks
prev parent reply other threads:[~2018-05-14 10:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 3:20 zhiyong.yang
2018-05-14 10:38 ` Matan Azrad
2018-05-14 10:51 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16071614.gU1QWOxn58@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).