From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id ABB721C785;
 Mon, 14 May 2018 12:51:21 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 442552209C;
 Mon, 14 May 2018 06:51:21 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Mon, 14 May 2018 06:51:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=QFjflaZkj4wDtKN+O2SoQRxj6v
 NoiwgH8aGoNNll94U=; b=D30qNjIuXRR5wtHSUspnIz1INXCtvBHJgDuhVgGyp/
 yu+oA0TZDIlx+EQAJdq26y5v9L63Nbbn+7g4tGJpGEyzAaHs6wTuEU76Z0W9QK9o
 Ot+/yegAQB50ysMBcCeXi+8WZoHnjEH67S1fyI/pMKw3PUdKAxpSm+9J4Z8r49Jw
 A=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QFjfla
 Zkj4wDtKN+O2SoQRxj6vNoiwgH8aGoNNll94U=; b=a7DJIyGa4GllQ8ENhBuczf
 Afezo9uatFOrEVeoaQlWEjPrpfWpKMMPna0Uj/7O2YgTSnJohpKKzABlxrWfJbui
 5dFS0tXNr5zqBlw1QjVIarSSXUIg/cpL7J8iGwd0qyXmjrdqhr3+/QiCScXUmZXp
 tMwsqV0jswPB0HXy0vNWIXW9EUhFt5qfrwR2R0ca9K8rADpEFkhwXCjJ5SUU05yb
 GWIEi2U1bvX9lJJzPLeazNYZvQaxZhuvR6xtsb+rEgM98XfomY4AHDIhi/qqpFpW
 O8Z4cwkovfW5NFSAvRcXyyysuosFH3oExI2u+BNgD7Sx05bNq6SoAna3hXNxx3zg
 ==
X-ME-Sender: <xms:KWr5Wmf5MFw5ISAKaDmW059nJ-07mGnLsSZSBCSz8rVVJGtmRUESWg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 631E9E4350;
 Mon, 14 May 2018 06:51:20 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "zhiyong.yang@intel.com" <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, Matan Azrad <matan@mellanox.com>,
 "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 "stable@dpdk.org" <stable@dpdk.org>
Date: Mon, 14 May 2018 12:51:19 +0200
Message-ID: <16071614.gU1QWOxn58@xps>
In-Reply-To: <VI1PR0501MB260873C11D7649049B42C4A4D29C0@VI1PR0501MB2608.eurprd05.prod.outlook.com>
References: <20180514032048.34896-1-zhiyong.yang@intel.com>
 <VI1PR0501MB260873C11D7649049B42C4A4D29C0@VI1PR0501MB2608.eurprd05.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix print unused parameter name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 May 2018 10:51:21 -0000

14/05/2018 12:38, Matan Azrad:
> 
> Hi 
> 
> From: zhiyong.yang@intel.com
> > The second parameter "name" in the function rte_eth_dev_detach has been
> > already redefined as "char *name __rte_unused", "port_id" is printed instead
> > of "name" in testpmd.
> > 
> > Fixes: b65ecf199324 ("devargs: rename legacy API")
> > Cc: stable@dpdk.org
> 
> Really minor : Missing empty line here.
> 
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Acked-by: Matan Azrad <matan@mellanox.com>

Title: app/testpmd: fix log after detach

Applied, thanks