* [dpdk-dev] [PATCH] app/testpmd: fix print unused parameter name
@ 2018-05-14 3:20 zhiyong.yang
2018-05-14 10:38 ` Matan Azrad
0 siblings, 1 reply; 3+ messages in thread
From: zhiyong.yang @ 2018-05-14 3:20 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, stable, Zhiyong Yang
The second parameter "name" in the function rte_eth_dev_detach
has been already redefined as "char *name __rte_unused",
"port_id" is printed instead of "name" in testpmd.
Fixes: b65ecf199324 ("devargs: rename legacy API")
Cc: stable@dpdk.org
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
app/test-pmd/testpmd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 664c43554..02a28199b 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1985,7 +1985,7 @@ detach_port(portid_t port_id)
port_flow_flush(port_id);
if (rte_eth_dev_detach(port_id, name)) {
- TESTPMD_LOG(ERR, "Failed to detach port '%s'\n", name);
+ TESTPMD_LOG(ERR, "Failed to detach port %u\n", port_id);
return;
}
@@ -1993,8 +1993,8 @@ detach_port(portid_t port_id)
update_fwd_ports(RTE_MAX_ETHPORTS);
- printf("Port '%s' is detached. Now total ports is %d\n",
- name, nb_ports);
+ printf("Port %u is detached. Now total ports is %d\n",
+ port_id, nb_ports);
printf("Done\n");
return;
}
--
2.14.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix print unused parameter name
2018-05-14 3:20 [dpdk-dev] [PATCH] app/testpmd: fix print unused parameter name zhiyong.yang
@ 2018-05-14 10:38 ` Matan Azrad
2018-05-14 10:51 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Matan Azrad @ 2018-05-14 10:38 UTC (permalink / raw)
To: zhiyong.yang, dev; +Cc: ferruh.yigit, stable
Hi
From: zhiyong.yang@intel.com
> The second parameter "name" in the function rte_eth_dev_detach has been
> already redefined as "char *name __rte_unused", "port_id" is printed instead
> of "name" in testpmd.
>
> Fixes: b65ecf199324 ("devargs: rename legacy API")
> Cc: stable@dpdk.org
Really minor : Missing empty line here.
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> app/test-pmd/testpmd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 664c43554..02a28199b 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1985,7 +1985,7 @@ detach_port(portid_t port_id)
> port_flow_flush(port_id);
>
> if (rte_eth_dev_detach(port_id, name)) {
> - TESTPMD_LOG(ERR, "Failed to detach port '%s'\n", name);
> + TESTPMD_LOG(ERR, "Failed to detach port %u\n", port_id);
> return;
> }
>
> @@ -1993,8 +1993,8 @@ detach_port(portid_t port_id)
>
> update_fwd_ports(RTE_MAX_ETHPORTS);
>
> - printf("Port '%s' is detached. Now total ports is %d\n",
> - name, nb_ports);
> + printf("Port %u is detached. Now total ports is %d\n",
> + port_id, nb_ports);
> printf("Done\n");
> return;
> }
> --
> 2.14.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix print unused parameter name
2018-05-14 10:38 ` Matan Azrad
@ 2018-05-14 10:51 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-05-14 10:51 UTC (permalink / raw)
To: zhiyong.yang; +Cc: dev, Matan Azrad, ferruh.yigit, stable
14/05/2018 12:38, Matan Azrad:
>
> Hi
>
> From: zhiyong.yang@intel.com
> > The second parameter "name" in the function rte_eth_dev_detach has been
> > already redefined as "char *name __rte_unused", "port_id" is printed instead
> > of "name" in testpmd.
> >
> > Fixes: b65ecf199324 ("devargs: rename legacy API")
> > Cc: stable@dpdk.org
>
> Really minor : Missing empty line here.
>
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
Title: app/testpmd: fix log after detach
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-14 10:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 3:20 [dpdk-dev] [PATCH] app/testpmd: fix print unused parameter name zhiyong.yang
2018-05-14 10:38 ` Matan Azrad
2018-05-14 10:51 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).