From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0A1AE25A1 for <dev@dpdk.org>; Thu, 20 Jul 2017 10:32:20 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6708C20967; Thu, 20 Jul 2017 04:32:20 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 20 Jul 2017 04:32:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=SM/rlLid0DHa/9C 3lCHzyYQLvjOy/7J6ZNcp0C6Kiy8=; b=g1Y/92UHeAg8pgobMyW9Y2tTVbXtPLX e1iZ1jII6yovAmbqUq2VGztPXl8qJ0KpY7my/L/BE1VEvps6f79yz0hkuzUq9Ppw inUR9YYpfGnpbcCBlJ9D2u6nffzohxC4XfToQ1rzvG31wFTmN4DmekKhONJ3zymH OrF4xNsulTuY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=SM/rlLid0DHa/9C3lCHzyYQLvjOy/7J6ZNcp0C6Kiy8=; b=js/XsDZA O17wD9bc9sS1N+yqSz5QphsvN/1SxVr9MnnbkXEdVEUz0G7FGoJwT+k+vlDhcHM2 3Nzu6cGqK0HK9N1OFDNCtjEGg7HvPAOCstl7m091UBiH9puwhu2hQ5MNmGbSMHZB OYh157OxxDHyPzJD+pM5AP/YOm1FU1m0s7tHgeH174sMv1n0XlkCOnEljgYm9kar iZsTugBe5wHCaARbxd/loPlDL4IJ8jmbzQZ821cZ0rMuRgV3HV4dWYuHhm9vRW4z tZfIgVkUuYJXoZ3AKsz354WGNTIt+BT3f+/B1xuhaX4KHhUcxdAlz5P6Bm/FiGSn 9eRSX9UYzgMxIw== X-ME-Sender: <xms:lGpwWRMWwSEnfIVBGxkQYjn7vedaEG8iSHIuWo1eY41kbZgf4ifQQA> X-Sasl-enc: R3mlI0HuE/znPPMPmpgdPnDqLzkMFgB/XB5QQYB5PlrQ 1500539540 Received: from xps.localnet (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id F3F8E7E43A; Thu, 20 Jul 2017 04:32:19 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Jens Freimann <jfreimann@redhat.com>, Tiwei Bie <tiwei.bie@intel.com> Cc: "Van Haaren, Harry" <harry.van.haaren@intel.com>, dev@dpdk.org Date: Thu, 20 Jul 2017 11:32:18 +0300 Message-ID: <1607182.kpCMdDpRBB@xps> In-Reply-To: <20170720075601.cbuizcbke5svgsos@dhcp-192-218.str.redhat.com> References: <1500455196-182365-1-git-send-email-tiwei.bie@intel.com> <20170719102321.GA6991@debian-ZGViaWFuCg> <20170720075601.cbuizcbke5svgsos@dhcp-192-218.str.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] all: refactor coding style X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 20 Jul 2017 08:32:21 -0000 20/07/2017 10:56, Jens Freimann: > On Wed, Jul 19, 2017 at 06:23:21PM +0800, Tiwei Bie wrote: > >On Wed, Jul 19, 2017 at 05:24:38PM +0800, Van Haaren, Harry wrote: > [...] > >> Hi Tiwei, > >> > >> Although the idea and motivation for code-cleanup are good, performing > >> large cleanup across a code-base is not a good solution. The reason that > >> these types of cleanups (or even re-formatting the entire codebase) are not > >> performed often is that it "invalidates" any currently-in-progress patch-sets. > >> As a result, more work is required from many contributors to rebase useful > >> features due to across-the-board white-space cleanups. > >> > >> Just expressing concern that we need to think carefully about the impacts > >> of such a patch. > >> > > > >Yeah, I agree. Such patch may cause many conflicts. But this patch > >is almost generated automatically, that is to say, it's a quick work. > >And it's more like some fixes (for the bad coding style) rather than > >silly re-formatting done by `indent'. So I just want to share it with > >the community, and see the potential feedbacks. Thank you for your > >comments! :) > > what I'm more concerned about with these kind of huge clean-ups is > that it makes git-blame less useful for me. Next time I want to look > up who changed this line I'll just find your cleanup patch. Then I have > to do another step to find out which commit introduced the change I'm > looking for. > > I'm more for cleaning up these things next time you do a semantic > change in this code. +1 for doing clean-up when refactoring code