From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 3D0EC7E0B for ; Thu, 30 Oct 2014 23:38:32 +0100 (CET) Received: by mail-wi0-f171.google.com with SMTP id q5so5853595wiv.10 for ; Thu, 30 Oct 2014 15:47:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=8JVqI6T64BCNrYBFHX2SwWP625PORgnM3N08Bc0MXr4=; b=RUtOA6kzh7eoLIe2SEyAzyS8x1Xsp2HamBxy/JAK8jceyh6sCMH3eH8Sy7Wo3Qjq1a BnDbtIgXDMlrBSMbgwKNbWfXpZUFcsJtWgdsn6MAX0sUpzeG+MB4jPK62yA6BAjA1Uvw wLssUgNlWn4adERNRSwLS013DV4xZ1CzKqxeGDEmJ+Eo+KS9sb+vH/8jHGC1pafLazbN PNq2mvqoHf3cjttgAL/ggo/eTO4r34OPTcCeKb9b1HQb9YPSwI0maYoHFErktaajw5nw +p64DYVCGSi97/rfZ5VJOxc1pMJpV6WsIhrrXLPCZSHI6Wt42wsMjeDbjjnNwWo7DCR2 rbcg== X-Gm-Message-State: ALoCoQlCJoIzX+3X2fjEvuMfU7jK8L7g7WuHzHstA10EvBV+a6Ficzf7Lg7gPsYVOUnQRw6zF3lV X-Received: by 10.194.184.12 with SMTP id eq12mr24455180wjc.100.1414709250196; Thu, 30 Oct 2014 15:47:30 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id bq6sm8835865wib.1.2014.10.30.15.47.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Oct 2014 15:47:29 -0700 (PDT) From: Thomas Monjalon To: Jingjing Wu Date: Thu, 30 Oct 2014 23:47:10 +0100 Message-ID: <1607705.DDyl0z8Nv8@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1413965977-15165-2-git-send-email-jingjing.wu@intel.com> References: <1411628369-29532-1-git-send-email-jingjing.wu@intel.com> <1413965977-15165-1-git-send-email-jingjing.wu@intel.com> <1413965977-15165-2-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type and its structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Oct 2014 22:38:32 -0000 2014-10-22 16:19, Jingjing Wu: > +/** > + * Define all structures for Control Packet Filter type corresponding with specific operations. > + */ Please explain what is a control packet. > + > +#define RTE_CONTROL_PACKET_FLAGS_IGNORE_MAC 0x0001 > +#define RTE_CONTROL_PACKET_FLAGS_DROP 0x0002 > +#define RTE_CONTROL_PACKET_FLAGS_TO_QUEUE 0x0004 > +#define RTE_CONTROL_PACKET_FLAGS_TX 0x0008 > +#define RTE_CONTROL_PACKET_FLAGS_RX 0x0000 Flag RX is 0? > +/** > + * A structure used to define the control packet filter entry > + * to support RTE_ETH_FILTER_CTRL_PKT with RTE_ETH_FILTER_ADD > + * and RTE_ETH_FILTER_DELETE operations. > + */ > +struct rte_ctrl_pkt_filter { > + struct ether_addr mac_addr; /**< mac address to match. */ > + uint16_t ether_type; /**< ether type to match */ > + uint16_t flags; /**< options for filter's behavior*/ > + uint16_t dest_id; /**< destination vsi id or pool id*/ vsi id and pool id cannot be understood in a generic context. Please explain what you mean and why queue is not enough. > + uint16_t queue; /**< queue assign to if TO QUEUE flag is set */ TO QUEUE is not defined. Is it really needed? Thanks -- Thomas