From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DF2171B333; Tue, 30 Jan 2018 10:22:03 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7D86A20B26; Tue, 30 Jan 2018 04:22:03 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 30 Jan 2018 04:22:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=xPR8yn0TlRcU07BfFl3i4IC7hY qmCAe7MzRmb6At1mc=; b=RzYbb7ZxOTARLA8pTJrYcJZdPim7lIPNxSBH4sIuR+ IyW6+M+on/ZHeD82Ox7O6UiyG2URBo/1p3ae4IPePip0Fip9CbT9GS5+EERGB0Bv KUT3PJwNBjP/jW+yEAJV55A/cjuifASLk21YPu/Q3A9UZeEWYPzBTPSaYpEYJI6s I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=xPR8yn 0TlRcU07BfFl3i4IC7hYqmCAe7MzRmb6At1mc=; b=DCRauzYjvoT9DusllC6HbZ MnlwALbsalvh4yJa3PqrTdGRAnIkXEho1nQH3oI0KW2lNmNaPOzm6NSOAp6E7+IQ Ec7X+H39UllO51kaegTQojOV1zeFE5d6SM8z4nOpzrZuPXcXKnVu7pBvBxhPc7eG yasY0Z93eQpiraeUfXcVugT7wpU6uXLhzRY438RuLfUm5Q+LuO0MJxjaJHaMTwno XcK6G5vUPiXyTiBWyHLQhvTyefDuNUaotCgyItIPca0496q2H6q9LooC6qoKpWTA 1lOvTc9xkpdcervLdPTbmXkU0w0bxrFcMplsAjTRC8DjH+TOy94AVXRDPndINRiQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 309D724608; Tue, 30 Jan 2018 04:22:03 -0500 (EST) From: Thomas Monjalon To: Mordechay Haimovsky Cc: stable@dpdk.org, Shahaf Shuler , Adrien Mazarguil , "dev@dpdk.org" Date: Tue, 30 Jan 2018 10:21:17 +0100 Message-ID: <1608356.uQtoRR8JKj@xps> In-Reply-To: References: <1516357009-15463-1-git-send-email-motih@mellanox.com> <1517214877-126768-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 09:22:04 -0000 29/01/2018 11:54, Shahaf Shuler: > Mordechay Haimovsky, Monday, January 29, 2018 10:35 AM: > > In failsafe device start can be called for ports/devices that had been plugged > > out. > > The mlx4 PMD detects device removal by listening to the device RMV events, > > when the mlx4 port is being stopped, the PMD no longer listens to these > > events causing the PMD to stop detecting device removals. > > This patch fixes this issue by moving installation of the interrupt handler to > > device configuration, and toggle only the Rx-queue interrupts on start/stop. > > > > Fixes: a6e8b01c3c26 ("net/mlx4: compact interrupt functions") > > Cc: stable@dpdk.org > > > > Signed-off-by: Moti Haimovsky > > Acked-by: Shahaf Shuler > > Adrien - let me know if you see issues with this patch, I want to include it on RC2. Applied, thanks