From: Xueming Li <xuemingl@nvidia.com>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: dev@dpdk.org, xuemingl@nvidia.com, Asaf Penso <asafp@nvidia.com>
Subject: [dpdk-dev] [PATCH v2 3/4] net/mlx5: revert setting representor to first PF
Date: Wed, 6 Jan 2021 16:39:58 +0000 [thread overview]
Message-ID: <1609951199-24794-4-git-send-email-xuemingl@nvidia.com> (raw)
In-Reply-To: <1609951199-24794-1-git-send-email-xuemingl@nvidia.com>
In-Reply-To: <1608303356-13089-2-git-send-email-xuemingl@nvidia.com>
Representors on second PF are being probed by devargs:
<primary_bdf>,representor=pf1vf<N>
No need to save primary PF port ID and lookup when probing sibling
ports, revert patch [1]
[1]:
commit e6818853c022 ("net/mlx5: set representor to first PF in bonding
mode")
Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
drivers/net/mlx5/linux/mlx5_os.c | 20 ++------------------
drivers/net/mlx5/mlx5.c | 1 -
drivers/net/mlx5/mlx5.h | 1 -
3 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index 6f667dd747..1209bfed5b 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -817,13 +817,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
rte_errno = ENOMEM;
return NULL;
}
- priv = eth_dev->data->dev_private;
- if (priv->sh->bond_dev != UINT16_MAX)
- /* For bonding port, use primary PCI device. */
- eth_dev->device =
- rte_eth_devices[priv->sh->bond_dev].device;
- else
- eth_dev->device = dpdk_dev;
+ eth_dev->device = dpdk_dev;
eth_dev->dev_ops = &mlx5_dev_sec_ops;
eth_dev->rx_descriptor_status = mlx5_rx_descriptor_status;
eth_dev->tx_descriptor_status = mlx5_tx_descriptor_status;
@@ -1451,17 +1445,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
eth_dev->data->dev_private = priv;
priv->dev_data = eth_dev->data;
eth_dev->data->mac_addrs = priv->mac;
- if (spawn->pf_bond < 0) {
- eth_dev->device = dpdk_dev;
- } else {
- /* Use primary bond PCI as device. */
- if (sh->bond_dev == UINT16_MAX) {
- sh->bond_dev = eth_dev->data->port_id;
- eth_dev->device = dpdk_dev;
- } else {
- eth_dev->device = rte_eth_devices[sh->bond_dev].device;
- }
- }
+ eth_dev->device = dpdk_dev;
eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
/* Configure the first MAC address by default. */
if (mlx5_get_mac(eth_dev, &mac.addr_bytes)) {
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 023ef50a77..628587faac 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -917,7 +917,6 @@ mlx5_alloc_shared_dev_ctx(const struct mlx5_dev_spawn_data *spawn,
goto error;
}
sh->refcnt = 1;
- sh->bond_dev = UINT16_MAX;
sh->max_port = spawn->max_port;
strncpy(sh->ibdev_name, mlx5_os_get_ctx_device_name(sh->ctx),
sizeof(sh->ibdev_name) - 1);
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 41034f5d19..a77a1600d5 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -692,7 +692,6 @@ struct mlx5_flex_parser_profiles {
struct mlx5_dev_ctx_shared {
LIST_ENTRY(mlx5_dev_ctx_shared) next;
uint32_t refcnt;
- uint16_t bond_dev; /* Bond primary device id. */
uint32_t devx:1; /* Opened with DV. */
uint32_t flow_hit_aso_en:1; /* Flow Hit ASO is supported. */
uint32_t eqn; /* Event Queue number. */
--
2.25.1
next prev parent reply other threads:[~2021-01-06 16:40 UTC|newest]
Thread overview: 209+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 14:55 [dpdk-dev] [RFC 0/7] support SubFunction representor Xueming Li
2020-12-18 14:55 ` [dpdk-dev] [RFC 1/7] ethdev: support sub function representor Xueming Li
2020-12-28 11:59 ` Andrew Rybchenko
2021-01-06 16:17 ` [dpdk-dev] [PATCH v2 0/9] support SubFunction representor Xueming Li
2021-01-06 16:17 ` [dpdk-dev] [PATCH v2 1/9] ethdev: refactor representor infrastructure Xueming Li
2021-01-07 6:31 ` Somnath Kotur
2021-01-07 6:38 ` Xueming(Steven) Li
2021-01-07 6:40 ` Somnath Kotur
2021-01-06 16:17 ` [dpdk-dev] [PATCH v2 2/9] ethdev: support new VF representor syntax Xueming Li
2021-01-06 16:17 ` [dpdk-dev] [PATCH v2 3/9] ethdev: support sub function representor Xueming Li
2021-01-06 16:17 ` [dpdk-dev] [PATCH v2 4/9] ethdev: support PF index in representor Xueming Li
2021-01-06 16:17 ` [dpdk-dev] [PATCH v2 5/9] ethdev: support multi-host representor Xueming Li
2021-01-06 16:17 ` [dpdk-dev] [PATCH v2 6/9] devarg: change reprsentor ID to bitmap Xueming Li
2021-01-06 16:17 ` [dpdk-dev] [PATCH v2 7/9] ethdev: capability of new representor syntax Xueming Li
2021-01-06 16:17 ` [dpdk-dev] [PATCH v2 8/9] kvargs: update parser for " Xueming Li
2021-01-06 16:17 ` [dpdk-dev] [PATCH v2 9/9] eal: allow PCI device with different representors Xueming Li
2021-01-06 16:39 ` [dpdk-dev] [PATCH v2 0/4] net/mlx5: support SubFunction representor Xueming Li
2021-01-06 16:39 ` [dpdk-dev] [PATCH v2 1/4] common/mlx5: update representor name parsing Xueming Li
2021-01-06 16:39 ` [dpdk-dev] [PATCH v2 2/4] net/mlx5: support representor of sub function Xueming Li
2021-01-06 16:39 ` Xueming Li [this message]
2021-01-06 16:39 ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: improve bonding representor probe Xueming Li
2021-01-13 13:44 ` [dpdk-dev] [PATCH v3 0/9] ethdev: support SubFunction representor Xueming Li
2021-01-13 13:44 ` [dpdk-dev] [PATCH v3 1/9] ethdev: refactor representor infrastructure Xueming Li
2021-01-13 13:44 ` [dpdk-dev] [PATCH v3 2/9] ethdev: support new VF representor syntax Xueming Li
2021-01-13 13:44 ` [dpdk-dev] [PATCH v3 3/9] ethdev: support sub function representor Xueming Li
2021-01-13 13:44 ` [dpdk-dev] [PATCH v3 4/9] ethdev: support PF index in representor Xueming Li
2021-01-13 13:44 ` [dpdk-dev] [PATCH v3 5/9] ethdev: support multi-host representor Xueming Li
2021-01-13 13:44 ` [dpdk-dev] [PATCH v3 6/9] devarg: change reprsentor ID to bitmap Xueming Li
2021-01-13 13:44 ` [dpdk-dev] [PATCH v3 7/9] ethdev: capability of new representor syntax Xueming Li
2021-01-13 13:44 ` [dpdk-dev] [PATCH v3 8/9] kvargs: update parser for " Xueming Li
2021-01-13 13:44 ` [dpdk-dev] [PATCH v3 9/9] eal: probe devices of same PCI but different devargs Xueming Li
2021-01-18 11:16 ` [dpdk-dev] [PATCH v4 0/9] ethdev: support SubFunction representor Xueming Li
2021-01-18 16:24 ` Thomas Monjalon
2021-01-18 11:16 ` [dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type Xueming Li
2021-01-18 15:44 ` Thomas Monjalon
2021-01-18 17:42 ` Ajit Khaparde
2021-01-18 17:57 ` Thomas Monjalon
2021-01-18 18:00 ` Ajit Khaparde
2021-01-18 18:15 ` Thomas Monjalon
2021-01-18 18:17 ` Ajit Khaparde
2021-01-18 23:41 ` Xueming(Steven) Li
2021-01-19 7:39 ` Ajit Khaparde
2021-01-19 7:24 ` Andrew Rybchenko
2021-01-19 7:37 ` Xueming(Steven) Li
2021-01-19 7:49 ` Andrew Rybchenko
2021-01-19 7:56 ` Xueming(Steven) Li
2021-01-19 8:39 ` Thomas Monjalon
2021-01-18 11:16 ` [dpdk-dev] [PATCH v4 2/9] ethdev: support representor port list Xueming Li
2021-01-18 16:18 ` Thomas Monjalon
2021-01-18 23:23 ` Xueming(Steven) Li
2021-01-19 7:45 ` Andrew Rybchenko
2021-01-19 8:59 ` Xueming(Steven) Li
2021-01-19 9:03 ` Andrew Rybchenko
2021-01-19 10:19 ` Xueming(Steven) Li
2021-01-18 11:16 ` [dpdk-dev] [PATCH v4 3/9] ethdev: support new VF representor syntax Xueming Li
2021-01-18 11:16 ` [dpdk-dev] [PATCH v4 4/9] ethdev: support sub function representor Xueming Li
2021-01-18 11:16 ` [dpdk-dev] [PATCH v4 5/9] ethdev: support PF index in representor Xueming Li
2021-01-18 11:17 ` [dpdk-dev] [PATCH v4 6/9] ethdev: support multi-host " Xueming Li
2021-01-18 11:17 ` [dpdk-dev] [PATCH v4 7/9] devarg: change representor ID to bitmap Xueming Li
2021-01-18 19:01 ` Ajit Khaparde
2021-01-20 5:51 ` Xueming(Steven) Li
2021-01-18 11:17 ` [dpdk-dev] [PATCH v4 8/9] ethdev: add capability of sub-function representor Xueming Li
2021-01-18 11:17 ` [dpdk-dev] [PATCH v4 9/9] kvargs: update parser to support lists Xueming Li
2021-01-19 7:13 ` [dpdk-dev] [PATCH v5 0/9] ethdev: support SubFunction representor Xueming Li
2021-01-19 8:40 ` Andrew Rybchenko
2021-01-19 14:24 ` Xueming(Steven) Li
2021-01-22 8:21 ` Andrew Rybchenko
2021-01-27 3:04 ` Xueming(Steven) Li
2021-01-27 12:10 ` Andrew Rybchenko
2021-01-28 14:31 ` Xueming(Steven) Li
2021-02-01 8:39 ` Andrew Rybchenko
2021-02-04 14:15 ` Xueming(Steven) Li
2021-02-05 7:34 ` Andrew Rybchenko
2021-02-05 9:13 ` Xueming(Steven) Li
2021-02-05 9:37 ` Andrew Rybchenko
2021-01-27 17:43 ` Ajit Khaparde
2021-01-28 11:45 ` Xueming(Steven) Li
2021-01-21 3:32 ` Tu, Lijuan
2021-01-19 7:14 ` [dpdk-dev] [PATCH v5 1/9] ethdev: introduce representor type Xueming Li
2021-01-19 7:14 ` [dpdk-dev] [PATCH v5 2/9] ethdev: support representor port list Xueming Li
2021-01-19 7:48 ` Andrew Rybchenko
2021-01-19 8:19 ` Xueming(Steven) Li
2021-01-19 7:14 ` [dpdk-dev] [PATCH v5 3/9] ethdev: support new VF representor syntax Xueming Li
2021-01-19 7:51 ` Andrew Rybchenko
2021-01-19 7:14 ` [dpdk-dev] [PATCH v5 4/9] ethdev: support sub function representor Xueming Li
2021-01-19 7:53 ` Andrew Rybchenko
2021-01-19 7:14 ` [dpdk-dev] [PATCH v5 5/9] ethdev: support PF index in representor Xueming Li
2021-01-19 8:00 ` Andrew Rybchenko
2021-01-19 9:30 ` Xueming(Steven) Li
2021-01-19 9:36 ` Andrew Rybchenko
2021-01-19 11:57 ` Xueming(Steven) Li
2021-01-19 7:14 ` [dpdk-dev] [PATCH v5 6/9] ethdev: support multi-host " Xueming Li
2021-01-19 8:03 ` Andrew Rybchenko
2021-01-19 9:32 ` Xueming(Steven) Li
2021-01-19 7:14 ` [dpdk-dev] [PATCH v5 7/9] devarg: change representor ID to bitmap Xueming Li
2021-01-19 7:36 ` Wang, Haiyue
2021-01-19 8:11 ` Xueming(Steven) Li
2021-01-19 8:20 ` Andrew Rybchenko
2021-01-19 8:33 ` Thomas Monjalon
2021-01-19 11:04 ` Xueming(Steven) Li
2021-01-19 11:15 ` Andrew Rybchenko
2021-01-19 7:15 ` [dpdk-dev] [PATCH v5 8/9] ethdev: add capability of sub-function representor Xueming Li
2021-01-19 8:06 ` Andrew Rybchenko
2021-01-19 11:19 ` Xueming(Steven) Li
2021-01-19 11:29 ` Andrew Rybchenko
2021-01-19 7:15 ` [dpdk-dev] [PATCH v5 9/9] kvargs: update parser to support lists Xueming Li
2021-02-14 3:21 ` [dpdk-dev] [PATCH v6 0/9] ethdev: support SubFunction representor Xueming Li
2021-02-23 1:54 ` Stephen Hemminger
2021-02-23 11:45 ` Wang, Haiyue
2021-02-28 13:51 ` Xueming(Steven) Li
2021-03-31 5:49 ` Xueming(Steven) Li
2021-03-31 5:58 ` Wang, Haiyue
2021-02-14 3:21 ` [dpdk-dev] [PATCH v6 1/9] ethdev: introduce representor type Xueming Li
2021-02-15 2:25 ` Hyong Youb Kim (hyonkim)
2021-02-14 3:21 ` [dpdk-dev] [PATCH v6 2/9] ethdev: support representor port list Xueming Li
2021-02-15 8:13 ` Andrew Rybchenko
2021-02-14 3:21 ` [dpdk-dev] [PATCH v6 3/9] ethdev: support new VF representor syntax Xueming Li
2021-02-14 3:21 ` [dpdk-dev] [PATCH v6 4/9] ethdev: support sub function representor Xueming Li
2021-02-15 8:25 ` Andrew Rybchenko
2021-02-16 9:00 ` Xueming(Steven) Li
2021-02-14 3:21 ` [dpdk-dev] [PATCH v6 5/9] ethdev: support PF index in representor Xueming Li
2021-02-15 8:28 ` Andrew Rybchenko
2021-02-15 8:35 ` Andrew Rybchenko
2021-02-16 14:54 ` Xueming(Steven) Li
2021-02-14 3:21 ` [dpdk-dev] [PATCH v6 6/9] ethdev: support multi-host " Xueming Li
2021-02-15 8:37 ` Andrew Rybchenko
2021-02-14 3:21 ` [dpdk-dev] [PATCH v6 7/9] ethdev: new API to get representor info Xueming Li
2021-02-15 8:50 ` Andrew Rybchenko
2021-02-16 15:11 ` Xueming(Steven) Li
2021-02-14 3:21 ` [dpdk-dev] [PATCH v6 8/9] ethdev: representor iterator compare complete info Xueming Li
2021-02-15 9:31 ` Andrew Rybchenko
2021-02-16 16:35 ` Xueming(Steven) Li
2021-02-25 7:32 ` Andrew Rybchenko
2021-02-14 3:21 ` [dpdk-dev] [PATCH v6 9/9] kvargs: update parser to support lists Xueming Li
2021-03-02 11:40 ` [dpdk-dev] [PATCH v7 0/9] ethdev: support SubFunction representor Xueming Li
2021-03-02 11:40 ` [dpdk-dev] [PATCH v7 1/9] ethdev: introduce representor type Xueming Li
2021-03-02 11:42 ` [dpdk-dev] [PATCH v7 3/9] ethdev: support new VF representor syntax Xueming Li
2021-03-02 11:42 ` [dpdk-dev] [PATCH v7 4/9] ethdev: support sub function representor Xueming Li
2021-03-02 11:42 ` [dpdk-dev] [PATCH v7 5/9] ethdev: support PF index in representor Xueming Li
2021-03-02 11:51 ` Andrew Rybchenko
2021-03-02 11:43 ` [dpdk-dev] [PATCH v7 6/9] ethdev: support multi-host " Xueming Li
2021-03-02 11:43 ` [dpdk-dev] [PATCH v7 7/9] ethdev: new API to get representor info Xueming Li
2021-03-02 11:56 ` Andrew Rybchenko
2021-03-02 11:43 ` [dpdk-dev] [PATCH v7 8/9] ethdev: representor iterator compare complete info Xueming Li
2021-03-02 14:10 ` Andrew Rybchenko
2021-03-02 15:18 ` Xueming(Steven) Li
2021-03-02 11:44 ` [dpdk-dev] [PATCH v7 9/9] kvargs: update parser to support lists Xueming Li
2021-03-04 14:30 ` [dpdk-dev] [PATCH v8 0/9] ethdev: support SubFunction representor Xueming Li
2021-03-08 16:43 ` Ferruh Yigit
2021-03-09 7:13 ` Xueming(Steven) Li
2021-03-04 14:30 ` [dpdk-dev] [PATCH v8 1/9] ethdev: introduce representor type Xueming Li
2021-03-08 14:35 ` Ferruh Yigit
2021-03-04 14:30 ` [dpdk-dev] [PATCH v8 2/9] ethdev: support representor port list Xueming Li
2021-03-08 14:38 ` Ferruh Yigit
2021-03-08 15:58 ` Xueming(Steven) Li
2021-03-08 16:22 ` Ferruh Yigit
2021-03-09 6:16 ` Xueming(Steven) Li
2021-03-04 14:30 ` [dpdk-dev] [PATCH v8 3/9] ethdev: support new VF representor syntax Xueming Li
2021-03-04 14:30 ` [dpdk-dev] [PATCH v8 4/9] ethdev: support sub function representor Xueming Li
2021-03-04 14:30 ` [dpdk-dev] [PATCH v8 5/9] ethdev: support PF index in representor Xueming Li
2021-03-04 14:30 ` [dpdk-dev] [PATCH v8 6/9] ethdev: support multi-host " Xueming Li
2021-03-04 14:30 ` [dpdk-dev] [PATCH v8 7/9] ethdev: new API to get representor info Xueming Li
2021-03-08 14:43 ` Ferruh Yigit
2021-03-08 15:31 ` Xueming(Steven) Li
2021-03-08 16:12 ` Ferruh Yigit
2021-03-09 4:13 ` Xueming(Steven) Li
2021-03-04 14:30 ` [dpdk-dev] [PATCH v8 8/9] ethdev: representor iterator compare complete info Xueming Li
2021-03-08 16:18 ` Ferruh Yigit
2021-03-09 6:00 ` Xueming(Steven) Li
2021-03-09 8:19 ` Andrew Rybchenko
2021-03-11 13:18 ` Xueming(Steven) Li
2021-03-04 14:30 ` [dpdk-dev] [PATCH v8 9/9] kvargs: update parser to support lists Xueming Li
2021-03-08 14:45 ` Ferruh Yigit
2021-03-08 14:59 ` Xueming(Steven) Li
2021-03-08 15:54 ` Ferruh Yigit
2021-03-08 16:01 ` Xueming(Steven) Li
2021-03-11 13:13 ` [dpdk-dev] [PATCH v9 00/10] ethdev: support SubFunction representor Xueming Li
2021-03-16 19:18 ` Ferruh Yigit
2021-03-17 9:00 ` Xueming(Steven) Li
2021-03-11 13:13 ` [dpdk-dev] [PATCH v9 01/10] ethdev: introduce representor type Xueming Li
2021-03-11 13:13 ` [dpdk-dev] [PATCH v9 02/10] ethdev: refactor representor port list parsing Xueming Li
2021-03-11 13:13 ` [dpdk-dev] [PATCH v9 03/10] ethdev: support new VF representor syntax Xueming Li
2021-03-11 13:13 ` [dpdk-dev] [PATCH v9 04/10] ethdev: support sub function representor Xueming Li
2021-03-11 13:13 ` [dpdk-dev] [PATCH v9 05/10] kvargs: update parser to support multiple lists Xueming Li
2021-04-12 16:42 ` Kinsella, Ray
2021-03-11 13:13 ` [dpdk-dev] [PATCH v9 06/10] ethdev: support PF index in representor Xueming Li
2021-03-11 13:13 ` [dpdk-dev] [PATCH v9 07/10] ethdev: support multi-host " Xueming Li
2021-03-11 13:13 ` [dpdk-dev] [PATCH v9 08/10] ethdev: new API to get representor info Xueming Li
2021-03-16 19:18 ` Ferruh Yigit
2021-03-16 21:19 ` Thomas Monjalon
2021-03-16 23:34 ` Ferruh Yigit
2021-03-17 6:57 ` Thomas Monjalon
2021-03-17 17:11 ` Ferruh Yigit
2021-03-11 13:13 ` [dpdk-dev] [PATCH v9 09/10] ethdev: representor iterator compare complete info Xueming Li
2021-03-11 13:13 ` [dpdk-dev] [PATCH v9 10/10] doc/release: add representor enhancements Xueming Li
2020-12-18 14:55 ` [dpdk-dev] [RFC 2/7] ethdev: support multi-host representor Xueming Li
2020-12-28 13:43 ` Andrew Rybchenko
2020-12-18 14:55 ` [dpdk-dev] [RFC 3/7] devarg: change reprsentor ID to bitmap Xueming Li
2020-12-28 13:36 ` Andrew Rybchenko
2021-01-05 6:19 ` Xueming(Steven) Li
2020-12-18 14:55 ` [dpdk-dev] [RFC 4/7] ethdev: capability for new representor syntax Xueming Li
2020-12-28 12:02 ` Andrew Rybchenko
2020-12-18 14:55 ` [dpdk-dev] [RFC 5/7] kvargs: update parser " Xueming Li
2020-12-28 13:21 ` Andrew Rybchenko
2020-12-18 14:55 ` [dpdk-dev] [RFC 6/7] common/mlx5: update representor name parsing Xueming Li
2020-12-18 14:55 ` [dpdk-dev] [RFC 7/7] net/mlx5: support representor of sub function Xueming Li
2020-12-28 13:44 ` [dpdk-dev] [RFC 0/7] support SubFunction representor Andrew Rybchenko
2020-12-30 8:54 ` Xueming(Steven) Li
2020-12-30 11:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1609951199-24794-4-git-send-email-xuemingl@nvidia.com \
--to=xuemingl@nvidia.com \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).