From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix link with gcc
Date: Tue, 10 Jun 2014 13:39:10 +0200 [thread overview]
Message-ID: <1610676.2NcRHxOWZ3@xps13> (raw)
In-Reply-To: <538C2A59.2060501@6wind.com>
2014-06-02 09:40, Olivier MATZ:
> Hi Thomas,
>
> On 05/29/2014 08:48 AM, Thomas Monjalon wrote:
> > You're right, title should be:
> > mk: fix 32-bit link with gcc
> >
> > And I should add some details in the commit log:
> >
> > I didn't see any error with -z muldefs but it isn't documented in gcc manual.
> > So it's safer to explicitly pass it to the linker.
> >
> > The variable CPU_LDFLAGS contains "-melf_i386" in 32-bit configurations. So
> > building 32-bit shared library raises this error:
> > gcc: error: unrecognized command line option ‘-melf_i386’
> >
> > Olivier, I'll make these changes if you (or Neil) ack the patch.
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied for version 1.7.0.
--
Thomas
next prev parent reply other threads:[~2014-06-10 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 12:55 Thomas Monjalon
2014-05-28 11:47 ` Olivier MATZ
2014-05-29 6:48 ` Thomas Monjalon
2014-06-02 7:40 ` Olivier MATZ
2014-06-10 11:39 ` Thomas Monjalon [this message]
2014-05-28 14:17 ` Neil Horman
2014-05-29 6:24 ` Thomas Monjalon
2014-05-29 11:07 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1610676.2NcRHxOWZ3@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).