From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7B29CA0A02;
Fri, 15 Jan 2021 14:26:58 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id CB27614107F;
Fri, 15 Jan 2021 14:26:24 +0100 (CET)
Received: from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])
by mails.dpdk.org (Postfix) with ESMTP id E56AA14106A
for <dev@dpdk.org>; Fri, 15 Jan 2021 14:26:20 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
by lb.pantheon.sk (Postfix) with ESMTP id 0BFFABFD93;
Fri, 15 Jan 2021 14:26:18 +0100 (CET)
X-Virus-Scanned: amavisd-new at siecit.sk
Received: from lb.pantheon.sk ([127.0.0.1])
by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id cn8mXlgd5A4T; Fri, 15 Jan 2021 14:26:18 +0100 (CET)
Received: from service-node1.lab.pantheon.local (unknown [46.229.239.141])
by lb.pantheon.sk (Postfix) with ESMTP id E6005BFD90;
Fri, 15 Jan 2021 14:26:14 +0100 (CET)
From: =?UTF-8?q?Juraj=20Linke=C5=A1?= <juraj.linkes@pantheon.tech>
To: bruce.richardson@intel.com, Ruifeng.Wang@arm.com,
Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com,
Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com,
ajit.khaparde@broadcom.com, ferruh.yigit@intel.com, aboyer@pensando.io
Cc: dev@dpdk.org, =?UTF-8?q?Juraj=20Linke=C5=A1?= <juraj.linkes@pantheon.tech>
Date: Fri, 15 Jan 2021 14:26:02 +0100
Message-Id: <1610717170-31279-5-git-send-email-juraj.linkes@pantheon.tech>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1610717170-31279-1-git-send-email-juraj.linkes@pantheon.tech>
References: <1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech>
<1610717170-31279-1-git-send-email-juraj.linkes@pantheon.tech>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v15 04/12] build: simplify how Arm flags are
processed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Set flags in one loop. Append flags to a list and use the list in the
loop.
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
config/arm/meson.build | 37 +++++++++++++++++--------------------
1 file changed, 17 insertions(+), 20 deletions(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 28d81b070..7a74938bd 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -158,7 +158,6 @@ if dpdk_conf.get('RTE_ARCH_32')
else
# aarch64 build
implementer_id = 'generic'
- machine_args = [] # Clear previous machine args
if machine == 'default' and not meson.is_cross_build()
# default build
implementer_config = implementer_generic
@@ -191,34 +190,32 @@ else
implementer_config = get_variable('implementer_' + implementer_id)
endif
- # Apply Common Defaults. These settings may be overwritten by machine
- # settings later.
- foreach flag: flags_common
- if flag.length() > 0
- dpdk_conf.set(flag[0], flag[1])
- endif
- endforeach
+ message('Arm implementer: ' + implementer_config[0])
+ message('Arm part number: ' + part_number)
- message('Implementer : ' + implementer_config[0])
- foreach flag: implementer_config[1]
- if flag.length() > 0
- dpdk_conf.set(flag[0], flag[1])
- endif
- endforeach
+ # use default flags with implementer flags
+ dpdk_flags = flags_common + implementer_config[1]
+ machine_args = [] # Clear previous machine args
foreach marg: implementer_config[2]
if marg[0] == part_number
+ # apply supported machine args
foreach flag: marg[1]
if cc.has_argument(flag)
machine_args += flag
endif
endforeach
- # Apply any extra machine specific flags.
- foreach flag: marg.get(2, [])
- if flag.length() > 0
- dpdk_conf.set(flag[0], flag[1])
- endif
- endforeach
+ if marg.length() > 2
+ # add extra flags for the part
+ dpdk_flags += marg[2]
+ endif
+ endif
+ endforeach
+
+ # apply flags
+ foreach flag: dpdk_flags
+ if flag.length() > 0
+ dpdk_conf.set(flag[0], flag[1])
endif
endforeach
endif
--
2.20.1