From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id BA2061B4C0 for ; Wed, 11 Jul 2018 19:46:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B9CA728A; Wed, 11 Jul 2018 13:46:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 11 Jul 2018 13:46:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=2/A+/i+TDnwHBJP2iTrQhJKBHR PVuh1t7qhuvbNCZ4I=; b=DCbpDG3Int0p9KlB9zjFqqU4kh4JZJHQwpDy/jBkY/ GCKgduZa1Whv/O3FZYYkmebh8iayyBy0/1CXRDYWnEzojkPcuic505T9MVTvYfxb bEovtOsSC1GySNXaphab0+S0AqDi7StlsfRt3l21lbmEpGEAfTUEUGyhLSY+QCBZ E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=2/A+/i +TDnwHBJP2iTrQhJKBHRPVuh1t7qhuvbNCZ4I=; b=tWXAmBXC+jZxi681uj/Ts+ XbsckV8Z2SAaw5JBH7dn9bb0Jnp9LtSOyV189DS14VRYes2wcvfM5UcF77A9N6iN MkE6pPak04iu3M17rTOIEAUDADUse2LC+zXtNLQtqRZo5pnRpIB4KK4eJZUTTK/H 1SqXlUJODBm4cIrKKH7JDFQQl3yIxoxFQ5up18Xw/6QNkhah57QzaWsxlqz/J7Kr IZubJnx0LkV3WxHsuUkLHK2cCuwJGfIqlZUTpbg+pjtFPp0wy3S2Lwwc+GMiNOZV fph72EqtfXYm5RoT2PsLhCGVGmrhlM87lU9ed2jJAH8uH20/0Bbf1WJrDwuWA6Nw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2345410288; Wed, 11 Jul 2018 13:46:02 -0400 (EDT) From: Thomas Monjalon To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com Date: Wed, 11 Jul 2018 19:46:00 +0200 Message-ID: <1611182.N2xzx1MTAb@xps> In-Reply-To: <20180629172738.2121-7-gavin.hu@arm.com> References: <20180625024913.17219-1-gavin.hu@arm.com> <20180629172738.2121-1-gavin.hu@arm.com> <20180629172738.2121-7-gavin.hu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v14 6/6] devtools: expand meson cross compiling test coverage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 17:46:05 -0000 29/06/2018 19:27, Gavin Hu: > The default test script covers only default host cc compiler, either gcc or > clang, the fix is to increase the coverage by adding one more to cover > clang and the others for gcc. > > Fixes: a55277a788 ("devtools: add test script for meson builds") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Reviewed-by: Phil Yang > Reviewed-by: Song Zhu > Acked-by: Bruce Richardson > --- > devtools/test-meson-builds.sh | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 9bb5b93bd..f38304e6e 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -15,7 +15,7 @@ if command -v ninja >/dev/null 2>&1 ; then > elif command -v ninja-build >/dev/null 2>&1 ; then > ninja_cmd=ninja-build > else > - echo "## ERROR: ninja is missing, please install..." > + echo "ERROR: ninja is not found" This is changing a (not related) line introduced in patch 4. I will squash myself if no other error is found.