DPDK patches and discussions
 help / color / mirror / Atom feed
From: Timothy McDaniel <timothy.mcdaniel@intel.com>
To: jerinj@marvell.com
Cc: mattias.ronnblom@ericsson.com, dev@dpdk.org,
	john.mcnamara@intel.com, harry.van.haaren@intel.com,
	timothy.mcdaniel@intel.com
Subject: [dpdk-dev] [PATCH] event/dlb: fix bugs due to accessing uninitialized variables
Date: Wed,  3 Feb 2021 12:12:21 -0600	[thread overview]
Message-ID: <1612375941-26138-1-git-send-email-timothy.mcdaniel@intel.com> (raw)

This patch updates the PMD to initialize response fields
prior to calling into the PF layer.

Fixes the following coverity issues:

Fixes: eb14a3421afd ("event/dlb: add eventdev start")
Coverity issue: 366205

Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
Coverity issue: 366202

Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
Coverity issue: 366200

Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
 drivers/event/dlb/dlb.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c
index 64e6df7..8b26d1d 100644
--- a/drivers/event/dlb/dlb.c
+++ b/drivers/event/dlb/dlb.c
@@ -1847,7 +1847,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
 {
 	struct dlb_hw_dev *handle = &dlb->qm_instance;
 	struct dlb_create_dir_queue_args cfg;
-	struct dlb_cmd_response response;
+	struct dlb_cmd_response response = {0};
 	int32_t ret;
 
 	cfg.response = (uintptr_t)&response;
@@ -3573,7 +3573,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
 {
 	struct dlb_hw_dev *handle = &dlb->qm_instance;
 	struct dlb_get_ldb_queue_depth_args cfg;
-	struct dlb_cmd_response response;
+	struct dlb_cmd_response response = {0};
 	int ret;
 
 	cfg.queue_id = queue->qm_queue.id;
@@ -3595,7 +3595,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
 {
 	struct dlb_hw_dev *handle = &dlb->qm_instance;
 	struct dlb_get_dir_queue_depth_args cfg;
-	struct dlb_cmd_response response;
+	struct dlb_cmd_response response = {0};
 	int ret;
 
 	cfg.queue_id = queue->qm_queue.id;
-- 
1.7.10


             reply	other threads:[~2021-02-03 18:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 18:12 Timothy McDaniel [this message]
2021-02-04 12:29 ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1612375941-26138-1-git-send-email-timothy.mcdaniel@intel.com \
    --to=timothy.mcdaniel@intel.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=mattias.ronnblom@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).