* [dpdk-dev] [PATCH] event/dlb: fix bugs due to accessing uninitialized variables
@ 2021-02-03 18:12 Timothy McDaniel
2021-02-04 12:29 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: Timothy McDaniel @ 2021-02-03 18:12 UTC (permalink / raw)
To: jerinj
Cc: mattias.ronnblom, dev, john.mcnamara, harry.van.haaren, timothy.mcdaniel
This patch updates the PMD to initialize response fields
prior to calling into the PF layer.
Fixes the following coverity issues:
Fixes: eb14a3421afd ("event/dlb: add eventdev start")
Coverity issue: 366205
Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
Coverity issue: 366202
Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
Coverity issue: 366200
Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
drivers/event/dlb/dlb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c
index 64e6df7..8b26d1d 100644
--- a/drivers/event/dlb/dlb.c
+++ b/drivers/event/dlb/dlb.c
@@ -1847,7 +1847,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
{
struct dlb_hw_dev *handle = &dlb->qm_instance;
struct dlb_create_dir_queue_args cfg;
- struct dlb_cmd_response response;
+ struct dlb_cmd_response response = {0};
int32_t ret;
cfg.response = (uintptr_t)&response;
@@ -3573,7 +3573,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
{
struct dlb_hw_dev *handle = &dlb->qm_instance;
struct dlb_get_ldb_queue_depth_args cfg;
- struct dlb_cmd_response response;
+ struct dlb_cmd_response response = {0};
int ret;
cfg.queue_id = queue->qm_queue.id;
@@ -3595,7 +3595,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
{
struct dlb_hw_dev *handle = &dlb->qm_instance;
struct dlb_get_dir_queue_depth_args cfg;
- struct dlb_cmd_response response;
+ struct dlb_cmd_response response = {0};
int ret;
cfg.queue_id = queue->qm_queue.id;
--
1.7.10
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] event/dlb: fix bugs due to accessing uninitialized variables
2021-02-03 18:12 [dpdk-dev] [PATCH] event/dlb: fix bugs due to accessing uninitialized variables Timothy McDaniel
@ 2021-02-04 12:29 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2021-02-04 12:29 UTC (permalink / raw)
To: Timothy McDaniel
Cc: Jerin Jacob, Mattias Rönnblom, dpdk-dev, John McNamara,
Van Haaren, Harry
On Wed, Feb 3, 2021 at 11:42 PM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
> This patch updates the PMD to initialize response fields
> prior to calling into the PF layer.
>
> Fixes the following coverity issues:
>
> Fixes: eb14a3421afd ("event/dlb: add eventdev start")
> Coverity issue: 366205
>
> Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
> Coverity issue: 366202
>
> Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
> Coverity issue: 366200
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
Please increment the patch version when you send a new version.
Fixed ./devtools/check-git-log.sh issues and Applied to
dpdk-next-eventdev/for-main for rc3. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-04 12:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 18:12 [dpdk-dev] [PATCH] event/dlb: fix bugs due to accessing uninitialized variables Timothy McDaniel
2021-02-04 12:29 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).