From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8165645B4C; Tue, 22 Oct 2024 16:47:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70A0F402CD; Tue, 22 Oct 2024 16:47:51 +0200 (CEST) Received: from smtp-gw.pt.net (smtp-gw.pt.net [206.210.192.15]) by mails.dpdk.org (Postfix) with ESMTP id 6A3A54029A for ; Tue, 22 Oct 2024 16:47:50 +0200 (CEST) X-ASG-Debug-ID: 1729608469-09411a490e2daba0001-TfluYd Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by smtp-gw.pt.net with ESMTP id FEJzEFOK4OADzxEw (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 22 Oct 2024 09:47:49 -0500 (CDT) X-Barracuda-Envelope-From: lew@perftech.com X-Barracuda-Effective-Source-IP: mail.pt.net[206.210.194.11] X-Barracuda-Apparent-Source-IP: 206.210.194.11 Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id F20A7D14641; Tue, 22 Oct 2024 09:47:48 -0500 (CDT) Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10032) with ESMTP id 8i1IWKuyWELX; Tue, 22 Oct 2024 09:47:48 -0500 (CDT) Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id A8B24D14681; Tue, 22 Oct 2024 09:47:48 -0500 (CDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.pt.net A8B24D14681 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perftech.com; s=B15A3A56-ABEA-11EE-9719-5F12F125680F; t=1729608468; bh=DlfBT0YqtBsIH2ti9VJLinAaszwKNKdgCXS1daPCroM=; h=Date:From:To:Message-ID:MIME-Version; b=jaceY5MS6x5WTuF2pdkExlrevobDto9yGLMm4v+AND0THogc7x1/IqAxnqHKPChJn EYeW2iITC1t4pf0ekUqQw5Jh7Nh18CjToAvpwqQo1DYTxp8AeUtC5yaITvH4Mf2LIp ePp8vbUF6HmawWhGWwx2IzTo6tPtUyU8I23jEhT/CmWsy9UzzeF84Kbkh0cic/pFNo vLQWrX78Y5/IWyNNhbIvnvn+Bd+BJKybguqyOYCfTk7sVpmFlG2sGfE72N2Qp3FVIH E+v8JHdrHbr2c2QtnD2vW3prN4oOM06iUOAUUcqyunL2IFm43dWlk7akF/exMJ3jQN xiuzoNZygY3mw== X-Virus-Scanned: amavis at pt.net Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10026) with ESMTP id TLqJdK0m5D0G; Tue, 22 Oct 2024 09:47:48 -0500 (CDT) Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by mail.pt.net (Postfix) with ESMTP id 92E9BD14525; Tue, 22 Oct 2024 09:47:48 -0500 (CDT) Date: Tue, 22 Oct 2024 09:47:48 -0500 (CDT) From: Lewis Donzis To: Bruce Richardson Cc: dev Message-ID: <1613500549.8985881.1729608468411.JavaMail.zimbra@donzis.com> In-Reply-To: References: <20240927180829.525350-1-sriharsha.basavapatna@broadcom.com> <20240927180829.525350-18-sriharsha.basavapatna@broadcom.com> <136318200.3114519.1727475831877.JavaMail.zimbra@donzis.com> <1498261798.8960233.1729600321210.JavaMail.zimbra@donzis.com> Subject: Re: FreeBSD problem with ixgbe MIME-Version: 1.0 X-ASG-Orig-Subj: Re: FreeBSD problem with ixgbe Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: [206.210.194.11] X-Mailer: Zimbra 8.8.15_GA_4652 (ZimbraWebClient - GC130 (Mac)/8.8.15_GA_4652) Thread-Topic: FreeBSD problem with ixgbe Thread-Index: EtX77mNQ+Y5Fh5+uxOwTUjZziMPDOA== X-Barracuda-Connect: mail.pt.net[206.210.194.11] X-Barracuda-Start-Time: 1729608469 X-Barracuda-Encrypted: TLS_AES_256_GCM_SHA384 X-Barracuda-URL: https://smtp-gw.pt.net:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at pt.net X-Barracuda-Scan-Msg-Size: 1696 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.132145 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Certainly. This is my first attempt and I didn't realize some of the rules, but hopefully it'll work. Thanks, lew ----- On Oct 22, 2024, at 8:03 AM, Bruce Richardson bruce.richardson@intel.com wrote: > On Tue, Oct 22, 2024 at 07:32:01AM -0500, Lewis Donzis wrote: >> I've reported this several times over the last two years, but there's been no >> reply and no change to the ixgbe driver. >> >> Specifically, calling rte_eth_link_get_nowait() on FreeBSD does, in fact, wait >> for link-up which causes unexpected and long delays. >> >> I suggest removing the line from ixgbe_dev_link_update_share() that forces >> "wait" to be set on FreeBSD. Would someone be willing to commit this, please? >> >> Thanks, >> lew >> > > Hi Lewis, > > could you please submit this change as a patch (using git send-email) > including your signoff on it? We can't take code into DPDK without the > appropriate signoff. > > Thanks, > > /Bruce > > PS: For reference see: > https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body > >> Here's the "git diff" from a modified version: >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >> index ab37c37469..008760e315 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> @@ -4314,11 +4314,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, >> if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0) >> wait = 0; >> >> -/* BSD has no interrupt mechanism, so force NIC status synchronization. */ >> -#ifdef RTE_EXEC_ENV_FREEBSD >> - wait = 1; >> -#endif > > -