DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] cxgbe: explictly mark this as pci_driver
@ 2015-12-02 22:16 Stephen Hemminger
  2015-12-03  7:06 ` Rahul Lakkireddy
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2015-12-02 22:16 UTC (permalink / raw)
  To: rahul.lakkireddy; +Cc: dev

The upcoming Hyper-V driver converts the pci_drv element
in struct eth_driver to a union.  When vmbus is added the
pci_drv needs to be explicit. Easier to fix the issue
ahead of time.

This is backwards compatiable with previous code.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/cxgbe/cxgbe_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c
index ec5d22b..97ef152 100644
--- a/drivers/net/cxgbe/cxgbe_ethdev.c
+++ b/drivers/net/cxgbe/cxgbe_ethdev.c
@@ -847,7 +847,7 @@ out_free_adapter:
 }
 
 static struct eth_driver rte_cxgbe_pmd = {
-	{
+	.pci_drv = {
 		.name = "rte_cxgbe_pmd",
 		.id_table = cxgb4_pci_tbl,
 		.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
-- 
2.1.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] cxgbe: explictly mark this as pci_driver
  2015-12-02 22:16 [dpdk-dev] [PATCH] cxgbe: explictly mark this as pci_driver Stephen Hemminger
@ 2015-12-03  7:06 ` Rahul Lakkireddy
  2015-12-06 21:40   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Rahul Lakkireddy @ 2015-12-03  7:06 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev

On Wednesday, December 12/02/15, 2015 at 14:16:18 -0800, Stephen Hemminger wrote:
> The upcoming Hyper-V driver converts the pci_drv element
> in struct eth_driver to a union.  When vmbus is added the
> pci_drv needs to be explicit. Easier to fix the issue
> ahead of time.
> 
> This is backwards compatiable with previous code.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/cxgbe/cxgbe_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c
> index ec5d22b..97ef152 100644
> --- a/drivers/net/cxgbe/cxgbe_ethdev.c
> +++ b/drivers/net/cxgbe/cxgbe_ethdev.c
> @@ -847,7 +847,7 @@ out_free_adapter:
>  }
>  
>  static struct eth_driver rte_cxgbe_pmd = {
> -	{
> +	.pci_drv = {
>  		.name = "rte_cxgbe_pmd",
>  		.id_table = cxgb4_pci_tbl,
>  		.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
> -- 
> 2.1.4
> 

Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] cxgbe: explictly mark this as pci_driver
  2015-12-03  7:06 ` Rahul Lakkireddy
@ 2015-12-06 21:40   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-12-06 21:40 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev

2015-12-03 12:36, Rahul Lakkireddy:
> On Wednesday, December 12/02/15, 2015 at 14:16:18 -0800, Stephen Hemminger wrote:
> > The upcoming Hyper-V driver converts the pci_drv element
> > in struct eth_driver to a union.  When vmbus is added the
> > pci_drv needs to be explicit. Easier to fix the issue
> > ahead of time.
> > 
> > This is backwards compatiable with previous code.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-06 21:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-02 22:16 [dpdk-dev] [PATCH] cxgbe: explictly mark this as pci_driver Stephen Hemminger
2015-12-03  7:06 ` Rahul Lakkireddy
2015-12-06 21:40   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).