From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id B1ADB5686 for ; Thu, 15 Jan 2015 14:38:50 +0100 (CET) Received: by mail-wi0-f180.google.com with SMTP id n3so17855841wiv.1 for ; Thu, 15 Jan 2015 05:38:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=HtdWwp861jwz5NsIdEyImqonjsGYZ25gqoVeVcoPkHI=; b=iTrxZWlkmmddsaxlH5n+wNe8So5sLr/Lz0lBNUGeezEYKuXvUOYmNB+1JCL1EhgGiD 5gwHEsq5lf9KDT9WriVknlgQ190n7N+qED60GkEDjXn3uGamX9oi70eVDQ5r5+UTN1Dr QIbzcF9PMPYyH2k0Z+g3gPcd7NFulJfl4IiX9RZCMwnLYkhi2Il15K4/FEH2XBSepNmS vp1YOU1SA8JH0xV2UuOTXHEh8DX3NpyLFjRfCT0ov31I6tTdPyjEnWhbfWMtBSocLfYr B0Nnol8xXzDxDMNg5xoxUhUEs9AcGvL/xOF1zaWepUiCpqXY8gnoOOAMfZPNLcNZHKED ReWQ== X-Gm-Message-State: ALoCoQkIxxBLi2ZLbqyGAjLCxLe5rQ/pY4df417vHVWZCcZyOlEGCvtOFSK44hhLoUs1k2BszELy X-Received: by 10.180.24.167 with SMTP id v7mr26694257wif.5.1421329130501; Thu, 15 Jan 2015 05:38:50 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id cg8sm2153858wjc.1.2015.01.15.05.38.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Jan 2015 05:38:49 -0800 (PST) From: Thomas Monjalon To: "Qiu, Michael" Date: Thu, 15 Jan 2015 14:38:27 +0100 Message-ID: <1613897.2bqBHJQoa5@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1418035455-9434-1-git-send-email-michael.qiu@intel.com> <1418211977-8218-1-git-send-email-michael.qiu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6] VFIO: Avoid to enable vfio while the module not loaded X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2015 13:38:50 -0000 > > When vfio module is not loaded when kernel support vfio feature, the > > routine still try to open the container to get file description. > > > > This action is not safe, and of cause got error messages: > > > > EAL: Detected 40 lcore(s) > > EAL: unsupported IOMMU type! > > EAL: VFIO support could not be initialized > > EAL: Setting up memory... > > > > This may make user confuse, this patch make it reasonable and much more > > soomth to user. > > > > Signed-off-by: Michael Qiu > > Acked-by: Anatoly Burakov Note that rte_eal_check_module has no bsd counterpart. It could be needed later. Applied Thanks -- Thomas