[dpdk-dev] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK

[dpdk-dev] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK

[Jie Zhou]

From: Jie Zhou <jizh@microsoft.com>

Meson with Windows clang generates incorrect linker flag
"--subsystem,console" instead of "/subsystem:console" which
will fail the DPDK build. This is discovered at porting testpmd.

Meson 0.57.0 has the fix and should be used for DPDK Windows build.
Update the DPDK WindowsGSG DPDK Build document for the proper meson
version. Will then sync with ci@dpdk.org to update meson in CI pipeline.

Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
 doc/guides/windows_gsg/build_dpdk.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/windows_gsg/build_dpdk.rst b/doc/guides/windows_gsg/build_dpdk.rst
index 5f1395f3d..8083227ea 100644
--- a/doc/guides/windows_gsg/build_dpdk.rst
+++ b/doc/guides/windows_gsg/build_dpdk.rst
@@ -64,7 +64,7 @@ A good option to choose is the MSI installer for both meson and ninja together::
 
 	http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22
 
-Recommended version is either Meson 0.47.1 (baseline) or the latest release.
+Recommended version is either Meson 0.57.0 (baseline) or the latest release.
 
 Install the Backend
 -------------------
-- 
2.30.0.vfs.0.2

Re: [dpdk-dev] [EXTERNAL] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK

[Jie Zhou]

Add Dmitry.

-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Jie Zhou
Sent: Wednesday, February 24, 2021 3:37 PM
To: dev@dpdk.org
Cc: thomas <thomas@monjalon.net>; roretzla@linux.microsoft.com
Subject: [EXTERNAL] [dpdk-dev] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK

From: Jie Zhou <jizh@microsoft.com>

Meson with Windows clang generates incorrect linker flag "--subsystem,console" instead of "/subsystem:console" which will fail the DPDK build. This is discovered at porting testpmd.

Meson 0.57.0 has the fix and should be used for DPDK Windows build.
Update the DPDK WindowsGSG DPDK Build document for the proper meson version. Will then sync with ci@dpdk.org to update meson in CI pipeline.

Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
 doc/guides/windows_gsg/build_dpdk.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/windows_gsg/build_dpdk.rst b/doc/guides/windows_gsg/build_dpdk.rst
index 5f1395f3d..8083227ea 100644
--- a/doc/guides/windows_gsg/build_dpdk.rst
+++ b/doc/guides/windows_gsg/build_dpdk.rst
@@ -64,7 +64,7 @@ A good option to choose is the MSI installer for both meson and ninja together::
 
 	https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmesonbuild.com%2FGetting-meson.html%23installing-meson-and-ninja-with-the-msi-installer%2522&amp;data=04%7C01%7Cjizh%40microsoft.com%7C124559f34a4245cef68808d8d91d1508%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637498066227214579%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=oXVIHUzLnN0KkaRED1skiCq3W1LQRJS8H0NAHCCvu6A%3D&amp;reserved=0
 
-Recommended version is either Meson 0.47.1 (baseline) or the latest release.
+Recommended version is either Meson 0.57.0 (baseline) or the latest release.
 
 Install the Backend
 -------------------
--
2.30.0.vfs.0.2

Re: [dpdk-dev] [EXTERNAL] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK

[Thomas Monjalon]

08/03/2021 19:32, Jie Zhou:
> Add Dmitry.

There are more maintainers to Cc.
I recommend using Linux for sending the patches,
so you can use the script devtools/get-maintainer.sh
with the option --cc-cmd.


> From: Jie Zhou <jizh@microsoft.com>
> 
> Meson with Windows clang generates incorrect linker flag "--subsystem,console" instead of "/subsystem:console" which will fail the DPDK build. This is discovered at porting testpmd.
> 
> Meson 0.57.0 has the fix and should be used for DPDK Windows build.
> Update the DPDK WindowsGSG DPDK Build document for the proper meson version. Will then sync with ci@dpdk.org to update meson in CI pipeline.
> 
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>

Why signing with a different email address than the "From"?

[...]
>  	https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmesonbuild.com%2FGetting-meson.html%23installing-meson-and-ninja-with-the-msi-installer%2522&amp;data=04%7C01%7Cjizh%40microsoft.com%7C124559f34a4245cef68808d8d91d1508%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637498066227214579%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=oXVIHUzLnN0KkaRED1skiCq3W1LQRJS8H0NAHCCvu6A%3D&amp;reserved=0

That's interesting how your mail server can break a patch :)


> -Recommended version is either Meson 0.47.1 (baseline) or the latest release.
> +Recommended version is either Meson 0.57.0 (baseline) or the latest release.

I am OK with the change. What others think?

Re: [dpdk-dev] [EXTERNAL] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK

[Dmitry Kozlyuk]

2021-03-16 12:09 (UTC+0100), Thomas Monjalon:
> 08/03/2021 19:32, Jie Zhou:
[...]
> > -Recommended version is either Meson 0.47.1 (baseline) or the latest release.
> > +Recommended version is either Meson 0.57.0 (baseline) or the latest release.  
> 
> I am OK with the change. What others think?

Although I can't reproduce it with meson 0.53.2 and 0.56.2 and I wonder why it
doesn't affect examples as well, the issue exists in meson tracker:
https://github.com/mesonbuild/meson/issues/8060

On Windows, there's no repository to constrain meson version from above,
so if 0.57.0 has no known issues, let's recommend it.

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Re: [dpdk-dev] [EXTERNAL] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK

[Thomas Monjalon]

17/03/2021 01:00, Dmitry Kozlyuk:
> 2021-03-16 12:09 (UTC+0100), Thomas Monjalon:
> > 08/03/2021 19:32, Jie Zhou:
> [...]
> > > -Recommended version is either Meson 0.47.1 (baseline) or the latest release.
> > > +Recommended version is either Meson 0.57.0 (baseline) or the latest release.  
> > 
> > I am OK with the change. What others think?
> 
> Although I can't reproduce it with meson 0.53.2 and 0.56.2 and I wonder why it
> doesn't affect examples as well, the issue exists in meson tracker:
> https://github.com/mesonbuild/meson/issues/8060
> 
> On Windows, there's no repository to constrain meson version from above,
> so if 0.57.0 has no known issues, let's recommend it.
> 
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Applied, thanks