DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matan Azrad <matan@nvidia.com>
To: dev@dpdk.org
Cc: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: [dpdk-dev] [PATCH 0/4] net/mlx5: fix imissed statistic
Date: Thu, 25 Feb 2021 10:44:57 +0000	[thread overview]
Message-ID: <1614249901-307665-1-git-send-email-matan@nvidia.com> (raw)

The imissed port statistic counts packets that were dropped
by the device Rx queues.

In mlx5, the imissed counter summarizes 2 counters:
	- packets dropped by the SW queue handling counted by SW.
	- packets dropped by the HW queues due to "out of buffer" events
	  detected when no SW buffer is available for the incoming
	  packets.

There is HW counter object that should be created per device, and all
the Rx queues should be assigned to this counter in configuration time.

This part was missed when the Rx queues were created by DevX what
remained the "out of buffer" counter clean forever in this case.

Add 2 options to assign the DevX Rx queues to queue counter:
	- Create queue counter per device by DevX and assign all the
	  queues to it.
	- Query the kernel counter and assign all the queues to it.

Use the first option by default and if it is failed, fallback to the
second option.

Matan Azrad (4):
  common/mlx5/linux: add glue function to query WQ
  common/mlx5: add DevX command to query WQ
  common/mlx5: add DevX commands for queue counters
  net/mlx5: fix imissed statistics

Series-acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>


 drivers/common/mlx5/linux/mlx5_glue.c |  18 ++++++
 drivers/common/mlx5/linux/mlx5_glue.h |   2 +
 drivers/common/mlx5/mlx5_devx_cmds.c  | 100 ++++++++++++++++++++++++++++++++++
 drivers/common/mlx5/mlx5_devx_cmds.h  |   9 +++
 drivers/common/mlx5/mlx5_prm.h        | 100 ++++++++++++++++++++++++++++++++++
 drivers/common/mlx5/version.map       |   5 +-
 drivers/net/mlx5/linux/mlx5_os.c      |  52 ++++++++++++++++++
 drivers/net/mlx5/mlx5.c               |   4 ++
 drivers/net/mlx5/mlx5.h               |   2 +
 drivers/net/mlx5/mlx5_devx.c          |   2 +
 10 files changed, 293 insertions(+), 1 deletion(-)

-- 
1.8.3.1


             reply	other threads:[~2021-02-25 10:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 10:44 Matan Azrad [this message]
2021-02-25 10:44 ` [dpdk-dev] [PATCH 1/4] common/mlx5/linux: add glue function to query WQ Matan Azrad
2021-03-03 13:58   ` Slava Ovsiienko
2021-02-25 10:44 ` [dpdk-dev] [PATCH 2/4] common/mlx5: add DevX command " Matan Azrad
2021-03-03 13:58   ` Slava Ovsiienko
2021-02-25 10:45 ` [dpdk-dev] [PATCH 3/4] common/mlx5: add DevX commands for queue counters Matan Azrad
2021-03-03 13:59   ` Slava Ovsiienko
2021-02-25 10:45 ` [dpdk-dev] [PATCH 4/4] net/mlx5: fix imissed statistics Matan Azrad
2021-03-03 13:59   ` Slava Ovsiienko
2021-03-03 16:28 ` [dpdk-dev] [PATCH 0/4] net/mlx5: fix imissed statistic Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1614249901-307665-1-git-send-email-matan@nvidia.com \
    --to=matan@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).