From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f179.google.com (mail-qk0-f179.google.com [209.85.220.179]) by dpdk.org (Postfix) with ESMTP id 7F0162BCE for ; Tue, 11 Oct 2016 18:32:14 +0200 (CEST) Received: by mail-qk0-f179.google.com with SMTP id f128so40583634qkb.1 for ; Tue, 11 Oct 2016 09:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=ayjf8cM4vGMjIJwGr+BDMerG0zkDPLNFR7WYT+prUR0=; b=uexHKRuLWh4ruM3CF4MYnIhRcStVSiOWxLxHHAa2FZFE4wUMcjRRqnIRgGH49F7tnq z4PfmPIsTKN3GIXKdYyGFnrGDqfBbQbMrFzGoSVoGjArCxIOJeUGqgsZfFu1NtglBmxO tNcOtA0C4TPWRHwEAp31h4FOAaooYRaATDGTmSr68JNAv63wggOiJ36stRTuUHCl8HHo hcYM5TGw4DbfofFD8j87p9rEZEjaceRXr4KFEYrgH7G5VHmR+GBQqf1JLISPoo0OdcQo DKeZzGNvNSoRitCG3bRdIVroyPWdoOYTUvhmta0rSaSYuYQAzBRkGhLqz4xjnZWnk/oU aqJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ayjf8cM4vGMjIJwGr+BDMerG0zkDPLNFR7WYT+prUR0=; b=fp52Zh+jws+oxl1VB6AdHeF0rGM+ChF46gQuGWXOeSOYebsRWRjahnvnEDv5aJoPul VtlQKfeya/Qa2PgT4Q2PsF6pzb0jb7PRyXSju3binW9H6mWWCqpIj8FUbDj2K7DWh6CV eqjFB2CF5wkBesWNX9uxrdcguBlNozpwfV1A6Kk7R9+c4rBPWKzCMG895M+A1lBgYh5m IYaPx9iipNpzJwgjEYbluJ98225572P8cYPo4qeKAJYMsDCzTw2PKnxmDTm8JCbnXy8b UAEFH5uCjfEicnsJWqO0KxQ6Gx+DNnhAtoA66SBnQQw941R4O+/CP+QgGLvFwJpo5D/M dSaw== X-Gm-Message-State: AA6/9RmHAoEpDKn6te+w5Zg0kjQubjOskDhwifK+b152krWM7GOvkdRBRgXmTPNKDvBKJ/3a X-Received: by 10.194.200.162 with SMTP id jt2mr5920209wjc.172.1476203531842; Tue, 11 Oct 2016 09:32:11 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id uq6sm7622748wjc.37.2016.10.11.09.32.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Oct 2016 09:32:11 -0700 (PDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: "Yigit, Ferruh" , dev@dpdk.org, "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" Date: Tue, 11 Oct 2016 18:32:10 +0200 Message-ID: <1615821.fhDo4YvI1t@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A090A8A@IRSMSX108.ger.corp.intel.com> References: <1475231418-30717-2-git-send-email-bernard.iremonger@intel.com> <2850526.ogb5UjoHqb@xps13> <8CEF83825BEC744B83065625E567D7C21A090A8A@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new API's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 16:32:14 -0000 2016-10-11 15:51, Iremonger, Bernard: > Hi Thomas, > > > > > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new > > API's > > > > 2016-10-11 16:09, Ferruh Yigit: > > > This will cause a compilation error for shared libraries. Because PMDs > > > not linked against application when compiled as shared library but > > > used as plugins. > > > > > > Since it has been decided to have NIC specific APIs, we need to > > > re-work that approach to fix shared library compilation. > > > > If testpmd uses the ixgbe API, it must be linked with the PMD. > > Is there any issue adapting the testpmd makefile? > > Hope that dlopen an already linked PMD is nicely managed. > > The ixgbe API will be used by other apps, for example Virtual Function Daemon (VFD) > Moving the following line in rte.app.mak solves the problem > > Line 117: _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > To Line 103. > > Will this be acceptable? I think we must not link PMD in the general case but let this responsibility to the application in case it uses some specific functions. Does it make sense?