From: Michael Baum <michaelba@nvidia.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, viacheslavo@nvidia.com, matan@nvidia.com,
rasland@nvidia.com, Asaf Penso <asafp@nvidia.com>
Subject: [dpdk-dev] [PATCH 2/2] common/mlx5: rename driver name to include PCI notation
Date: Mon, 15 Mar 2021 21:05:55 +0000 [thread overview]
Message-ID: <1615842355-10526-2-git-send-email-michaelba@nvidia.com> (raw)
In-Reply-To: <1615842355-10526-1-git-send-email-michaelba@nvidia.com>
From: Asaf Penso <asafp@nvidia.com>
The current define for MLX5_DRIVER_NAME refers specially for the PCI
driver.
The define itself does not mention PCI and this is confusing.
Rename from MLX5_DRIVER_NAME to MLX5_PCI_DRIVER_NAME.
Signed-off-by: Asaf Penso <asafp@nvidia.com>
---
drivers/common/mlx5/mlx5_common.h | 2 +-
drivers/common/mlx5/mlx5_common_pci.c | 2 +-
drivers/net/mlx5/mlx5.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h
index fc1ac75..84c3960 100644
--- a/drivers/common/mlx5/mlx5_common.h
+++ b/drivers/common/mlx5/mlx5_common.h
@@ -19,7 +19,7 @@
#include "mlx5_devx_cmds.h"
/* Reported driver name. */
-#define MLX5_DRIVER_NAME "mlx5_pci"
+#define MLX5_PCI_DRIVER_NAME "mlx5_pci"
/* Bit-field manipulation. */
#define BITFIELD_DECLARE(bf, type, size) \
diff --git a/drivers/common/mlx5/mlx5_common_pci.c b/drivers/common/mlx5/mlx5_common_pci.c
index 2b65768..3783b0e 100644
--- a/drivers/common/mlx5/mlx5_common_pci.c
+++ b/drivers/common/mlx5/mlx5_common_pci.c
@@ -415,7 +415,7 @@ class_name_to_value(const char *class_name)
static struct rte_pci_driver mlx5_pci_driver = {
.driver = {
- .name = MLX5_DRIVER_NAME,
+ .name = MLX5_PCI_DRIVER_NAME,
},
.probe = mlx5_common_pci_probe,
.remove = mlx5_common_pci_remove,
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index abd7ff70..a22bbc9 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -2094,7 +2094,7 @@ struct mlx5_dev_ctx_shared *
(dev->device == &pci_dev->device ||
(dev->device->driver &&
dev->device->driver->name &&
- !strcmp(dev->device->driver->name, MLX5_DRIVER_NAME))))
+ !strcmp(dev->device->driver->name, MLX5_PCI_DRIVER_NAME))))
break;
port_id++;
}
@@ -2215,7 +2215,7 @@ struct mlx5_dev_ctx_shared *
.driver_class = MLX5_CLASS_NET,
.pci_driver = {
.driver = {
- .name = MLX5_DRIVER_NAME,
+ .name = MLX5_PCI_DRIVER_NAME,
},
.id_table = mlx5_pci_id_map,
.probe = mlx5_os_pci_probe,
--
1.8.3.1
next prev parent reply other threads:[~2021-03-15 21:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 21:05 [dpdk-dev] [PATCH 1/2] common/mlx5: align driver name logs across pmds Michael Baum
2021-03-15 21:05 ` Michael Baum [this message]
2021-03-30 7:36 ` [dpdk-dev] [PATCH 2/2] common/mlx5: rename driver name to include PCI notation Slava Ovsiienko
2021-03-30 7:35 ` [dpdk-dev] [PATCH 1/2] common/mlx5: align driver name logs across pmds Slava Ovsiienko
2021-04-01 11:30 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1615842355-10526-2-git-send-email-michaelba@nvidia.com \
--to=michaelba@nvidia.com \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).