From: Wei Huang <wei.huang@intel.com> To: dev@dpdk.org, rosen.xu@intel.com, qi.z.zhang@intel.com Cc: stable@dpdk.org, tianfei.zhang@intel.com, Wei Huang <wei.huang@intel.com> Subject: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable Date: Wed, 17 Mar 2021 04:23:37 -0400 Message-ID: <1615969417-17118-3-git-send-email-wei.huang@intel.com> (raw) In-Reply-To: <1615969417-17118-1-git-send-email-wei.huang@intel.com> In fme_nios_spi_init(), passing tainted expression "fme->max10_dev" to function "fme_get_board_interface" has risk. Add new arguemnt in function "fme_get_board_interface" to accept untainted variable. Coverity issue: 367482 Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver") Signed-off-by: Wei Huang <wei.huang@intel.com> --- drivers/raw/ifpga/base/ifpga_fme.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c index a63f90331f..4edb9e09e1 100644 --- a/drivers/raw/ifpga/base/ifpga_fme.c +++ b/drivers/raw/ifpga/base/ifpga_fme.c @@ -857,7 +857,8 @@ static int board_type_to_info(u32 type, return 0; } -static int fme_get_board_interface(struct ifpga_fme_hw *fme) +static int fme_get_board_interface(struct ifpga_fme_hw *fme, + struct intel_max10_device *max10_dev) { struct fme_bitstream_id id; struct ifpga_hw *hw; @@ -911,15 +912,15 @@ static int fme_get_board_interface(struct ifpga_fme_hw *fme) fme->board_info.nums_of_fvl, fme->board_info.ports_per_fvl); - if (max10_sys_read(fme->max10_dev, FPGA_PAGE_INFO, &val)) + if (max10_sys_read(max10_dev, FPGA_PAGE_INFO, &val)) return -EINVAL; fme->board_info.boot_page = val & 0x7; - if (max10_sys_read(fme->max10_dev, MAX10_BUILD_VER, &val)) + if (max10_sys_read(max10_dev, MAX10_BUILD_VER, &val)) return -EINVAL; fme->board_info.max10_version = val; - if (max10_sys_read(fme->max10_dev, NIOS2_FW_VERSION, &val)) + if (max10_sys_read(max10_dev, NIOS2_FW_VERSION, &val)) return -EINVAL; fme->board_info.nios_fw_version = val; @@ -1169,7 +1170,7 @@ static int fme_nios_spi_init(struct ifpga_feature *feature) max10->bus = hw->pci_data->bus; - fme_get_board_interface(fme); + fme_get_board_interface(fme, max10); mgr->sensor_list = &max10->opae_sensor_list; @@ -1186,7 +1187,7 @@ static int fme_nios_spi_init(struct ifpga_feature *feature) return ret; spi_fail: - intel_max10_device_remove(fme->max10_dev); + intel_max10_device_remove(max10); release_dev: altera_spi_release(spi_master); return -ENODEV; -- 2.29.2
next prev parent reply other threads:[~2021-03-17 8:23 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-17 8:23 [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Wei Huang 2021-03-17 8:23 ` [dpdk-dev] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument Wei Huang 2021-04-01 7:48 ` Zhang, Tianfei 2021-04-01 8:48 ` Xu, Rosen 2021-04-07 14:57 ` Ferruh Yigit 2021-03-17 8:23 ` Wei Huang [this message] 2021-04-01 7:48 ` [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable Zhang, Tianfei 2021-04-01 8:48 ` Xu, Rosen 2021-04-01 12:17 ` [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Zhang, Qi Z 2021-04-20 8:09 ` Ferruh Yigit 2021-04-20 9:12 ` Zhang, Qi Z 2021-04-20 9:29 ` Zhang, Qi Z
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1615969417-17118-3-git-send-email-wei.huang@intel.com \ --to=wei.huang@intel.com \ --cc=dev@dpdk.org \ --cc=qi.z.zhang@intel.com \ --cc=rosen.xu@intel.com \ --cc=stable@dpdk.org \ --cc=tianfei.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git