From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8963EA00C2; Wed, 17 Mar 2021 07:26:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D04DC242B09; Wed, 17 Mar 2021 07:26:31 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 5D611242B06 for ; Wed, 17 Mar 2021 07:26:30 +0100 (CET) IronPort-SDR: GTzjccHszgHRHELdrOrpPR6v1WSaoCjhL1iIBx6+7DE/cgpcQMu8g3JJyVUp0KjrRqYlMSlmkm Idp1PxhmEKlA== X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="186041217" X-IronPort-AV: E=Sophos;i="5.81,255,1610438400"; d="scan'208";a="186041217" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 23:26:30 -0700 IronPort-SDR: qCFBzBpcwidOtHye2ewuHxjNsomY1jMOhgFXBo0fMkoJX7lkNk0KIsv1UCQFffRH37b6iV20ja L3CnpI37Fe/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,255,1610438400"; d="scan'208";a="433282926" Received: from npg_dpdk_virtio_jiayuhu_07.sh.intel.com ([10.67.118.193]) by fmsmga004.fm.intel.com with ESMTP; 16 Mar 2021 23:26:28 -0700 From: Jiayu Hu To: dev@dpdk.org Cc: maxime.coquelin@redhat.com, chenbo.xia@intel.com, yinan.wang@intel.com, cheng1.jiang@intel.com, sunil.pai.g@intel.com, Jiayu Hu Date: Wed, 17 Mar 2021 08:56:12 -0400 Message-Id: <1615985773-406787-4-git-send-email-jiayu.hu@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1615985773-406787-1-git-send-email-jiayu.hu@intel.com> References: <1615985773-406787-1-git-send-email-jiayu.hu@intel.com> Subject: [dpdk-dev] [PATCH 3/4] vhost: avoid deadlock on async register X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Users register async copy device when vhost queue is enabled. However, if VHOST_USER_F_PROTOCOL_FEATURES is not supported, a deadlock occurs inside rte_vhost_async_channel_register(), as vhost_user_msg_handler() already takes vq->access_lock before processing VHOST_USER_SET_VRING_KICK message. This patch removes calling vring_state_changed() in vhost_user_set_vring_kick() to avoid deadlock on async register. Signed-off-by: Jiayu Hu --- lib/librte_vhost/vhost_user.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 399675c..a319c1c 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -1919,9 +1919,6 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg, */ if (!(dev->features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES))) { vq->enabled = 1; - if (dev->notify_ops->vring_state_changed) - dev->notify_ops->vring_state_changed( - dev->vid, file.index, 1); } if (vq->ready) { -- 2.7.4