DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>, <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH 1/6] net/hns3: fix the reporting of undefined speed
Date: Tue, 23 Mar 2021 21:45:51 +0800	[thread overview]
Message-ID: <1616507156-35880-2-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1616507156-35880-1-git-send-email-humin29@huawei.com>

From: Huisong Li <lihuisong@huawei.com>

There may be a case in future that the speed obtained from firmware
is undefined(such as, 400G or other rate), and link status of device is
up. At this case, PMD driver will reports 100Mbps to the user in the
"hns3_dev_link_update" API, which is unreasonable. Besides, if the
speed from firmware is zero, driver should report zero instead of
100Mbps.

Fixes: 59fad0f32135 ("net/hns3: support link update operation")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 drivers/net/hns3/hns3_ethdev.c    | 5 ++++-
 drivers/net/hns3/hns3_ethdev_vf.c | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index fba715b..410b241 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -2725,7 +2725,10 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev,
 		new_link.link_speed = mac->link_speed;
 		break;
 	default:
-		new_link.link_speed = ETH_SPEED_NUM_100M;
+		if (mac->link_status)
+			new_link.link_speed = ETH_SPEED_NUM_UNKNOWN;
+		else
+			new_link.link_speed = ETH_SPEED_NUM_NONE;
 		break;
 	}
 
diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c
index b121d7f..6e579b5 100644
--- a/drivers/net/hns3/hns3_ethdev_vf.c
+++ b/drivers/net/hns3/hns3_ethdev_vf.c
@@ -2125,7 +2125,10 @@ hns3vf_dev_link_update(struct rte_eth_dev *eth_dev,
 		new_link.link_speed = mac->link_speed;
 		break;
 	default:
-		new_link.link_speed = ETH_SPEED_NUM_100M;
+		if (mac->link_status)
+			new_link.link_speed = ETH_SPEED_NUM_UNKNOWN;
+		else
+			new_link.link_speed = ETH_SPEED_NUM_NONE;
 		break;
 	}
 
-- 
2.7.4


  reply	other threads:[~2021-03-23 13:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 13:45 [dpdk-dev] [PATCH 0/6] bugfixes for hns3 Min Hu (Connor)
2021-03-23 13:45 ` Min Hu (Connor) [this message]
2021-03-23 13:45 ` [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm Min Hu (Connor)
2021-03-29 16:10   ` Ferruh Yigit
2021-03-29 18:31     ` Aaron Conole
2021-03-29 19:42       ` David Marchand
2021-03-29 22:13         ` Honnappa Nagarahalli
2021-03-31  0:55     ` Min Hu (Connor)
2021-03-31  9:14       ` Ferruh Yigit
2021-03-23 13:45 ` [dpdk-dev] [PATCH 3/6] net/hns3: fix TCP SEG and TCP CKSUM flag set Min Hu (Connor)
2021-03-23 13:45 ` [dpdk-dev] [PATCH 4/6] net/hns3: fix Tx checksum for UDP packets with special port Min Hu (Connor)
2021-03-23 13:45 ` [dpdk-dev] [PATCH 5/6] net/hns3: fix link update when failed to get link info Min Hu (Connor)
2021-03-23 13:45 ` [dpdk-dev] [PATCH 6/6] net/hns3: fix the long taskqueue pairs reset time Min Hu (Connor)
2021-03-30 10:35 ` [dpdk-dev] [PATCH 0/6] bugfixes for hns3 Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1616507156-35880-2-git-send-email-humin29@huawei.com \
    --to=humin29@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).