From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Hiroyuki Mikita <h.mikita89@gmail.com>
Cc: wenzhuo.lu@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] e1000: fix build with clang
Date: Wed, 25 May 2016 18:04:14 +0200 [thread overview]
Message-ID: <1617188.mGNhOEY9vJ@xps13> (raw)
In-Reply-To: <1464189938-1769-1-git-send-email-h.mikita89@gmail.com>
2016-05-26 00:25, Hiroyuki Mikita:
> GCC_VERSION is empty in case of clang:
> /bin/sh: line 0: test: -ge: unary operator expected
>
> It is the same issue as http://dpdk.org/dev/patchwork/patch/5994/
>
> Fixes: 366113dbfb69 ("e1000: suppress misleading indentation warning")
>
> Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
> ---
> v2:
> * fix for cross compier
The output of git grep '(CC)' shows that there is some room for
cross-compilation fixes.
Any volunteer?
> +ifeq ($(findstring gcc, $(CC)), gcc)
> ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
Looks good, thanks
next prev parent reply other threads:[~2016-05-25 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 14:48 [dpdk-dev] [PATCH] " Hiroyuki Mikita
2016-05-25 0:35 ` Lu, Wenzhuo
2016-05-25 12:00 ` Thomas Monjalon
2016-05-25 15:25 ` [dpdk-dev] [PATCH v2] " Hiroyuki Mikita
2016-05-25 16:04 ` Thomas Monjalon [this message]
2016-05-25 16:21 ` Hiroyuki Mikita
2016-05-26 11:36 ` [dpdk-dev] [PATCH v3] " Hiroyuki Mikita
2016-06-10 9:50 ` Bruce Richardson
2016-06-10 9:55 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617188.mGNhOEY9vJ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=h.mikita89@gmail.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).