DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: David Marchand <david.marchand@redhat.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>, dev <dev@dpdk.org>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>,
	Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
	Matan Azrad <matan@nvidia.com>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	talshn@nvidia.com, ophirmu@nvidia.com
Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file
Date: Wed, 07 Apr 2021 10:57:44 +0200
Message-ID: <161779865.tXBAfqbjCS@thomas> (raw)
In-Reply-To: <20210407115330.42701deb@sovereign>

07/04/2021 10:53, Dmitry Kozlyuk:
> 2021-04-07 10:16 (UTC+0200), David Marchand:
> > On Tue, Apr 6, 2021 at 10:09 PM David Marchand
> > <david.marchand@redhat.com> wrote:
> > > We have exports missing in EAL for some series posted on the ml
> > > waiting for merges.
> > > I suspect some recent merged changes have issues too (but did not check yet).
> > > This current patch does not address such issues and we need fixes
> > > afterwards if this is what you mean.  
> > 
> > I did a first pass.
> > 
> > I see symbols from rte_random.c and rte_version.c not exported, while
> > those files are compiled for Windows.
> > Could you explain why these are not exported?
> 
> These are just forgotten, can be safely exported.

I prefer we don't mix fixes with this format rework.
Please send fixes on top of this patch.
Cc'ed Tal & Ophir for mlx5.



  reply	other threads:[~2021-04-07  8:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 16:32 [dpdk-dev] [PATCH] " David Marchand
2021-04-06 16:40 ` David Marchand
2021-04-06 16:50 ` Bruce Richardson
2021-04-06 16:53   ` David Marchand
2021-04-07 20:06   ` Kinsella, Ray
2021-04-06 17:59 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-04-06 18:52   ` Thomas Monjalon
2021-04-06 20:09     ` David Marchand
2021-04-06 22:39       ` Thomas Monjalon
2021-04-07  8:16       ` David Marchand
2021-04-07  8:53         ` Dmitry Kozlyuk
2021-04-07  8:57           ` Thomas Monjalon [this message]
2021-04-07 11:38             ` Tal Shnaiderman
2021-04-08 14:51   ` Thomas Monjalon
2021-04-08 16:11   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161779865.tXBAfqbjCS@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=matan@nvidia.com \
    --cc=mdr@ashroe.eu \
    --cc=navasile@linux.microsoft.com \
    --cc=nhorman@tuxdriver.com \
    --cc=ophirmu@nvidia.com \
    --cc=pallavi.kadam@intel.com \
    --cc=shahafs@nvidia.com \
    --cc=talshn@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git