From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67406A0546; Wed, 7 Apr 2021 10:57:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 457231410D5; Wed, 7 Apr 2021 10:57:49 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 6F868407FF for ; Wed, 7 Apr 2021 10:57:48 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id AFBA0580898; Wed, 7 Apr 2021 04:57:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 07 Apr 2021 04:57:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= AQVt0m+GolFK3iKKdTddSYXuJorEKgKk4NiqSkKiaIU=; b=FrEa4M/G58W6hSHT C9uhzCt2V/troHalCt8jFZ3lBo6TYTGz5Dn8xpszE9NtynID6Yok6BX/xnJQ69Dz Q3gcDsfKx2nTqVFyROw7Oc5/C7XyBSD2132kB1xdTXg+L0H8bFXK78dwg2+pQ8on KbAxuxkFQF+Pn7aDTKgguH6qWcT2LMinu3SQdu1+WiFphZKsaIY3QEFF8oTMMqXd GN7QJNwXydka2d7CeLT5HrDf5GWAjpIm6x5NamUeiDelUv6kWkrnVXfEdqm8lHI+ ud6I94WOKmwWJUo2d5twxjNQojxGCUuhOplqTXLga6seoZrTm9iqiJsbpUHZXdOO LQWGQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=AQVt0m+GolFK3iKKdTddSYXuJorEKgKk4NiqSkKia IU=; b=TCAg2yFG91oq9vcB0xTz5zUoEOQqqrTM9VnCAVgAuYVigg72lZuxM9GH8 nwCQ3cG3Er/N3FAfZ8pNjM0EtzdlWrWmRuzX+gk0RwIpd3+/Tx6Akq8JyqTB2cFK dTfTaicgbOJemJT8UrY1+BdYGE2ocbOde9C4TAbvgiK8wqYoa/q/GMbYQz4gHg86 u73YLw3ooo6LC4ngWST5wHEL56I98D7hCOiM11WYh7RisdFoX/0vhI4fQF9VxYyJ zHRFJZn7CA4Xqk7MCWb6byztGCuVEosBAjt2I9zaPj9Gg2MyghzAAVrDdKOWFx6c LPo+BhjjkcgzHgHy8LaN3RI93Oilg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejjedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7D32A1080067; Wed, 7 Apr 2021 04:57:45 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: David Marchand , Narcisa Ana Maria Vasile , Dmitry Malloy , dev , Bruce Richardson , Pallavi Kadam , Ray Kinsella , Neil Horman , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , talshn@nvidia.com, ophirmu@nvidia.com Date: Wed, 07 Apr 2021 10:57:44 +0200 Message-ID: <161779865.tXBAfqbjCS@thomas> In-Reply-To: <20210407115330.42701deb@sovereign> References: <20210406163231.19663-1-david.marchand@redhat.com> <20210407115330.42701deb@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/04/2021 10:53, Dmitry Kozlyuk: > 2021-04-07 10:16 (UTC+0200), David Marchand: > > On Tue, Apr 6, 2021 at 10:09 PM David Marchand > > wrote: > > > We have exports missing in EAL for some series posted on the ml > > > waiting for merges. > > > I suspect some recent merged changes have issues too (but did not check yet). > > > This current patch does not address such issues and we need fixes > > > afterwards if this is what you mean. > > > > I did a first pass. > > > > I see symbols from rte_random.c and rte_version.c not exported, while > > those files are compiled for Windows. > > Could you explain why these are not exported? > > These are just forgotten, can be safely exported. I prefer we don't mix fixes with this format rework. Please send fixes on top of this patch. Cc'ed Tal & Ophir for mlx5.