From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7E33A00C4; Fri, 5 Jun 2020 10:34:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A4A51D5E2; Fri, 5 Jun 2020 10:33:59 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9C92D1D5DC for ; Fri, 5 Jun 2020 10:33:57 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0D08B5C010E; Fri, 5 Jun 2020 04:33:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 05 Jun 2020 04:33:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= m8EjlBPhSXoXtO7m3yhaJQzGC9elpvTJDzmSXYv5+kE=; b=vG24wFGtiY4i1Yx/ FW6GHzazfKn+o1daFVyp9WtFFz190cepPI5/aaRz33akF3HKMxaSxAU4YsR+ORQ2 B0+nRhOjth8b1VfSNBa3a+mT7p5HjsUPX6koZTfAaeueZgDKRchy1HCvfXUB83AX XN/q/9vK/CvkoZDjSMzf/jvT7By8f4Mtmc5ZRktzGgF/Ia0A/cE9CcdLgtR6Mwu9 hWXbSmhqr+XFg/15fV6ABV7hh7hLyXHAt/hHFRn0hRVSVVLtQFE9w/eDNojxKMmf 0fEjjEuZAg9rgTzjh4Go3MX8vnIHMlcZycsP2x3oIJul9W5D6kxHMi7EdBhlvoQj NzTwwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=m8EjlBPhSXoXtO7m3yhaJQzGC9elpvTJDzmSXYv5+ kE=; b=FLDz5nihPViaq5BSUxQLPF+w47JTxd1pVNxO2BLq7hy687kGxvFF5+hMc uKO/y/xoh7BV0XP/HkwxlYVQyBem4/ddWAxnAGF2wYWH8pl/0liiJAgWDTbVLhnM 47yrZHcSIkKa6HgBGWA2ZeE+RMeo4BzXqwdUa3/ietvupohqZ/vMevi8vOlFH8Ju qofFhegZwj5ZYhpE0Nbyy19ffsGQ4nk7J0f/TZLxhCUaAsPEUVe1o1XnapsNebz0 0ln4IqmfomVGZnQ2P2hBcBq1ZjYU8yMq4jtZieFfrAxf/iVPDpSvtEboHxsqOdcQ KccQnHfLKydbLxJj3mFr4TsmWAxbA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudegfedgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DB9AC30614FA; Fri, 5 Jun 2020 04:33:55 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Andrey Vesnovaty , dev@dpdk.org, Ferruh Yigit , Andrew Rybchenko , Ori Kam Date: Fri, 05 Jun 2020 10:33:53 +0200 Message-ID: <1618422.q0uPWd4TDI@thomas> In-Reply-To: <20200605083035.GA1552@bricha3-MOBL.ger.corp.intel.com> References: <20200520091801.30163-1-andrey.vesnovaty@gmail.com> <2468319.zLU6FhoSUI@thomas> <20200605083035.GA1552@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC] add flow action context API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/06/2020 10:30, Bruce Richardson: > On Thu, Jun 04, 2020 at 07:23:04PM +0200, Thomas Monjalon wrote: > > 04/06/2020 13:12, Andrey Vesnovaty: > > > Thomas Monjalon wrote: > > > > 20/05/2020 11:18, Andrey Vesnovaty: > > > > We had "create", "destroy", "query", but no "modify" capability. > > > > The new API is adding 2 things in my opinion: > > > > - shared action object > > > > - "modify" capability (is "update" a better wording?) > > > > > > Naming is one of the most challenging parts of this RFC. > > > Some similarity I have found in existing code is > > > rte_mtr_policer_actions_update() > > > Is there any existing code having update/modify semantics? > > > > Except one callback in librte_fib, no DPDK API has "modify" in its name. > > You can find the word "update" in the API of multiple DPDK libs. > > I would like having the opinion of a native english speaker here. > > > From a language viewpoint either is fine for conveying what the API does. > In this case "update" would seem to be better for consistency reasons. OK, thank you Bruce