From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>, <cristian.dumitrescu@intel.com>,
<jerinj@marvell.com>, <jianjay.zhou@huawei.com>,
<jia.guo@intel.com>, <g.singh@nxp.com>,
<andrew.rybchenko@oktetlabs.ru>, <hemant.agrawal@nxp.com>,
<orika@nvidia.com>
Subject: [dpdk-dev] [PATCH 03/10] bus/dpaa: fix management command init calling
Date: Mon, 19 Apr 2021 21:34:42 +0800 [thread overview]
Message-ID: <1618839289-33224-4-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1618839289-33224-1-git-send-email-humin29@huawei.com>
'bm_mc_init' only return 0, but the function whicl calls int
check the negative ret, and this is redundant.
This patch fixed it by not checking the return value.
Fixes: f38f61e982f8 ("bus/dpaa: add BMAN hardware interfaces")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
drivers/bus/dpaa/base/qbman/bman.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/bus/dpaa/base/qbman/bman.c b/drivers/bus/dpaa/base/qbman/bman.c
index 8a62907..e1ba2a8 100644
--- a/drivers/bus/dpaa/base/qbman/bman.c
+++ b/drivers/bus/dpaa/base/qbman/bman.c
@@ -70,10 +70,8 @@ struct bman_portal *bman_create_portal(struct bman_portal *portal,
pr_err("Bman RCR initialisation failed\n");
return NULL;
}
- if (bm_mc_init(p)) {
- pr_err("Bman MC initialisation failed\n");
- goto fail_mc;
- }
+ (void)bm_mc_init(p);
+
portal->pools = kmalloc(2 * sizeof(*pools), GFP_KERNEL);
if (!portal->pools)
goto fail_pools;
--
2.7.4
next prev parent reply other threads:[~2021-04-19 13:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 13:34 [dpdk-dev] [PATCH 00/10] fixes for clean code Min Hu (Connor)
2021-04-19 13:34 ` [dpdk-dev] [PATCH 01/10] net/pfe: check return value Min Hu (Connor)
2023-06-30 17:59 ` Stephen Hemminger
2021-04-19 13:34 ` [dpdk-dev] [PATCH 02/10] common/sfc_efx/base: delete redundant handling Min Hu (Connor)
2021-04-20 9:33 ` Andrew Rybchenko
2021-04-20 9:42 ` Min Hu (Connor)
2021-04-19 13:34 ` Min Hu (Connor) [this message]
2021-04-20 9:35 ` [dpdk-dev] [PATCH 03/10] bus/dpaa: fix management command init calling Andrew Rybchenko
2021-04-20 9:54 ` Min Hu (Connor)
2021-04-19 13:34 ` [dpdk-dev] [PATCH 04/10] app/regex: fix division by zero Min Hu (Connor)
2021-04-19 17:48 ` Ori Kam
2021-04-19 13:34 ` [dpdk-dev] [PATCH 05/10] app/test: add null pointer check of memory allocation Min Hu (Connor)
2022-06-26 17:48 ` Thomas Monjalon
2021-04-19 13:34 ` [dpdk-dev] [PATCH 06/10] lib/librte_pipeline: fix the use of unsafe strcpy Min Hu (Connor)
2021-04-20 9:36 ` Andrew Rybchenko
2023-06-30 18:08 ` Stephen Hemminger
2023-07-03 10:57 ` Dumitrescu, Cristian
2021-04-19 13:34 ` [dpdk-dev] [PATCH 07/10] examples/l3fwd: add function return value check Min Hu (Connor)
2023-06-30 18:15 ` Stephen Hemminger
2021-04-19 13:34 ` [dpdk-dev] [PATCH 08/10] crypto/virtio: fix return values check error Min Hu (Connor)
2023-06-30 18:14 ` Stephen Hemminger
2021-04-19 13:34 ` [dpdk-dev] [PATCH 09/10] net/e1000: add function return value check Min Hu (Connor)
2021-04-19 13:34 ` [dpdk-dev] [PATCH 10/10] net/bonding: fix configuration assignment overflow Min Hu (Connor)
2023-06-30 18:02 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1618839289-33224-4-git-send-email-humin29@huawei.com \
--to=humin29@huawei.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=jia.guo@intel.com \
--cc=jianjay.zhou@huawei.com \
--cc=orika@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).