From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53033A0524; Mon, 19 Apr 2021 15:34:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4933412F4; Mon, 19 Apr 2021 15:34:51 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id B1BE0412E6 for ; Mon, 19 Apr 2021 15:34:49 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FP7622g50zqTg4; Mon, 19 Apr 2021 21:32:26 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Mon, 19 Apr 2021 21:34:38 +0800 From: "Min Hu (Connor)" To: CC: , , , , , , , , Date: Mon, 19 Apr 2021 21:34:42 +0800 Message-ID: <1618839289-33224-4-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1618839289-33224-1-git-send-email-humin29@huawei.com> References: <1618839289-33224-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH 03/10] bus/dpaa: fix management command init calling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 'bm_mc_init' only return 0, but the function whicl calls int check the negative ret, and this is redundant. This patch fixed it by not checking the return value. Fixes: f38f61e982f8 ("bus/dpaa: add BMAN hardware interfaces") Cc: stable@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/bus/dpaa/base/qbman/bman.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/bman.c b/drivers/bus/dpaa/base/qbman/bman.c index 8a62907..e1ba2a8 100644 --- a/drivers/bus/dpaa/base/qbman/bman.c +++ b/drivers/bus/dpaa/base/qbman/bman.c @@ -70,10 +70,8 @@ struct bman_portal *bman_create_portal(struct bman_portal *portal, pr_err("Bman RCR initialisation failed\n"); return NULL; } - if (bm_mc_init(p)) { - pr_err("Bman MC initialisation failed\n"); - goto fail_mc; - } + (void)bm_mc_init(p); + portal->pools = kmalloc(2 * sizeof(*pools), GFP_KERNEL); if (!portal->pools) goto fail_pools; -- 2.7.4