DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH 2/5] net/hns3: fix enum variable used as boolean
Date: Tue, 20 Apr 2021 16:59:49 +0800	[thread overview]
Message-ID: <1618909192-17431-3-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1618909192-17431-1-git-send-email-humin29@huawei.com>

params->leaf.cman has enum type which is not isomorphic with boolean
type, however it is used as a boolean expression.

This patch fixed it.

Fixes: c09c7847d892 ("net/hns3: support traffic management")

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 drivers/net/hns3/hns3_tm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/hns3/hns3_tm.c b/drivers/net/hns3/hns3_tm.c
index 165d1fb..aae4970 100644
--- a/drivers/net/hns3/hns3_tm.c
+++ b/drivers/net/hns3/hns3_tm.c
@@ -385,7 +385,7 @@ hns3_tm_leaf_node_param_check(struct rte_eth_dev *dev __rte_unused,
 		return -EINVAL;
 	}
 
-	if (params->leaf.cman) {
+	if (params->leaf.cman != RTE_TM_CMAN_TAIL_DROP) {
 		error->type = RTE_TM_ERROR_TYPE_NODE_PARAMS_CMAN;
 		error->message = "congestion management not supported";
 		return -EINVAL;
-- 
2.7.4


  parent reply	other threads:[~2021-04-20  8:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  8:59 [dpdk-dev] [PATCH 0/5] fixes for hns3 PMD Min Hu (Connor)
2021-04-20  8:59 ` [dpdk-dev] [PATCH 1/5] net/hns3: delete unused macro Min Hu (Connor)
2021-04-20  8:59 ` Min Hu (Connor) [this message]
2021-04-20  8:59 ` [dpdk-dev] [PATCH 3/5] net/hns3: fix unchecked function call Min Hu (Connor)
2021-04-20  8:59 ` [dpdk-dev] [PATCH 4/5] doc: update hns3 feature list Min Hu (Connor)
2021-04-20 10:34   ` Ferruh Yigit
2021-04-20  8:59 ` [dpdk-dev] [PATCH 5/5] doc: fix Rx burst function doc Min Hu (Connor)
2021-04-20 10:56 ` [dpdk-dev] [PATCH 0/5] fixes for hns3 PMD Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1618909192-17431-3-git-send-email-humin29@huawei.com \
    --to=humin29@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).