DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH 3/5] net/hns3: fix unchecked function call
Date: Tue, 20 Apr 2021 16:59:50 +0800	[thread overview]
Message-ID: <1618909192-17431-4-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1618909192-17431-1-git-send-email-humin29@huawei.com>

In hns3 PMD, as the handler always return 0, the return value
of a function 'rte_kvargs_process' no need to be checked. But
the API definition has return value, so 'void' could be used
to ignore that.

Fixes: a124f9e9591b ("net/hns3: add runtime config to select IO burst function")

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 drivers/net/hns3/hns3_ethdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index b29aab5..60267e1 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -7268,11 +7268,11 @@ hns3_parse_devargs(struct rte_eth_dev *dev)
 	if (!kvlist)
 		return;
 
-	rte_kvargs_process(kvlist, HNS3_DEVARG_RX_FUNC_HINT,
+	(void)rte_kvargs_process(kvlist, HNS3_DEVARG_RX_FUNC_HINT,
 			   &hns3_parse_io_hint_func, &rx_func_hint);
-	rte_kvargs_process(kvlist, HNS3_DEVARG_TX_FUNC_HINT,
+	(void)rte_kvargs_process(kvlist, HNS3_DEVARG_TX_FUNC_HINT,
 			   &hns3_parse_io_hint_func, &tx_func_hint);
-	rte_kvargs_process(kvlist, HNS3_DEVARG_DEV_CAPS_MASK,
+	(void)rte_kvargs_process(kvlist, HNS3_DEVARG_DEV_CAPS_MASK,
 			   &hns3_parse_dev_caps_mask, &dev_caps_mask);
 	rte_kvargs_free(kvlist);
 
-- 
2.7.4


  parent reply	other threads:[~2021-04-20  8:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  8:59 [dpdk-dev] [PATCH 0/5] fixes for hns3 PMD Min Hu (Connor)
2021-04-20  8:59 ` [dpdk-dev] [PATCH 1/5] net/hns3: delete unused macro Min Hu (Connor)
2021-04-20  8:59 ` [dpdk-dev] [PATCH 2/5] net/hns3: fix enum variable used as boolean Min Hu (Connor)
2021-04-20  8:59 ` Min Hu (Connor) [this message]
2021-04-20  8:59 ` [dpdk-dev] [PATCH 4/5] doc: update hns3 feature list Min Hu (Connor)
2021-04-20 10:34   ` Ferruh Yigit
2021-04-20  8:59 ` [dpdk-dev] [PATCH 5/5] doc: fix Rx burst function doc Min Hu (Connor)
2021-04-20 10:56 ` [dpdk-dev] [PATCH 0/5] fixes for hns3 PMD Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1618909192-17431-4-git-send-email-humin29@huawei.com \
    --to=humin29@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).