From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>, <jia.guo@intel.com>, <haiyue.wang@intel.com>
Subject: [dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success
Date: Wed, 21 Apr 2021 14:22:25 +0800 [thread overview]
Message-ID: <1618986145-15414-1-git-send-email-humin29@huawei.com> (raw)
From: Chengwen Feng <fengchengwen@huawei.com>
This patch fixes e1000_write_nvm_srwr() alwayes return success.
Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
drivers/net/e1000/base/e1000_i210.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c
index 3c349d3..615e7c9 100644
--- a/drivers/net/e1000/base/e1000_i210.c
+++ b/drivers/net/e1000/base/e1000_i210.c
@@ -310,6 +310,8 @@ STATIC s32 e1000_write_nvm_srwr(struct e1000_hw *hw, u16 offset, u16 words,
}
for (i = 0; i < words; i++) {
+ ret_val = E1000_ERR_NVM;
+
eewr = ((offset + i) << E1000_NVM_RW_ADDR_SHIFT) |
(data[i] << E1000_NVM_RW_REG_DATA) |
E1000_NVM_RW_REG_START;
--
2.7.4
next reply other threads:[~2021-04-21 6:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 6:22 Min Hu (Connor) [this message]
2021-04-21 6:56 ` Wang, Haiyue
2021-04-21 7:14 ` Min Hu (Connor)
2021-04-21 7:10 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-04-21 7:12 ` Min Hu (Connor)
2021-04-21 7:18 ` Wang, Haiyue
2021-04-21 7:28 ` Min Hu (Connor)
2021-04-21 7:34 ` Wang, Haiyue
2021-04-21 9:15 ` Min Hu (Connor)
2021-04-21 9:15 ` [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM write Min Hu (Connor)
2021-04-21 11:22 ` Wang, Haiyue
2021-04-21 14:38 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1618986145-15414-1-git-send-email-humin29@huawei.com \
--to=humin29@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).