DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>, <bernard.iremonger@intel.com>,
	<tomasz.kantecki@intel.com>, <bruce.richardson@intel.com>,
	<thomas@monjalon.net>
Subject: [dpdk-dev] [PATCH v2 3/3] examples/skeleton: fix check of port and core
Date: Wed, 21 Apr 2021 15:00:23 +0800
Message-ID: <1618988423-5034-4-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1618988423-5034-1-git-send-email-humin29@huawei.com>

According to the comments and logging, the author just hope user to use
the core and device which are in the same numa node for optimal
performance. If not, A warning gives out.

For example in flow_classify:
./build/flow_classify -w 0000:7d:00.1  -l 93
Here:
0000:7d:00.1 is on numa node 0.
core 93  is on numa node 3.

The two are not in same numa node, but no warning gives out in old codes.

This patch can fix it.

Fixes: 7107e471a6c7 ("examples/skeleton: very simple code for packet forwarding")
Cc: stable@dpdk.org

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 examples/skeleton/basicfwd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/skeleton/basicfwd.c b/examples/skeleton/basicfwd.c
index 4b2b6ab..bea0e55 100644
--- a/examples/skeleton/basicfwd.c
+++ b/examples/skeleton/basicfwd.c
@@ -122,7 +122,7 @@ lcore_main(void)
 	 * for best performance.
 	 */
 	RTE_ETH_FOREACH_DEV(port)
-		if (rte_eth_dev_socket_id(port) > 0 &&
+		if (rte_eth_dev_socket_id(port) >= 0 &&
 				rte_eth_dev_socket_id(port) !=
 						(int)rte_socket_id())
 			printf("WARNING, port %u is on remote NUMA node to "
-- 
2.7.4


  parent reply	other threads:[~2021-04-21  7:00 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27  7:40 [dpdk-dev] [PATCH 0/3] " Min Hu (Connor)
2021-03-27  7:40 ` [dpdk-dev] [PATCH 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-20  1:08   ` Thomas Monjalon
2021-04-20  2:26     ` Min Hu (Connor)
2021-04-20  9:40       ` Thomas Monjalon
2021-04-27 11:51         ` Iremonger, Bernard
2021-04-27 12:23           ` Min Hu (Connor)
2021-04-27 13:06             ` Iremonger, Bernard
2021-04-28  9:26               ` Iremonger, Bernard
2021-03-27  7:40 ` [dpdk-dev] [PATCH 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-03-27  7:40 ` [dpdk-dev] [PATCH 3/3] examples/skeleton: " Min Hu (Connor)
2021-04-10  9:14 ` [dpdk-dev] [PATCH 0/3] " Min Hu (Connor)
2021-04-19  7:44   ` Min Hu (Connor)
2021-04-21  7:00 ` [dpdk-dev] [PATCH v2 " Min Hu (Connor)
2021-04-21  7:00   ` [dpdk-dev] [PATCH v2 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-28 13:29     ` Iremonger, Bernard
2021-04-29  0:51       ` Min Hu (Connor)
2021-04-21  7:00   ` [dpdk-dev] [PATCH v2 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-04-21  7:00   ` Min Hu (Connor) [this message]
2021-04-29  0:50 ` [dpdk-dev] [PATCH v3 0/3] " Min Hu (Connor)
2021-04-29  0:50   ` [dpdk-dev] [PATCH v3 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-29  9:07     ` Iremonger, Bernard
2021-04-29  9:37       ` Min Hu (Connor)
2021-04-29 11:44         ` Thomas Monjalon
2021-04-29 12:15           ` Min Hu (Connor)
2021-04-29  0:50   ` [dpdk-dev] [PATCH v3 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-04-29  0:50   ` [dpdk-dev] [PATCH v3 3/3] examples/skeleton: " Min Hu (Connor)
2021-05-12 16:52   ` [dpdk-dev] [PATCH v3 0/3] " Ferruh Yigit
2021-05-12 19:16     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1618988423-5034-4-git-send-email-humin29@huawei.com \
    --to=humin29@huawei.com \
    --cc=bernard.iremonger@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    --cc=tomasz.kantecki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git