* Re: [dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success
2021-04-21 6:22 [dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success Min Hu (Connor)
@ 2021-04-21 6:56 ` Wang, Haiyue
2021-04-21 7:14 ` Min Hu (Connor)
2021-04-21 7:10 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
` (2 subsequent siblings)
3 siblings, 1 reply; 12+ messages in thread
From: Wang, Haiyue @ 2021-04-21 6:56 UTC (permalink / raw)
To: Min Hu (Connor), dev; +Cc: Yigit, Ferruh, Guo, Jia
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Wednesday, April 21, 2021 14:22
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Subject: [PATCH] net/e1000: fix write NVM srwr alwayes return success
>
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> This patch fixes e1000_write_nvm_srwr() alwayes return success.
This commit message seems not so correct, it should be like:
This fixes the timed out for shadow RAM write EEWR can't be detected.
>
> Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> drivers/net/e1000/base/e1000_i210.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c
> index 3c349d3..615e7c9 100644
> --- a/drivers/net/e1000/base/e1000_i210.c
> +++ b/drivers/net/e1000/base/e1000_i210.c
> @@ -310,6 +310,8 @@ STATIC s32 e1000_write_nvm_srwr(struct e1000_hw *hw, u16 offset, u16 words,
> }
>
> for (i = 0; i < words; i++) {
> + ret_val = E1000_ERR_NVM;
Should be "-E1000_ERR_NVM" as the below used:
if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
(words == 0)) {
DEBUGOUT("nvm parameter(s) out of bounds\n");
ret_val = -E1000_ERR_NVM; <---
goto out;
}
> +
> eewr = ((offset + i) << E1000_NVM_RW_ADDR_SHIFT) |
> (data[i] << E1000_NVM_RW_REG_DATA) |
> E1000_NVM_RW_REG_START;
> --
> 2.7.4
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success
2021-04-21 6:56 ` Wang, Haiyue
@ 2021-04-21 7:14 ` Min Hu (Connor)
0 siblings, 0 replies; 12+ messages in thread
From: Min Hu (Connor) @ 2021-04-21 7:14 UTC (permalink / raw)
To: Wang, Haiyue, dev; +Cc: Yigit, Ferruh, Guo, Jia
在 2021/4/21 14:56, Wang, Haiyue 写道:
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Wednesday, April 21, 2021 14:22
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
>> <haiyue.wang@intel.com>
>> Subject: [PATCH] net/e1000: fix write NVM srwr alwayes return success
>>
>> From: Chengwen Feng <fengchengwen@huawei.com>
>>
>> This patch fixes e1000_write_nvm_srwr() alwayes return success.
>
> This commit message seems not so correct, it should be like:
>
> This fixes the timed out for shadow RAM write EEWR can't be detected.
>
>>
>> Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>> drivers/net/e1000/base/e1000_i210.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c
>> index 3c349d3..615e7c9 100644
>> --- a/drivers/net/e1000/base/e1000_i210.c
>> +++ b/drivers/net/e1000/base/e1000_i210.c
>> @@ -310,6 +310,8 @@ STATIC s32 e1000_write_nvm_srwr(struct e1000_hw *hw, u16 offset, u16 words,
>> }
>>
>> for (i = 0; i < words; i++) {
>> + ret_val = E1000_ERR_NVM;
>
> Should be "-E1000_ERR_NVM" as the below used:
>
Hi, fixed in v2, thanks.
> if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
> (words == 0)) {
> DEBUGOUT("nvm parameter(s) out of bounds\n");
> ret_val = -E1000_ERR_NVM; <---
> goto out;
> }
>
>> +
>> eewr = ((offset + i) << E1000_NVM_RW_ADDR_SHIFT) |
>> (data[i] << E1000_NVM_RW_REG_DATA) |
>> E1000_NVM_RW_REG_START;
>> --
>> 2.7.4
>
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
2021-04-21 6:22 [dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success Min Hu (Connor)
2021-04-21 6:56 ` Wang, Haiyue
@ 2021-04-21 7:10 ` Min Hu (Connor)
2021-04-21 7:12 ` Min Hu (Connor)
2021-04-21 9:15 ` [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM write Min Hu (Connor)
3 siblings, 0 replies; 12+ messages in thread
From: Min Hu (Connor) @ 2021-04-21 7:10 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, jia.guo, haiyue.wang
From: Chengwen Feng <fengchengwen@huawei.com>
This patch fixes e1000_write_nvm_srwr() alwayes return success.
Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v2:
* change 'E1000_ERR_NVM' to '-E1000_ERR_NVM'.
---
drivers/net/e1000/base/e1000_i210.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c
index 3c349d3..615e7c9 100644
--- a/drivers/net/e1000/base/e1000_i210.c
+++ b/drivers/net/e1000/base/e1000_i210.c
@@ -310,6 +310,8 @@ STATIC s32 e1000_write_nvm_srwr(struct e1000_hw *hw, u16 offset, u16 words,
}
for (i = 0; i < words; i++) {
+ ret_val = E1000_ERR_NVM;
+
eewr = ((offset + i) << E1000_NVM_RW_ADDR_SHIFT) |
(data[i] << E1000_NVM_RW_REG_DATA) |
E1000_NVM_RW_REG_START;
--
2.7.4
^ permalink raw reply [flat|nested] 12+ messages in thread* [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
2021-04-21 6:22 [dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success Min Hu (Connor)
2021-04-21 6:56 ` Wang, Haiyue
2021-04-21 7:10 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
@ 2021-04-21 7:12 ` Min Hu (Connor)
2021-04-21 7:18 ` Wang, Haiyue
2021-04-21 7:34 ` Wang, Haiyue
2021-04-21 9:15 ` [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM write Min Hu (Connor)
3 siblings, 2 replies; 12+ messages in thread
From: Min Hu (Connor) @ 2021-04-21 7:12 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, jia.guo, haiyue.wang
From: Chengwen Feng <fengchengwen@huawei.com>
This patch fixes e1000_write_nvm_srwr() alwayes return success.
Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v2:
* change 'E1000_ERR_NVM' to '-E1000_ERR_NVM'.
---
drivers/net/e1000/base/e1000_i210.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c
index 3c349d3..615e7c9 100644
--- a/drivers/net/e1000/base/e1000_i210.c
+++ b/drivers/net/e1000/base/e1000_i210.c
@@ -310,6 +310,8 @@ STATIC s32 e1000_write_nvm_srwr(struct e1000_hw *hw, u16 offset, u16 words,
}
for (i = 0; i < words; i++) {
+ ret_val = -E1000_ERR_NVM;
+
eewr = ((offset + i) << E1000_NVM_RW_ADDR_SHIFT) |
(data[i] << E1000_NVM_RW_REG_DATA) |
E1000_NVM_RW_REG_START;
--
2.7.4
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
2021-04-21 7:12 ` Min Hu (Connor)
@ 2021-04-21 7:18 ` Wang, Haiyue
2021-04-21 7:28 ` Min Hu (Connor)
2021-04-21 7:34 ` Wang, Haiyue
1 sibling, 1 reply; 12+ messages in thread
From: Wang, Haiyue @ 2021-04-21 7:18 UTC (permalink / raw)
To: Min Hu (Connor), dev; +Cc: Yigit, Ferruh, Guo, Jia
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Wednesday, April 21, 2021 15:12
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Subject: [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
>
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> This patch fixes e1000_write_nvm_srwr() alwayes return success.
Please see v1's comment about the commit message. ;-)
> 2.7.4
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
2021-04-21 7:18 ` Wang, Haiyue
@ 2021-04-21 7:28 ` Min Hu (Connor)
0 siblings, 0 replies; 12+ messages in thread
From: Min Hu (Connor) @ 2021-04-21 7:28 UTC (permalink / raw)
To: Wang, Haiyue, dev; +Cc: Yigit, Ferruh, Guo, Jia
在 2021/4/21 15:18, Wang, Haiyue 写道:
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Wednesday, April 21, 2021 15:12
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
>> <haiyue.wang@intel.com>
>> Subject: [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
>>
>> From: Chengwen Feng <fengchengwen@huawei.com>
>>
>> This patch fixes e1000_write_nvm_srwr() alwayes return success.
>
>
> Please see v1's comment about the commit message. ;-)
>
Hi, Haiyue,
sorry for that.
First v2 is wrong, I send v2 twice, please check it out, thanks.
>> 2.7.4
>
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
2021-04-21 7:12 ` Min Hu (Connor)
2021-04-21 7:18 ` Wang, Haiyue
@ 2021-04-21 7:34 ` Wang, Haiyue
2021-04-21 9:15 ` Min Hu (Connor)
1 sibling, 1 reply; 12+ messages in thread
From: Wang, Haiyue @ 2021-04-21 7:34 UTC (permalink / raw)
To: Min Hu (Connor), dev; +Cc: Yigit, Ferruh, Guo, Jia
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Wednesday, April 21, 2021 15:12
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Subject: [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
>
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> This patch fixes e1000_write_nvm_srwr() alwayes return success.
>
As I said in v1:
"This commit message seems not so correct, it should be like:
This fixes the timed out for shadow RAM write EEWR can't be detected."
What do you think ?
> Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v2:
> * change 'E1000_ERR_NVM' to '-E1000_ERR_NVM'.
> ---
> --
> 2.7.4
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
2021-04-21 7:34 ` Wang, Haiyue
@ 2021-04-21 9:15 ` Min Hu (Connor)
0 siblings, 0 replies; 12+ messages in thread
From: Min Hu (Connor) @ 2021-04-21 9:15 UTC (permalink / raw)
To: Wang, Haiyue, dev; +Cc: Yigit, Ferruh, Guo, Jia
Hi,
在 2021/4/21 15:34, Wang, Haiyue 写道:
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Wednesday, April 21, 2021 15:12
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
>> <haiyue.wang@intel.com>
>> Subject: [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
>>
>> From: Chengwen Feng <fengchengwen@huawei.com>
>>
>> This patch fixes e1000_write_nvm_srwr() alwayes return success.
>>
>
> As I said in v1:
>
> "This commit message seems not so correct, it should be like:
>
> This fixes the timed out for shadow RAM write EEWR can't be detected."
>
> What do you think ?
Fixed in v3, thanks.
>
>> Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>> v2:
>> * change 'E1000_ERR_NVM' to '-E1000_ERR_NVM'.
>> ---
>
>
>
>> --
>> 2.7.4
>
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM write
2021-04-21 6:22 [dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success Min Hu (Connor)
` (2 preceding siblings ...)
2021-04-21 7:12 ` Min Hu (Connor)
@ 2021-04-21 9:15 ` Min Hu (Connor)
2021-04-21 11:22 ` Wang, Haiyue
3 siblings, 1 reply; 12+ messages in thread
From: Min Hu (Connor) @ 2021-04-21 9:15 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, jia.guo, haiyue.wang
From: Chengwen Feng <fengchengwen@huawei.com>
This fixes the timed out for shadow RAM write EEWR can't be detected.
Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v3:
* update commit info.
v2:
* change 'E1000_ERR_NVM' to '-E1000_ERR_NVM'.
---
drivers/net/e1000/base/e1000_i210.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c
index 3c349d3..5280037 100644
--- a/drivers/net/e1000/base/e1000_i210.c
+++ b/drivers/net/e1000/base/e1000_i210.c
@@ -310,6 +310,8 @@ STATIC s32 e1000_write_nvm_srwr(struct e1000_hw *hw, u16 offset, u16 words,
}
for (i = 0; i < words; i++) {
+ ret_val = -E1000_ERR_NVM;
+
eewr = ((offset + i) << E1000_NVM_RW_ADDR_SHIFT) |
(data[i] << E1000_NVM_RW_REG_DATA) |
E1000_NVM_RW_REG_START;
--
2.7.4
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM write
2021-04-21 9:15 ` [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM write Min Hu (Connor)
@ 2021-04-21 11:22 ` Wang, Haiyue
2021-04-21 14:38 ` Zhang, Qi Z
0 siblings, 1 reply; 12+ messages in thread
From: Wang, Haiyue @ 2021-04-21 11:22 UTC (permalink / raw)
To: Min Hu (Connor), dev; +Cc: Yigit, Ferruh, Guo, Jia
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Wednesday, April 21, 2021 17:16
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Subject: [PATCH v3] net/e1000: fix timed out for shadow RAM write
>
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> This fixes the timed out for shadow RAM write EEWR can't be detected.
>
> Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v3:
> * update commit info.
>
> v2:
> * change 'E1000_ERR_NVM' to '-E1000_ERR_NVM'.
> ---
> drivers/net/e1000/base/e1000_i210.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Thanks!
Acked-by: Haiyue Wang <haiyue.wang@intel.com>
> --
> 2.7.4
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM write
2021-04-21 11:22 ` Wang, Haiyue
@ 2021-04-21 14:38 ` Zhang, Qi Z
0 siblings, 0 replies; 12+ messages in thread
From: Zhang, Qi Z @ 2021-04-21 14:38 UTC (permalink / raw)
To: Wang, Haiyue, Min Hu (Connor), dev; +Cc: Yigit, Ferruh, Guo, Jia
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wang, Haiyue
> Sent: Wednesday, April 21, 2021 7:22 PM
> To: Min Hu (Connor) <humin29@huawei.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM
> write
>
> > -----Original Message-----
> > From: Min Hu (Connor) <humin29@huawei.com>
> > Sent: Wednesday, April 21, 2021 17:16
> > To: dev@dpdk.org
> > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia
> > <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> > Subject: [PATCH v3] net/e1000: fix timed out for shadow RAM write
> >
> > From: Chengwen Feng <fengchengwen@huawei.com>
> >
> > This fixes the timed out for shadow RAM write EEWR can't be detected.
> >
> > Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> > ---
> > v3:
> > * update commit info.
> >
> > v2:
> > * change 'E1000_ERR_NVM' to '-E1000_ERR_NVM'.
> > ---
> > drivers/net/e1000/base/e1000_i210.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
> Thanks!
>
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
>
> > --
> > 2.7.4
^ permalink raw reply [flat|nested] 12+ messages in thread