DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/2] fix bugs for librte eal
@ 2021-04-21  1:17 Min Hu (Connor)
  2021-04-21  1:17 ` [dpdk-dev] [PATCH 1/2] eal: check mp reply result Min Hu (Connor)
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Min Hu (Connor) @ 2021-04-21  1:17 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, jerinj, skori

This patchset fixed some bugs for librte_eal.

Chengwen Feng (2):
  eal: check mp reply result
  eal: fix service core index validity

 lib/librte_eal/common/eal_common_options.c | 2 ++
 lib/librte_eal/common/malloc_mp.c          | 4 +---
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-dev] [PATCH 1/2] eal: check mp reply result
  2021-04-21  1:17 [dpdk-dev] [PATCH 0/2] fix bugs for librte eal Min Hu (Connor)
@ 2021-04-21  1:17 ` Min Hu (Connor)
  2021-04-21  1:17 ` [dpdk-dev] [PATCH 2/2] eal: fix service core index validity Min Hu (Connor)
  2021-04-29  2:34 ` [dpdk-dev] [PATCH v2 0/2] fix bugs for librte eal Min Hu (Connor)
  2 siblings, 0 replies; 15+ messages in thread
From: Min Hu (Connor) @ 2021-04-21  1:17 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, jerinj, skori

From: Chengwen Feng <fengchengwen@huawei.com>

This patch adds checking for mp reply result in handle_sync().

Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 lib/librte_eal/common/malloc_mp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/librte_eal/common/malloc_mp.c b/lib/librte_eal/common/malloc_mp.c
index c7101b3..2e597a1 100644
--- a/lib/librte_eal/common/malloc_mp.c
+++ b/lib/librte_eal/common/malloc_mp.c
@@ -171,9 +171,7 @@ handle_sync(const struct rte_mp_msg *msg, const void *peer)
 	resp->id = req->id;
 	resp->result = ret == 0 ? REQ_RESULT_SUCCESS : REQ_RESULT_FAIL;
 
-	rte_mp_reply(&reply, peer);
-
-	return 0;
+	return rte_mp_reply(&reply, peer);
 }
 
 static int
-- 
2.7.4


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-dev] [PATCH 2/2] eal: fix service core index validity
  2021-04-21  1:17 [dpdk-dev] [PATCH 0/2] fix bugs for librte eal Min Hu (Connor)
  2021-04-21  1:17 ` [dpdk-dev] [PATCH 1/2] eal: check mp reply result Min Hu (Connor)
@ 2021-04-21  1:17 ` Min Hu (Connor)
  2021-04-21  2:33   ` Stephen Hemminger
  2021-04-29  2:34 ` [dpdk-dev] [PATCH v2 0/2] fix bugs for librte eal Min Hu (Connor)
  2 siblings, 1 reply; 15+ messages in thread
From: Min Hu (Connor) @ 2021-04-21  1:17 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, jerinj, skori

From: Chengwen Feng <fengchengwen@huawei.com>

This patch adds checking for service core index validity when parsing
service corelist.

Fixes: 7dbd7a6413ef ("service: add -S corelist option")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 lib/librte_eal/common/eal_common_options.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 66f9114..b4da878 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -785,6 +785,8 @@ eal_parse_service_corelist(const char *corelist)
 		idx = strtoul(corelist, &end, 10);
 		if (errno || end == NULL)
 			return -1;
+		if (idx < 0 || idx >= RTE_MAX_LCORE)
+			return -1;
 		while (isblank(*end))
 			end++;
 		if (*end == '-') {
-- 
2.7.4


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH 2/2] eal: fix service core index validity
  2021-04-21  1:17 ` [dpdk-dev] [PATCH 2/2] eal: fix service core index validity Min Hu (Connor)
@ 2021-04-21  2:33   ` Stephen Hemminger
  2021-04-29  2:34     ` Min Hu (Connor)
  0 siblings, 1 reply; 15+ messages in thread
From: Stephen Hemminger @ 2021-04-21  2:33 UTC (permalink / raw)
  To: Min Hu (Connor); +Cc: dev, ferruh.yigit, jerinj, skori

On Wed, 21 Apr 2021 09:17:17 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:

>  		idx = strtoul(corelist, &end, 10);
>  		if (errno || end == NULL)
>  			return -1;
> +		if (idx < 0 || idx >= RTE_MAX_LCORE)

Wondered at first how strtoul() could ever return an negative value but then
noticed that idx is int here.

The code that does would be clearer and safer if the variables were an unsigned
type. idx, min, max should be the same type everywhere.

Looks like the original code was written in old C style of "all the world's an int"

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-dev] [PATCH v2 0/2] fix bugs for librte eal
  2021-04-21  1:17 [dpdk-dev] [PATCH 0/2] fix bugs for librte eal Min Hu (Connor)
  2021-04-21  1:17 ` [dpdk-dev] [PATCH 1/2] eal: check mp reply result Min Hu (Connor)
  2021-04-21  1:17 ` [dpdk-dev] [PATCH 2/2] eal: fix service core index validity Min Hu (Connor)
@ 2021-04-29  2:34 ` Min Hu (Connor)
  2021-04-29  2:34   ` [dpdk-dev] [PATCH v2 1/2] eal: check mp reply result Min Hu (Connor)
                     ` (2 more replies)
  2 siblings, 3 replies; 15+ messages in thread
From: Min Hu (Connor) @ 2021-04-29  2:34 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, jerinj, skori, stephen

This patchset fixed some bugs for librte_eal.

Min Hu (Connor) (2):
  eal: check mp reply result
  eal: fix service core index validity
---
v2:
* set variables an unsigned type.

 lib/eal/common/eal_common_options.c | 6 ++++--
 lib/eal/common/malloc_mp.c          | 4 +---
 2 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-dev] [PATCH v2 1/2] eal: check mp reply result
  2021-04-29  2:34 ` [dpdk-dev] [PATCH v2 0/2] fix bugs for librte eal Min Hu (Connor)
@ 2021-04-29  2:34   ` Min Hu (Connor)
  2021-05-04 16:54     ` Thomas Monjalon
  2021-04-29  2:34   ` [dpdk-dev] [PATCH v2 2/2] eal: fix service core index validity Min Hu (Connor)
  2021-05-05  4:10   ` [dpdk-dev] [PATCH v3 0/2] fix bugs for librte eal Chengwen Feng
  2 siblings, 1 reply; 15+ messages in thread
From: Min Hu (Connor) @ 2021-04-29  2:34 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, jerinj, skori, stephen

This patch adds checking for mp reply result in handle_sync().

Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 lib/eal/common/malloc_mp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/eal/common/malloc_mp.c b/lib/eal/common/malloc_mp.c
index c7101b3..2e597a1 100644
--- a/lib/eal/common/malloc_mp.c
+++ b/lib/eal/common/malloc_mp.c
@@ -171,9 +171,7 @@ handle_sync(const struct rte_mp_msg *msg, const void *peer)
 	resp->id = req->id;
 	resp->result = ret == 0 ? REQ_RESULT_SUCCESS : REQ_RESULT_FAIL;
 
-	rte_mp_reply(&reply, peer);
-
-	return 0;
+	return rte_mp_reply(&reply, peer);
 }
 
 static int
-- 
2.7.4


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-dev] [PATCH v2 2/2] eal: fix service core index validity
  2021-04-29  2:34 ` [dpdk-dev] [PATCH v2 0/2] fix bugs for librte eal Min Hu (Connor)
  2021-04-29  2:34   ` [dpdk-dev] [PATCH v2 1/2] eal: check mp reply result Min Hu (Connor)
@ 2021-04-29  2:34   ` Min Hu (Connor)
  2021-05-04 16:54     ` Thomas Monjalon
  2021-05-05  4:10   ` [dpdk-dev] [PATCH v3 0/2] fix bugs for librte eal Chengwen Feng
  2 siblings, 1 reply; 15+ messages in thread
From: Min Hu (Connor) @ 2021-04-29  2:34 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, jerinj, skori, stephen

This patch adds checking for service core index validity when parsing
service corelist.

Fixes: 7dbd7a6413ef ("service: add -S corelist option")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 lib/eal/common/eal_common_options.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c
index 66f9114..97ab6e0 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -758,10 +758,10 @@ static int
 eal_parse_service_corelist(const char *corelist)
 {
 	struct rte_config *cfg = rte_eal_get_configuration();
-	int i, idx = 0;
+	int i;
 	unsigned count = 0;
 	char *end = NULL;
-	int min, max;
+	uint32_t min, max, idx;
 	uint32_t taken_lcore_count = 0;
 
 	if (corelist == NULL)
@@ -785,6 +785,8 @@ eal_parse_service_corelist(const char *corelist)
 		idx = strtoul(corelist, &end, 10);
 		if (errno || end == NULL)
 			return -1;
+		if (idx >= RTE_MAX_LCORE)
+			return -1;
 		while (isblank(*end))
 			end++;
 		if (*end == '-') {
-- 
2.7.4


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH 2/2] eal: fix service core index validity
  2021-04-21  2:33   ` Stephen Hemminger
@ 2021-04-29  2:34     ` Min Hu (Connor)
  0 siblings, 0 replies; 15+ messages in thread
From: Min Hu (Connor) @ 2021-04-29  2:34 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, ferruh.yigit, jerinj, skori

Hi, fixed in v2, thanks.

在 2021/4/21 10:33, Stephen Hemminger 写道:
> On Wed, 21 Apr 2021 09:17:17 +0800
> "Min Hu (Connor)" <humin29@huawei.com> wrote:
> 
>>   		idx = strtoul(corelist, &end, 10);
>>   		if (errno || end == NULL)
>>   			return -1;
>> +		if (idx < 0 || idx >= RTE_MAX_LCORE)
> 
> Wondered at first how strtoul() could ever return an negative value but then
> noticed that idx is int here.
> 
> The code that does would be clearer and safer if the variables were an unsigned
> type. idx, min, max should be the same type everywhere.
> 
> Looks like the original code was written in old C style of "all the world's an int"
> .
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH v2 2/2] eal: fix service core index validity
  2021-04-29  2:34   ` [dpdk-dev] [PATCH v2 2/2] eal: fix service core index validity Min Hu (Connor)
@ 2021-05-04 16:54     ` Thomas Monjalon
  0 siblings, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2021-05-04 16:54 UTC (permalink / raw)
  To: Min Hu (Connor)
  Cc: dev, ferruh.yigit, jerinj, skori, stephen, harry.van.haaren

+Cc Harry

29/04/2021 04:34, Min Hu (Connor):
> This patch adds checking for service core index validity when parsing
> service corelist.
> 
> Fixes: 7dbd7a6413ef ("service: add -S corelist option")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
>  lib/eal/common/eal_common_options.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c
> index 66f9114..97ab6e0 100644
> --- a/lib/eal/common/eal_common_options.c
> +++ b/lib/eal/common/eal_common_options.c
> @@ -758,10 +758,10 @@ static int
>  eal_parse_service_corelist(const char *corelist)
>  {
>  	struct rte_config *cfg = rte_eal_get_configuration();
> -	int i, idx = 0;
> +	int i;
>  	unsigned count = 0;
>  	char *end = NULL;
> -	int min, max;
> +	uint32_t min, max, idx;
>  	uint32_t taken_lcore_count = 0;
>  
>  	if (corelist == NULL)
> @@ -785,6 +785,8 @@ eal_parse_service_corelist(const char *corelist)
>  		idx = strtoul(corelist, &end, 10);
>  		if (errno || end == NULL)
>  			return -1;
> +		if (idx >= RTE_MAX_LCORE)
> +			return -1;
>  		while (isblank(*end))
>  			end++;
>  		if (*end == '-') {
> 






^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH v2 1/2] eal: check mp reply result
  2021-04-29  2:34   ` [dpdk-dev] [PATCH v2 1/2] eal: check mp reply result Min Hu (Connor)
@ 2021-05-04 16:54     ` Thomas Monjalon
  0 siblings, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2021-05-04 16:54 UTC (permalink / raw)
  To: Min Hu (Connor)
  Cc: dev, ferruh.yigit, jerinj, skori, stephen, anatoly.burakov

+Cc Anatoly

29/04/2021 04:34, Min Hu (Connor):
> This patch adds checking for mp reply result in handle_sync().
> 
> Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
>  lib/eal/common/malloc_mp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/lib/eal/common/malloc_mp.c b/lib/eal/common/malloc_mp.c
> index c7101b3..2e597a1 100644
> --- a/lib/eal/common/malloc_mp.c
> +++ b/lib/eal/common/malloc_mp.c
> @@ -171,9 +171,7 @@ handle_sync(const struct rte_mp_msg *msg, const void *peer)
>  	resp->id = req->id;
>  	resp->result = ret == 0 ? REQ_RESULT_SUCCESS : REQ_RESULT_FAIL;
>  
> -	rte_mp_reply(&reply, peer);
> -
> -	return 0;
> +	return rte_mp_reply(&reply, peer);
>  }





^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-dev] [PATCH v3 0/2] fix bugs for librte eal
  2021-04-29  2:34 ` [dpdk-dev] [PATCH v2 0/2] fix bugs for librte eal Min Hu (Connor)
  2021-04-29  2:34   ` [dpdk-dev] [PATCH v2 1/2] eal: check mp reply result Min Hu (Connor)
  2021-04-29  2:34   ` [dpdk-dev] [PATCH v2 2/2] eal: fix service core index validity Min Hu (Connor)
@ 2021-05-05  4:10   ` Chengwen Feng
  2021-05-05  4:10     ` [dpdk-dev] [PATCH v3 1/2] eal: check mp reply result Chengwen Feng
  2021-05-05  4:10     ` [dpdk-dev] [PATCH v3 2/2] eal: fix service core index validity Chengwen Feng
  2 siblings, 2 replies; 15+ messages in thread
From: Chengwen Feng @ 2021-05-05  4:10 UTC (permalink / raw)
  To: thomas, ferruh.yigit, skori, jerinj, anatoly.burakov,
	harry.van.haaren, stephen
  Cc: dev, linuxarm

This patchset fixed some bugs for librte_eal.

v3:
* change patch's author
v2:
* set variables an unsigned type.

Chengwen Feng (2):
  eal: check mp reply result
  eal: fix service core index validity

 lib/eal/common/eal_common_options.c | 6 ++++--
 lib/eal/common/malloc_mp.c          | 4 +---
 2 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.8.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-dev] [PATCH v3 1/2] eal: check mp reply result
  2021-05-05  4:10   ` [dpdk-dev] [PATCH v3 0/2] fix bugs for librte eal Chengwen Feng
@ 2021-05-05  4:10     ` Chengwen Feng
  2021-05-05  4:10     ` [dpdk-dev] [PATCH v3 2/2] eal: fix service core index validity Chengwen Feng
  1 sibling, 0 replies; 15+ messages in thread
From: Chengwen Feng @ 2021-05-05  4:10 UTC (permalink / raw)
  To: thomas, ferruh.yigit, skori, jerinj, anatoly.burakov,
	harry.van.haaren, stephen
  Cc: dev, linuxarm

This patch adds checking for mp reply result in handle_sync().

Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v2->v3:
* change patch's author
---
 lib/eal/common/malloc_mp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/eal/common/malloc_mp.c b/lib/eal/common/malloc_mp.c
index c7101b3..2e597a1 100644
--- a/lib/eal/common/malloc_mp.c
+++ b/lib/eal/common/malloc_mp.c
@@ -171,9 +171,7 @@ handle_sync(const struct rte_mp_msg *msg, const void *peer)
 	resp->id = req->id;
 	resp->result = ret == 0 ? REQ_RESULT_SUCCESS : REQ_RESULT_FAIL;
 
-	rte_mp_reply(&reply, peer);
-
-	return 0;
+	return rte_mp_reply(&reply, peer);
 }
 
 static int
-- 
2.8.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-dev] [PATCH v3 2/2] eal: fix service core index validity
  2021-05-05  4:10   ` [dpdk-dev] [PATCH v3 0/2] fix bugs for librte eal Chengwen Feng
  2021-05-05  4:10     ` [dpdk-dev] [PATCH v3 1/2] eal: check mp reply result Chengwen Feng
@ 2021-05-05  4:10     ` Chengwen Feng
  2021-05-05 10:43       ` Van Haaren, Harry
  1 sibling, 1 reply; 15+ messages in thread
From: Chengwen Feng @ 2021-05-05  4:10 UTC (permalink / raw)
  To: thomas, ferruh.yigit, skori, jerinj, anatoly.burakov,
	harry.van.haaren, stephen
  Cc: dev, linuxarm

This patch adds checking for service core index validity when parsing
service corelist.

Fixes: 7dbd7a6413ef ("service: add -S corelist option")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v2->v3:
* change patch's author
---
 lib/eal/common/eal_common_options.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c
index 66f9114..97ab6e0 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -758,10 +758,10 @@ static int
 eal_parse_service_corelist(const char *corelist)
 {
 	struct rte_config *cfg = rte_eal_get_configuration();
-	int i, idx = 0;
+	int i;
 	unsigned count = 0;
 	char *end = NULL;
-	int min, max;
+	uint32_t min, max, idx;
 	uint32_t taken_lcore_count = 0;
 
 	if (corelist == NULL)
@@ -785,6 +785,8 @@ eal_parse_service_corelist(const char *corelist)
 		idx = strtoul(corelist, &end, 10);
 		if (errno || end == NULL)
 			return -1;
+		if (idx >= RTE_MAX_LCORE)
+			return -1;
 		while (isblank(*end))
 			end++;
 		if (*end == '-') {
-- 
2.8.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH v3 2/2] eal: fix service core index validity
  2021-05-05  4:10     ` [dpdk-dev] [PATCH v3 2/2] eal: fix service core index validity Chengwen Feng
@ 2021-05-05 10:43       ` Van Haaren, Harry
  2021-05-05 21:23         ` Thomas Monjalon
  0 siblings, 1 reply; 15+ messages in thread
From: Van Haaren, Harry @ 2021-05-05 10:43 UTC (permalink / raw)
  To: Chengwen Feng, thomas, Yigit, Ferruh, skori, jerinj, Burakov,
	Anatoly, stephen
  Cc: dev, linuxarm

> -----Original Message-----
> From: Chengwen Feng <fengchengwen@huawei.com>
> Sent: Wednesday, May 5, 2021 5:10 AM
> To: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>;
> skori@marvell.com; jerinj@marvell.com; Burakov, Anatoly
> <anatoly.burakov@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> stephen@networkplumber.org
> Cc: dev@dpdk.org; linuxarm@openeuler.org
> Subject: [PATCH v3 2/2] eal: fix service core index validity
> 
> This patch adds checking for service core index validity when parsing
> service corelist.
> 
> Fixes: 7dbd7a6413ef ("service: add -S corelist option")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Thanks,

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH v3 2/2] eal: fix service core index validity
  2021-05-05 10:43       ` Van Haaren, Harry
@ 2021-05-05 21:23         ` Thomas Monjalon
  0 siblings, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2021-05-05 21:23 UTC (permalink / raw)
  To: Chengwen Feng
  Cc: Yigit, Ferruh, skori, jerinj, Burakov, Anatoly, stephen, dev,
	linuxarm, Van Haaren, Harry

05/05/2021 12:43, Van Haaren, Harry:
> From: Chengwen Feng <fengchengwen@huawei.com>
> > 
> > This patch adds checking for service core index validity when parsing
> > service corelist.
> > 
> > Fixes: 7dbd7a6413ef ("service: add -S corelist option")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> 
> Thanks,
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Series applied, thanks.




^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2021-05-05 21:23 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21  1:17 [dpdk-dev] [PATCH 0/2] fix bugs for librte eal Min Hu (Connor)
2021-04-21  1:17 ` [dpdk-dev] [PATCH 1/2] eal: check mp reply result Min Hu (Connor)
2021-04-21  1:17 ` [dpdk-dev] [PATCH 2/2] eal: fix service core index validity Min Hu (Connor)
2021-04-21  2:33   ` Stephen Hemminger
2021-04-29  2:34     ` Min Hu (Connor)
2021-04-29  2:34 ` [dpdk-dev] [PATCH v2 0/2] fix bugs for librte eal Min Hu (Connor)
2021-04-29  2:34   ` [dpdk-dev] [PATCH v2 1/2] eal: check mp reply result Min Hu (Connor)
2021-05-04 16:54     ` Thomas Monjalon
2021-04-29  2:34   ` [dpdk-dev] [PATCH v2 2/2] eal: fix service core index validity Min Hu (Connor)
2021-05-04 16:54     ` Thomas Monjalon
2021-05-05  4:10   ` [dpdk-dev] [PATCH v3 0/2] fix bugs for librte eal Chengwen Feng
2021-05-05  4:10     ` [dpdk-dev] [PATCH v3 1/2] eal: check mp reply result Chengwen Feng
2021-05-05  4:10     ` [dpdk-dev] [PATCH v3 2/2] eal: fix service core index validity Chengwen Feng
2021-05-05 10:43       ` Van Haaren, Harry
2021-05-05 21:23         ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git