From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6E69A0546; Fri, 30 Apr 2021 11:04:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9765C4113B; Fri, 30 Apr 2021 11:04:07 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 838644013F for ; Fri, 30 Apr 2021 11:04:02 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FWmZL1Hk3z19MKH for ; Fri, 30 Apr 2021 17:01:30 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Fri, 30 Apr 2021 17:03:56 +0800 From: "Min Hu (Connor)" To: CC: Date: Fri, 30 Apr 2021 17:04:02 +0800 Message-ID: <1619773444-10074-2-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1619773444-10074-1-git-send-email-humin29@huawei.com> References: <1619773444-10074-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH 1/3] net/hns3: remove read when enabling TM QCN error event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Chengwen Feng According to the HW manual, the read operation is unnecessary when enabling TM QCN error event, so remove it. Fixes: f53a793bb7c2 ("net/hns3: add more hardware error types") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_intr.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/hns3/hns3_intr.c b/drivers/net/hns3/hns3_intr.c index b743b41..62e89a9 100644 --- a/drivers/net/hns3/hns3_intr.c +++ b/drivers/net/hns3/hns3_intr.c @@ -1782,14 +1782,7 @@ enable_tm_err_intr(struct hns3_adapter *hns, bool en) } /* configure TM QCN hw errors */ - hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_TM_QCN_MEM_INT_CFG, true); - ret = hns3_cmd_send(hw, &desc, 1); - if (ret) { - hns3_err(hw, "fail to read TM QCN CFG status, ret = %d\n", ret); - return ret; - } - - hns3_cmd_reuse_desc(&desc, false); + hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_TM_QCN_MEM_INT_CFG, false); if (en) desc.data[1] = rte_cpu_to_le_32(HNS3_TM_QCN_MEM_ERR_INT_EN); -- 2.7.4