From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 632F8A0524;
Thu, 6 May 2021 05:46:27 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 0E981410FC;
Thu, 6 May 2021 05:46:18 +0200 (CEST)
Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])
by mails.dpdk.org (Postfix) with ESMTP id F1ACA410EE
for <dev@dpdk.org>; Thu, 6 May 2021 05:46:13 +0200 (CEST)
Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58])
by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FbKDm5qyPzkWmQ;
Thu, 6 May 2021 11:43:36 +0800 (CST)
Received: from localhost.localdomain (10.69.192.56) by
DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id
14.3.498.0; Thu, 6 May 2021 11:46:10 +0800
From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
CC: <ferruh.yigit@intel.com>, <thomas@monjalon.net>
Date: Thu, 6 May 2021 11:46:08 +0800
Message-ID: <1620272768-42421-3-git-send-email-humin29@huawei.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1620272768-42421-1-git-send-email-humin29@huawei.com>
References: <1617876888-63458-1-git-send-email-humin29@huawei.com>
<1620272768-42421-1-git-send-email-humin29@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.69.192.56]
X-CFilter-Loop: Reflected
Subject: [dpdk-dev] [PATCH v2 2/2] examples/ethtool: add closing port
operation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Huisong Li <lihuisong@huawei.com>
Currently, ethtool directly ends the process after 'quit' cmd. In this
case, software resources are not released and hardware resources of the
device are not uninstalled.
This patch adds closing port operation to release resources.
Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
examples/ethtool/ethtool-app/main.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c
index 21ed85c..9ac0a44 100644
--- a/examples/ethtool/ethtool-app/main.c
+++ b/examples/ethtool/ethtool-app/main.c
@@ -256,6 +256,22 @@ static int worker_main(__rte_unused void *ptr_data)
return 0;
}
+static void close_ports(void)
+{
+ uint16_t portid;
+ int ret;
+
+ for (portid = 0; portid < app_cfg.cnt_ports; portid++) {
+ printf("Closing port %d...", portid);
+ ret = rte_eth_dev_stop(portid);
+ if (ret != 0)
+ rte_exit(EXIT_FAILURE, "rte_eth_dev_stop: err=%s, port=%u\n",
+ strerror(-ret), portid);
+ rte_eth_dev_close(portid);
+ printf(" Done\n");
+ }
+}
+
int main(int argc, char **argv)
{
int cnt_args_parsed;
@@ -299,6 +315,8 @@ int main(int argc, char **argv)
return -1;
}
+ close_ports();
+
/* clean up the EAL */
rte_eal_cleanup();
--
2.7.4