DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>, <thomas@monjalon.net>,
	<david.marchand@redhat.com>, <jerinj@marvell.com>,
	<kirankumark@marvell.com>
Subject: [dpdk-dev] [PATCH v2 2/2] graph: fix dereferencing null pointer
Date: Thu, 6 May 2021 15:16:27 +0800	[thread overview]
Message-ID: <1620285387-42792-3-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1620285387-42792-1-git-send-email-humin29@huawei.com>

From: HongBo Zheng <zhenghongbo3@huawei.com>

In function 'stats_mem_init', pointer 'stats' should
be confirmed not null before memset it.

Fixes: af1ae8b6a32c ("graph: implement stats")
Cc: stable@dpdk.org

Signed-off-by: HongBo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 lib/graph/graph_stats.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c
index 30e295d..aa70929 100644
--- a/lib/graph/graph_stats.c
+++ b/lib/graph/graph_stats.c
@@ -119,8 +119,8 @@ stats_mem_init(struct cluster *cluster,
 	cluster_node_size = RTE_ALIGN(cluster_node_size, RTE_CACHE_LINE_SIZE);
 
 	stats = realloc(NULL, sz);
-	memset(stats, 0, sz);
 	if (stats) {
+		memset(stats, 0, sz);
 		stats->fn = fn;
 		stats->cluster_node_size = cluster_node_size;
 		stats->max_nodes = 0;
-- 
2.7.4


  parent reply	other threads:[~2021-05-06  7:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 11:52 [dpdk-dev] [PATCH 0/2] bugfix for graph Min Hu (Connor)
2021-04-22 11:52 ` [dpdk-dev] [PATCH 1/2] graph: fix memory leak Min Hu (Connor)
2021-04-23  3:52   ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2021-05-04 14:15   ` [dpdk-dev] " David Marchand
2021-05-06  7:18     ` Min Hu (Connor)
2021-04-22 11:52 ` [dpdk-dev] [PATCH 2/2] graph: fix dereferencing null pointer Min Hu (Connor)
2021-04-23  3:52   ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2021-04-23  9:05   ` [dpdk-dev] " Jerin Jacob
2021-05-06  7:16 ` [dpdk-dev] [PATCH v2 0/2] bugfix for graph Min Hu (Connor)
2021-05-06  7:16   ` [dpdk-dev] [PATCH v2 1/2] graph: fix memory leak Min Hu (Connor)
2021-05-10 13:26     ` David Marchand
2021-05-06  7:16   ` Min Hu (Connor) [this message]
2021-05-06  9:01     ` [dpdk-dev] [PATCH v2 2/2] graph: fix dereferencing null pointer Jerin Jacob
2021-05-10 13:27     ` David Marchand
2021-06-03 16:40   ` [dpdk-dev] [PATCH v2 0/2] bugfix for graph David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1620285387-42792-3-git-send-email-humin29@huawei.com \
    --to=humin29@huawei.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).