From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 121E5A0577; Mon, 6 Apr 2020 15:36:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32D4E2B96; Mon, 6 Apr 2020 15:36:39 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 9EBB52B83 for ; Mon, 6 Apr 2020 15:36:37 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 361D5580186; Mon, 6 Apr 2020 09:36:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 06 Apr 2020 09:36:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=IUcbKTJkkaa2coxVffb/2+HolRpESw2jYSv3QhxJrSU=; b=N6xAXSrML/2q KqXdISVFRmFMGJ20Vh6buaeZIDnFScilFzm0Cvhdt2g1KXJw0Z6znY1IIaUNdkTK HW5g6pWYQgD/QA4NeUIhneP5xMwmtpnOWuedurlg1lnDI5Yv7yoxRzQobhG32i5X b1R69yEh/x4OhThtsqzByaKlPZ92ImU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=IUcbKTJkkaa2coxVffb/2+HolRpESw2jYSv3QhxJr SU=; b=fn3LLdbUIwmESsGTkQvIyx3++Oy/y1/dzQXDinE24y7Jw0U4UQ9r5Ett6 c996j16gq2NSWIKI3FtUBGGtL4jlM2GDBTty7eOYZ6h5Zo8Vd/wPAc47+6CEmrhz yiHZ1EA0dz6sYgziReLVxTzBvvpBw/gojM5L/sR3Xy+pm2ruEL9FDbiw8ph0AGmG HwWhLJsmMDGQgtIz9W79pw4MF8jd9lie/AfnDz/E0xleyfP7z2XNYpnxGvOFd0fJ 5SD29Jx3nbrnlPVQX0vDKVTTipd0JkjfW3iBWwhKkF/0GdByc84GukKZVGSmypw3 RjQcRqA7sk3PMNFyhHDQdGE68Hbhw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefgdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepphhrohhofhhpohhinhhtrdgtohhmpddvuggrrhgthhhivhgvrdgtohhmpdeg tdguphgukhdrohhrghdpughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrud ekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ED101306D3F9; Mon, 6 Apr 2020 09:36:31 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: Ori Kam , Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , "david.marchand@redhat.com" Date: Mon, 06 Apr 2020 15:36:30 +0200 Message-ID: <1620573.TTEOE9XjLl@xps> In-Reply-To: References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <5151953.QU4070AmJz@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/04/2020 15:22, Pavan Nikhilesh Bhagavatula: > >06/04/2020 14:33, Pavan Nikhilesh Bhagavatula: > >> >> From: Pavan Nikhilesh Bhagavatula > >> >> > >+uint16_t > >> >> > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t > >qp_id, > >> >> > >+ struct rte_regex_ops **ops, uint16_t > >nb_ops) > >> >> > >+{ > >> >> > >+ return regex_devices[dev_id]- > >> >> > >>enqueue(regex_devices[dev_id], qp_id, > >> >> > >+ ops, nb_ops); > >> >> > >+} > >> >> > > >> >> > Move these functions to .h in-lining them. > >> >> > Also, please add debug checks @see > >> >rte_eth_rx_burst/rte_eth_tx_burst. > >> >> > >> >> O.K will update. > >> > > >> >In general, inlining is a pain for ABI compatibility. > >> >Please inline only if the gain is very significant. > >> > > >> > >> The performance gain mostly comes from hoisting > >`regex_devices[dev_id]` load above the > >> poll loop. > >> Since, the performance measurement application is still in pipeline > >and regexdev would be > >> experimental for next couple of releases I suggest inlining it now and > >worrying about ABI when > >> experimental tag needs to be removed. > > > >No, we must worry about ABI from the beginning. > > I though performance was the primary objective :-). It is. > >> We can follow the same path as done by ethdev > >[https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mail- > >2Darchive.com_dev- > >40dpdk.org_msg142392.html&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtf > >Q&r=E3SgYMjtKCMVsB-fmvgGV3o- > >g_fjLhk5Pupi9ijohpc&m=7Gqb6WKmZV5uY3xa7FRVrRVDz8Usrsd- > >rDjIKr6CUQQ&s=sQo2Kx9fzTNXwiQ2Fzki3s5GSuiiAEzz2VtN68_KKXo&e= > >] > > > >ethdev is not an argument. > > What about ring? [http://mails.dpdk.org/archives/dev/2020-April/161506.html] > > Why do we need to prove the same performance advantage using in-lining for datapath > critical functions again and again? Because every libraries have not the same usage and load. We should compare how much cycle is saved with inline vs how much cycles is, "in average", a regex burst? If you tell me regex processing is fast, OK, let's inline.