From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id E228AA0C47;
Thu, 13 May 2021 06:45:05 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 6AD044067E;
Thu, 13 May 2021 06:45:05 +0200 (CEST)
Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])
by mails.dpdk.org (Postfix) with ESMTP id 9D20B4003F
for <dev@dpdk.org>; Thu, 13 May 2021 06:45:03 +0200 (CEST)
Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60])
by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FgfCs4d3zzmVcw;
Thu, 13 May 2021 12:42:49 +0800 (CST)
Received: from localhost.localdomain (10.67.165.24) by
DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id
14.3.498.0; Thu, 13 May 2021 12:44:58 +0800
From: Chengwen Feng <fengchengwen@huawei.com>
To: <thomas@monjalon.net>, <ferruh.yigit@intel.com>
CC: <dev@dpdk.org>, <jerinj@marvell.com>, <ruifeng.wang@arm.com>,
<viktorin@rehivetech.com>, <bruce.richardson@intel.com>,
<Honnappa.Nagarahalli@arm.com>, <jerinjacobk@gmail.com>,
<juraj.linkes@pantheon.tech>, <nd@arm.com>
Date: Thu, 13 May 2021 12:41:48 +0800
Message-ID: <1620880909-32429-2-git-send-email-fengchengwen@huawei.com>
X-Mailer: git-send-email 2.8.1
In-Reply-To: <1620880909-32429-1-git-send-email-fengchengwen@huawei.com>
References: <1620808126-18876-1-git-send-email-fengchengwen@huawei.com>
<1620880909-32429-1-git-send-email-fengchengwen@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.67.165.24]
X-CFilter-Loop: Reflected
Subject: [dpdk-dev] [PATCH v2 1/2] config/arm: select best -march parameter
for kunpeng soc
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Currently, the soc_kunpeng930 declares '-march=armv8.2-a+crypto+sve',
but some compiler doesn't recognize the march because it doesn't
support sve.
To solve this bug we use the following scheme:
1. Define 'march_base' tuple which defines support march, it should
arrange from lower to higher.
e.g. 'march_base' : ['-march=armv8-a', '-march=armv8.2-a']
2. Define 'march_feature' tuple which defines support feature.
e.g. 'march_feature' : ['crypto', 'sve']
3. Select the best march+feature combination based on 'march_base'
and 'march_feature' tuples.
4. Use the best march+feature combination as the default machine_args.
Fixes: 7cf32a22b240 ("config/arm: add Hisilicon kunpeng")
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
config/arm/meson.build | 28 +++++++++++++++++++++++++---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 3f34ec9..5b91fe1 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -149,7 +149,9 @@ implementer_hisilicon = {
],
'part_number_config': {
'0xd01': {
- 'machine_args': ['-march=armv8.2-a+crypto', '-mtune=tsv110'],
+ 'march_base' : ['-march=armv8-a', '-march=armv8.2-a'],
+ 'march_feature' : ['crypto'],
+ 'machine_args': ['-mtune=tsv110'],
'flags': [
['RTE_MACHINE', '"Kunpeng 920"'],
['RTE_ARM_FEATURE_ATOMICS', true],
@@ -158,7 +160,9 @@ implementer_hisilicon = {
]
},
'0xd02': {
- 'machine_args': ['-march=armv8.2-a+crypto+sve'],
+ 'march_base' : ['-march=armv8-a', '-march=armv8.2-a'],
+ 'march_feature' : ['crypto', 'sve'],
+ 'machine_args': [],
'flags': [
['RTE_MACHINE', '"Kunpeng 930"'],
['RTE_ARM_FEATURE_ATOMICS', true],
@@ -449,8 +453,26 @@ else
# add/overwrite flags in the proper order
dpdk_flags = flags_common + implementer_config['flags'] + part_number_config.get('flags', []) + soc_flags
+ # select the best march+feature combination
+ machine_march = []
+ if part_number_config.has_key('march_base')
+ foreach arch: part_number_config['march_base']
+ if cc.has_argument(arch)
+ machine_march = arch # Set the higher supported arch as possible
+ endif
+ endforeach
+ endif
+ if part_number_config.has_key('march_feature')
+ foreach feature: part_number_config['march_feature']
+ tmp_machine_march = machine_march + '+' + feature
+ if cc.has_argument(tmp_machine_march)
+ machine_march = tmp_machine_march # Set the morer supported feature as possible
+ endif
+ endforeach
+ endif
+
# apply supported machine args
- machine_args = [] # Clear previous machine args
+ machine_args = machine_march
foreach flag: part_number_config['machine_args']
if cc.has_argument(flag)
machine_args += flag
--
2.8.1