From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 3C4612BA0 for ; Thu, 3 Mar 2016 18:07:32 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id l68so40199654wml.1 for ; Thu, 03 Mar 2016 09:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=WRE8xnd8sGBX6MuCgyy+Z8at+k0FLdfpmyPoDtJTvWo=; b=rdJjOt45mIM9wqsnNQhDXTLtaMUXV0ZiheYM4V6bTneLefzAHu7EJKnwAFwpAITzRM eKhTQh0awISxuePc6j97wp50ibSgcccZRUTd52NH6tIXLjVxfZCa80e9aqGy8zb5CpBx Vsu45ETNWdTxLhQLu9YhPSYxPPW05NkO8DIv9lFEFQElq57lksFxZqh/JU5+0+S8Wb9u K2WxaGqx+yZZeMT3fRqjysxpUnkbpwUyjLcO8qvdn6wp4A49WZBWx6zdbKsbM+RuUonb ozlC7SSDmjeq0zTiTGHPvwfA8ng1dwPkYbkH1WEBfx9AmjzAujlqjvk3UGwavELo38a3 j4iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=WRE8xnd8sGBX6MuCgyy+Z8at+k0FLdfpmyPoDtJTvWo=; b=F/fivRf23N6UNvEpPvAM/OsIccWv6JpVqz2HKRh5twCv8TAi6PYhcSWjAM/MgaXvJB fPXVTa6Hu06ZMM2pBgwGvShDJLDHknBrRKEjd0ZMSm4c+whbdoxE43TsFQ4OZ0dPL2D2 vqRMUO6jlxJOqItREaU+BjSWDkhtuuWggIw9ked7SaNxkdF4N8m46WB9562MlU2dABHm 1JgsiWlCZfBRTRD1K6QNClpCNjBJLiar7mb/5oF/RhE6g1BZs1gVtkbVpdyVFbfhBihX g6M6r8l9nMd5/oaRS2qcWq7ohXV0viV4Xl2dH71jsrobV8d11jAuWwKRKMpdwPWelY2n 0H/g== X-Gm-Message-State: AD7BkJKQI9mtabsuino+nOuel0dUzEZwUks+7/ekiqxWQRd8JZcCLl+bA3GwjcT4XTU3PpJW X-Received: by 10.28.103.3 with SMTP id b3mr98015wmc.65.1457024852031; Thu, 03 Mar 2016 09:07:32 -0800 (PST) Received: from xps13.localnet (163.20.90.92.rev.sfr.net. [92.90.20.163]) by smtp.gmail.com with ESMTPSA id pd1sm41471267wjb.19.2016.03.03.09.07.30 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Mar 2016 09:07:31 -0800 (PST) From: Thomas Monjalon To: "Wiles, Keith" Date: Thu, 03 Mar 2016 18:05:53 +0100 Message-ID: <16212811.xzAJdxdDBC@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <4B0EE92D-AF2B-41CC-A592-6A842AAB334A@intel.com> References: <1456149217-24833-1-git-send-email-keith.wiles@intel.com> <4B0EE92D-AF2B-41CC-A592-6A842AAB334A@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 17:07:32 -0000 2016-03-03 14:43, Wiles, Keith: > >In order to cleanup the configuration files some and reduce > >the number of duplicate configuration information. Add a new > >file called common_base which contains just about all of the > >configuration lines in one place. Then have the common_bsdapp, > >common_linuxapp files include this one file. Then in those OS > >specific files add the delta configuration lines. > > Ping. I got a +1 for this patch just trying to get someone else to agree and ack. I know the current stuff kind of works, but it does require modifying multiple files and while moving this to a single place to modify I did find at least on different. > > I would like to see this one go in unless it just does not make any sense. You have my +1 I'm going to review it.