From: Changpeng Liu <changpeng.liu@intel.com>
To: dev@dpdk.org
Cc: changpeng.liu@intel.com
Subject: [dpdk-dev] [PATCH] eal/hotplug: suppress one error log on primary process
Date: Wed, 19 May 2021 14:45:48 +0800 [thread overview]
Message-ID: <1621406749-15536-1-git-send-email-changpeng.liu@intel.com> (raw)
This is a normal case that the primary process already
owned one PCI device while the secondary process try to
attach it, so suppress the error log here to exclude
this case.
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
---
lib/eal/common/hotplug_mp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/eal/common/hotplug_mp.c b/lib/eal/common/hotplug_mp.c
index ae6010e..bf55056 100644
--- a/lib/eal/common/hotplug_mp.c
+++ b/lib/eal/common/hotplug_mp.c
@@ -98,10 +98,9 @@ static int cmp_dev_name(const struct rte_device *dev, const void *_name)
memset(&da, 0, sizeof(da));
if (req->t == EAL_DEV_REQ_TYPE_ATTACH) {
ret = local_dev_probe(req->devargs, &dev);
- if (ret != 0) {
+ if (ret != 0 && ret != -EEXIST) {
RTE_LOG(ERR, EAL, "Failed to hotplug add device on primary\n");
- if (ret != -EEXIST)
- goto finish;
+ goto finish;
}
ret = eal_dev_hotplug_request_to_secondary(&tmp_req);
if (ret != 0) {
--
1.9.3
next reply other threads:[~2021-05-19 6:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 6:45 Changpeng Liu [this message]
2021-07-10 8:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1621406749-15536-1-git-send-email-changpeng.liu@intel.com \
--to=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).